07-01-2012, 07:52 AM | #181 | |
Grand Sorcerer
Posts: 6,212
Karma: 16534894
Join Date: Sep 2009
Location: UK
Device: Kobo: KA1, ClaraHD, Forma, Libra2, Clara2E. PocketBook: TouchHD3
|
Quote:
and the non-zero body L/R margins are contained in the css file under .somename {margin...} rather than body{margin...} Unfortunately, this would include all epubs which have already been calibre-converted plus some retail epubs. Also, I know that a recent calibre change (much-appreciated, BTW) now puts any @page (and @font-face) in a 2nd page_styles.css file rather than in every single html file, but the current plugin does not remove @page from the htmls as part of this option. But maybe this was outside the scope. |
|
07-01-2012, 07:54 PM | #182 | |
Resident Curmudgeon
Posts: 73,970
Karma: 128903378
Join Date: Nov 2006
Location: Roslindale, Massachusetts
Device: Kobo Libra 2, Kobo Aura H2O, PRS-650, PRS-T1, nook STR, PW3
|
Quote:
Last edited by JSWolf; 07-01-2012 at 08:04 PM. |
|
Advert | |
|
07-02-2012, 05:03 AM | #183 | |||
Wizard
Posts: 1,337
Karma: 123455
Join Date: Apr 2009
Location: Malaysia
Device: PRS-650, iPhone
|
Quote:
Quote:
Quote:
The plugin does know if there is already an @page or not and rewrites it appropriately, aside from moving left/right from body to @page as discussed previously - I understand why Kovid uses body now, but modifying the code to match Calibre would be non-trivial at this point, and what I've done works fine on ADE renderers. This is the first time it's been discussed in over a year, so it doesn't sound particularly critical to me. If you're actually describing a specific use case where the plugin is failing you (but falls within the scope of the feature), PM me a link to a book and steps to reproduce what's bugging you. Edit - to be quite clear - the feature as it's designed is meant to work with the matching check in quality check, and the point is to make sure that all ePub books have margins matching your Calibre preferences. If the book doesn't have margins to start with but you have them specified in your Calibre preferences then the plugin will insert them in order to match Calibre. Top & bottom margins are only supported in @page. Like I said before, if you don't want any margins at all then set your Calibre preferences to zero - if setting them to zero isn't working let me know (Will test Jackie's scenario as mentioned above). Last edited by ldolse; 07-02-2012 at 05:16 AM. |
|||
07-02-2012, 09:23 AM | #184 | |
Resident Curmudgeon
Posts: 73,970
Karma: 128903378
Join Date: Nov 2006
Location: Roslindale, Massachusetts
Device: Kobo Libra 2, Kobo Aura H2O, PRS-650, PRS-T1, nook STR, PW3
|
Quote:
As for the bug, margins are set to no margins and yet the we still get Code:
@page { } Last edited by JSWolf; 07-02-2012 at 09:30 AM. |
|
07-02-2012, 09:29 AM | #185 | |
Grand Sorcerer
Posts: 27,549
Karma: 193191846
Join Date: Jan 2010
Device: Nexus 7, Kindle Fire HD
|
Quote:
|
|
Advert | |
|
07-02-2012, 09:31 AM | #186 |
Resident Curmudgeon
Posts: 73,970
Karma: 128903378
Join Date: Nov 2006
Location: Roslindale, Massachusetts
Device: Kobo Libra 2, Kobo Aura H2O, PRS-650, PRS-T1, nook STR, PW3
|
|
07-02-2012, 12:07 PM | #187 |
Grand Sorcerer
Posts: 27,549
Karma: 193191846
Join Date: Jan 2010
Device: Nexus 7, Kindle Fire HD
|
|
07-02-2012, 01:02 PM | #188 |
Wizard
Posts: 1,337
Karma: 123455
Join Date: Apr 2009
Location: Malaysia
Device: PRS-650, iPhone
|
@JSWolf, As I said before, the plugin code inserts @page by design - this is the only way to insert top and bottom page margins to match Calibre's preferences - this is the only way you can use modify ePub to fix the corresponding check in quality check. Inserting @page in general is not a bug and it's not going to change.
Aside from offending your sensibilities, an empty @page declaration is going to behave exactly the same as not inserting @page, but I'm ok with calling this case an issue, albeit a low priority one since it won't affect how the book renders. Whenever I get a chance to dig back into the plugin to investigate Jackie's case I'll look into not inserting empty @page statements when all margins are zero. |
07-02-2012, 03:08 PM | #189 | |
Resident Curmudgeon
Posts: 73,970
Karma: 128903378
Join Date: Nov 2006
Location: Roslindale, Massachusetts
Device: Kobo Libra 2, Kobo Aura H2O, PRS-650, PRS-T1, nook STR, PW3
|
Quote:
|
|
07-02-2012, 08:06 PM | #190 | |
Wizard
Posts: 1,337
Karma: 123455
Join Date: Apr 2009
Location: Malaysia
Device: PRS-650, iPhone
|
Quote:
|
|
07-02-2012, 09:12 PM | #191 |
Resident Curmudgeon
Posts: 73,970
Karma: 128903378
Join Date: Nov 2006
Location: Roslindale, Massachusetts
Device: Kobo Libra 2, Kobo Aura H2O, PRS-650, PRS-T1, nook STR, PW3
|
Kiwidude, can we have an option to delete @page please?
|
07-03-2012, 07:16 AM | #192 | |
Connoisseur
Posts: 61
Karma: 1234
Join Date: Jun 2012
Device: none
|
Help please!
I've accidentally run "smarten punctuation" on all my files.
I'm at the box where it says "Modify ePub modified x file(s). Proceed with updating your library?' I'm really hoping that clicking No will leave my epubs unchanged. Is that the case? This leads me to be optimistic: Quote:
Thank you! |
|
07-03-2012, 07:39 AM | #193 | |
Grand Sorcerer
Posts: 6,212
Karma: 16534894
Join Date: Sep 2009
Location: UK
Device: Kobo: KA1, ClaraHD, Forma, Libra2, Clara2E. PocketBook: TouchHD3
|
Quote:
|
|
07-03-2012, 07:40 AM | #194 |
US Navy, Retired
Posts: 9,864
Karma: 13806776
Join Date: Feb 2009
Location: North Carolina
Device: Icarus Illumina XL HD, Nexus 7
|
If you don't want "smarten punctuation" run then, other than pulling the plug on your machine, click no. It will ether stop the process or not, but clicking yes most certainly will proceed to update your library.
|
07-03-2012, 08:05 AM | #195 | |
Connoisseur
Posts: 61
Karma: 1234
Join Date: Jun 2012
Device: none
|
Nice!
I haven't got many books so it wouldn't have killed me but that is a relief. I do wonder about the wording of the message though. "Modify ePub modified 123 files" sounds like it has already modified the files. I know Kiwidude will have good reason for wording it like this and I look foward to hearing that. Thank you Kiwidude very very much for all your great plugins. You really are da man, Dude. Thanks, jackie_w for the quick help. [And thanks, dwanthny, for the quick answer too - even though I did realize that... Quote:
|
|
Tags |
modify epub |
|
Similar Threads | ||||
Thread | Thread Starter | Forum | Replies | Last Post |
[GUI Plugin] Quality Check | kiwidude | Plugins | 1184 | 04-17-2024 06:17 PM |
[GUI Plugin] Open With | kiwidude | Plugins | 403 | 04-01-2024 08:39 AM |
[GUI Plugin] Manage Series | kiwidude | Plugins | 166 | 02-13-2024 11:31 AM |
Modify ePub plugin dev thread | kiwidude | Development | 346 | 09-02-2013 05:14 PM |
[GUI Plugin] Plugin Updater **Deprecated** | kiwidude | Plugins | 159 | 06-19-2011 12:27 PM |