Register Guidelines E-Books Search Today's Posts Mark Forums Read

Go Back   MobileRead Forums > E-Book Readers > Kobo Reader > Kobo Developer's Corner

Notices

Reply
 
Thread Tools Search this Thread
Old 12-09-2020, 07:44 AM   #16
blackwalrus
Member
blackwalrus began at the beginning.
 
Posts: 13
Karma: 10
Join Date: Jun 2020
Device: Aura One
Quote:
Originally Posted by JSWolf View Post
Thank you for the patch. I'll apply it later today.
Then post the screenshot after application. To make it clearer for beginners what this patch does and what it is for.
blackwalrus is offline   Reply With Quote
Old 12-09-2020, 08:31 AM   #17
JSWolf
Resident Curmudgeon
JSWolf ought to be getting tired of karma fortunes by now.JSWolf ought to be getting tired of karma fortunes by now.JSWolf ought to be getting tired of karma fortunes by now.JSWolf ought to be getting tired of karma fortunes by now.JSWolf ought to be getting tired of karma fortunes by now.JSWolf ought to be getting tired of karma fortunes by now.JSWolf ought to be getting tired of karma fortunes by now.JSWolf ought to be getting tired of karma fortunes by now.JSWolf ought to be getting tired of karma fortunes by now.JSWolf ought to be getting tired of karma fortunes by now.JSWolf ought to be getting tired of karma fortunes by now.
 
JSWolf's Avatar
 
Posts: 64,014
Karma: 103820051
Join Date: Nov 2006
Location: Roslindale, Massachusetts
Device: Kobo Aura H2O, PRS-650, PRS-T1, nook STR, iPad 4, iPhone SE 2020, PW3
Quote:
Originally Posted by blackwalrus View Post
Then post the screenshot after application. To make it clearer for beginners what this patch does and what it is for.
Will do. What the patch does is remove some of the L/R margins for the header/footer so you get a longer chapter title (header) and book title (footer) before you get cut off text with ...
JSWolf is offline   Reply With Quote
Advert
Old 12-15-2020, 08:00 AM   #18
JSWolf
Resident Curmudgeon
JSWolf ought to be getting tired of karma fortunes by now.JSWolf ought to be getting tired of karma fortunes by now.JSWolf ought to be getting tired of karma fortunes by now.JSWolf ought to be getting tired of karma fortunes by now.JSWolf ought to be getting tired of karma fortunes by now.JSWolf ought to be getting tired of karma fortunes by now.JSWolf ought to be getting tired of karma fortunes by now.JSWolf ought to be getting tired of karma fortunes by now.JSWolf ought to be getting tired of karma fortunes by now.JSWolf ought to be getting tired of karma fortunes by now.JSWolf ought to be getting tired of karma fortunes by now.
 
JSWolf's Avatar
 
Posts: 64,014
Karma: 103820051
Join Date: Nov 2006
Location: Roslindale, Massachusetts
Device: Kobo Aura H2O, PRS-650, PRS-T1, nook STR, iPad 4, iPhone SE 2020, PW3
Quote:
Originally Posted by Semwize View Post
try
Code:
Width allocated to the footer captions:
  - Enabled: yes
  - Description: |
  - FindZlib: "ReadingFooter"
  - ReplaceZlibGroup:
      Replacements:
        - Find:    "ReadingFooter[qApp_deviceIsDragon=true] {\n  qproperty-footerMargin: 170;\n}"
          Replace: "ReadingFooter[qApp_deviceIsDragon=true] {\n  qproperty-footerMargin: 70;\n}"
nickel.yaml
For anyone who wants to know what this patch does, it lessens the L/R margin for the footer so more text can be on the footer. See the screenshots to see that there can now be a lot of text on the footer. One is a before and the other is an after even though they are not the same screens.

Click image for larger version

Name:	screen_002.png
Views:	443
Size:	149.2 KB
ID:	184044 Click image for larger version

Name:	screen_003b.png
Views:	399
Size:	146.5 KB
ID:	184176

Last edited by JSWolf; 12-21-2020 at 05:43 PM.
JSWolf is offline   Reply With Quote
Old 12-15-2020, 09:14 AM   #19
icallaci
Guru
icallaci ought to be getting tired of karma fortunes by now.icallaci ought to be getting tired of karma fortunes by now.icallaci ought to be getting tired of karma fortunes by now.icallaci ought to be getting tired of karma fortunes by now.icallaci ought to be getting tired of karma fortunes by now.icallaci ought to be getting tired of karma fortunes by now.icallaci ought to be getting tired of karma fortunes by now.icallaci ought to be getting tired of karma fortunes by now.icallaci ought to be getting tired of karma fortunes by now.icallaci ought to be getting tired of karma fortunes by now.icallaci ought to be getting tired of karma fortunes by now.
 
Posts: 622
Karma: 6483398
Join Date: Sep 2012
Device: Kobo Forma, Samsung Galaxy Note 8 and Galaxy Tab S2 8.0
So if I wanted to apply this patch to a Forma, would I change "qApp_deviceIsDragon=true" to "qApp_deviceIsDaylight=true"? What about the qproperty-footerMargin properties?
icallaci is offline   Reply With Quote
Old 12-15-2020, 09:31 AM   #20
Semwize
Guru
Semwize ought to be getting tired of karma fortunes by now.Semwize ought to be getting tired of karma fortunes by now.Semwize ought to be getting tired of karma fortunes by now.Semwize ought to be getting tired of karma fortunes by now.Semwize ought to be getting tired of karma fortunes by now.Semwize ought to be getting tired of karma fortunes by now.Semwize ought to be getting tired of karma fortunes by now.Semwize ought to be getting tired of karma fortunes by now.Semwize ought to be getting tired of karma fortunes by now.Semwize ought to be getting tired of karma fortunes by now.Semwize ought to be getting tired of karma fortunes by now.
 
Posts: 726
Karma: 221218
Join Date: Jun 2016
Device: Kobo
Quote:
Originally Posted by icallaci View Post
So if I wanted to apply this patch to a Forma, would I change "qApp_deviceIsDragon=true" to "qApp_deviceIsDaylight=true"? What about the qproperty-footerMargin properties?
Code:
Width allocated to the footer captions:
  - Enabled: yes
  - Description: |
  - FindZlib: "ReadingFooter"
  - ReplaceZlibGroup:
      Replacements:
        - Find:    "ReadingFooter[qApp_deviceIsDragon=true] {\n  qproperty-footerMargin: 170;\n}"
          Replace: "ReadingFooter[qApp_deviceIsDragon=true] {\n  qproperty-footerMargin: 70;\n}"
        - Find:    "ReadingFooter[qApp_deviceIsDaylight=true] {\n  qproperty-footerMargin: 221;\n}"
          Replace: "ReadingFooter[qApp_deviceIsDaylight=true] {\n  qproperty-footerMargin: 121;\n}"

Last edited by Semwize; 12-15-2020 at 09:43 AM. Reason: aggregated
Semwize is offline   Reply With Quote
Advert
Old 12-15-2020, 09:37 AM   #21
JSWolf
Resident Curmudgeon
JSWolf ought to be getting tired of karma fortunes by now.JSWolf ought to be getting tired of karma fortunes by now.JSWolf ought to be getting tired of karma fortunes by now.JSWolf ought to be getting tired of karma fortunes by now.JSWolf ought to be getting tired of karma fortunes by now.JSWolf ought to be getting tired of karma fortunes by now.JSWolf ought to be getting tired of karma fortunes by now.JSWolf ought to be getting tired of karma fortunes by now.JSWolf ought to be getting tired of karma fortunes by now.JSWolf ought to be getting tired of karma fortunes by now.JSWolf ought to be getting tired of karma fortunes by now.
 
JSWolf's Avatar
 
Posts: 64,014
Karma: 103820051
Join Date: Nov 2006
Location: Roslindale, Massachusetts
Device: Kobo Aura H2O, PRS-650, PRS-T1, nook STR, iPad 4, iPhone SE 2020, PW3
Quote:
Originally Posted by Semwize View Post
Code:
Width allocated to the footer captions:
  - Enabled: yes
  - Description: |
  - FindZlib: "ReadingFooter"
  - ReplaceZlibGroup:
      Replacements:
        - Find:    "ReadingFooter[qApp_deviceIsDaylight=true] {\n  qproperty-footerMargin: 221;\n}"
          Replace: "ReadingFooter[qApp_deviceIsDaylight=true] {\n  qproperty-footerMargin: 121;\n}"
Would you mind making this patch work for all Kobo?
JSWolf is offline   Reply With Quote
Old 12-15-2020, 09:40 AM   #22
icallaci
Guru
icallaci ought to be getting tired of karma fortunes by now.icallaci ought to be getting tired of karma fortunes by now.icallaci ought to be getting tired of karma fortunes by now.icallaci ought to be getting tired of karma fortunes by now.icallaci ought to be getting tired of karma fortunes by now.icallaci ought to be getting tired of karma fortunes by now.icallaci ought to be getting tired of karma fortunes by now.icallaci ought to be getting tired of karma fortunes by now.icallaci ought to be getting tired of karma fortunes by now.icallaci ought to be getting tired of karma fortunes by now.icallaci ought to be getting tired of karma fortunes by now.
 
Posts: 622
Karma: 6483398
Join Date: Sep 2012
Device: Kobo Forma, Samsung Galaxy Note 8 and Galaxy Tab S2 8.0
Thank you!

ETA: It works perfectly on my Forma. Thank you so much.

Last edited by icallaci; 12-15-2020 at 09:45 AM.
icallaci is offline   Reply With Quote
Old 12-15-2020, 10:25 AM   #23
geek1011
Wizard
geek1011 ought to be getting tired of karma fortunes by now.geek1011 ought to be getting tired of karma fortunes by now.geek1011 ought to be getting tired of karma fortunes by now.geek1011 ought to be getting tired of karma fortunes by now.geek1011 ought to be getting tired of karma fortunes by now.geek1011 ought to be getting tired of karma fortunes by now.geek1011 ought to be getting tired of karma fortunes by now.geek1011 ought to be getting tired of karma fortunes by now.geek1011 ought to be getting tired of karma fortunes by now.geek1011 ought to be getting tired of karma fortunes by now.geek1011 ought to be getting tired of karma fortunes by now.
 
Posts: 2,460
Karma: 5070984
Join Date: May 2016
Location: Ontario, Canada
Device: Kobo Mini, Aura Edition 2 v1, Clara HD
If @Semwize wants, I can add it to the main set of patches too.
geek1011 is offline   Reply With Quote
Old 12-15-2020, 10:46 AM   #24
Semwize
Guru
Semwize ought to be getting tired of karma fortunes by now.Semwize ought to be getting tired of karma fortunes by now.Semwize ought to be getting tired of karma fortunes by now.Semwize ought to be getting tired of karma fortunes by now.Semwize ought to be getting tired of karma fortunes by now.Semwize ought to be getting tired of karma fortunes by now.Semwize ought to be getting tired of karma fortunes by now.Semwize ought to be getting tired of karma fortunes by now.Semwize ought to be getting tired of karma fortunes by now.Semwize ought to be getting tired of karma fortunes by now.Semwize ought to be getting tired of karma fortunes by now.
 
Posts: 726
Karma: 221218
Join Date: Jun 2016
Device: Kobo
@geek1011

Entities should not be multiplied unnecessarily.

IMHO, it's better to add lines to the "Custom new header / footer font" patch. And rename this patch, since there, besides the font, many things change
Semwize is offline   Reply With Quote
Old 12-15-2020, 11:05 AM   #25
JSWolf
Resident Curmudgeon
JSWolf ought to be getting tired of karma fortunes by now.JSWolf ought to be getting tired of karma fortunes by now.JSWolf ought to be getting tired of karma fortunes by now.JSWolf ought to be getting tired of karma fortunes by now.JSWolf ought to be getting tired of karma fortunes by now.JSWolf ought to be getting tired of karma fortunes by now.JSWolf ought to be getting tired of karma fortunes by now.JSWolf ought to be getting tired of karma fortunes by now.JSWolf ought to be getting tired of karma fortunes by now.JSWolf ought to be getting tired of karma fortunes by now.JSWolf ought to be getting tired of karma fortunes by now.
 
JSWolf's Avatar
 
Posts: 64,014
Karma: 103820051
Join Date: Nov 2006
Location: Roslindale, Massachusetts
Device: Kobo Aura H2O, PRS-650, PRS-T1, nook STR, iPad 4, iPhone SE 2020, PW3
Quote:
Originally Posted by geek1011 View Post
If @Semwize wants, I can add it to the main set of patches too.
I would appreciate it if this patch could be added to the main set of patches.
JSWolf is offline   Reply With Quote
Old 12-15-2020, 11:14 AM   #26
jackie_w
Grand Sorcerer
jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.
 
Posts: 5,771
Karma: 14391668
Join Date: Sep 2009
Location: UK
Device: Kobo: H2O, GloHD, KA1, ClaraHD, Forma
Quote:
Originally Posted by geek1011 View Post
If @Semwize wants, I can add it to the main set of patches too.
Quote:
Originally Posted by Semwize View Post
@geek1011

Entities should not be multiplied unnecessarily.

IMHO, it's better to add lines to the "Custom new header / footer font" patch. And rename this patch, since there, besides the font, many things change
I agree with @Semwize. In fact I'd go further and say that this is an opportunity to combine all options for ReadingFooter into a single patch. I really don't like having multiple patches for a single nickel CSS stream. This would mean combining these patches:
  1. Reduce new header/footer height
  2. Custom new header/footer font
  3. this new beta feature to expand the caption width by reducing L/R pageturn tap zone width
Obviously, this may make the new mega-patch appear more complex. I know people can be resistant to change.

Incidentally, if I add the beta item 3 to standard nickel.yaml I don't think I can use @Semwize's new values as the default Replace values. This is because they are too small in some circumstances. If a dogear bookmark is set at top right, then it's possible for the white background of the caption to partially overlay the left edge of the dogear icon - which is ugly. My defaults would be to make the Replace values exactly the same width as each model's dogear icon so that overlaying is not possible.

Of course, individual users will still be able to customise their own values as small as they like if they don't care about the aesthetics.

Thoughts???

Last edited by jackie_w; 12-15-2020 at 11:16 AM.
jackie_w is offline   Reply With Quote
Old 12-15-2020, 11:36 AM   #27
Semwize
Guru
Semwize ought to be getting tired of karma fortunes by now.Semwize ought to be getting tired of karma fortunes by now.Semwize ought to be getting tired of karma fortunes by now.Semwize ought to be getting tired of karma fortunes by now.Semwize ought to be getting tired of karma fortunes by now.Semwize ought to be getting tired of karma fortunes by now.Semwize ought to be getting tired of karma fortunes by now.Semwize ought to be getting tired of karma fortunes by now.Semwize ought to be getting tired of karma fortunes by now.Semwize ought to be getting tired of karma fortunes by now.Semwize ought to be getting tired of karma fortunes by now.
 
Posts: 726
Karma: 221218
Join Date: Jun 2016
Device: Kobo
@jackie

This will turn out to be very huge, confusing, and incomprehensible to many users.

Another option is to make a 3rd patch for the 'ReadingFooter'. And in it to combine
Spoiler:
Code:
        # 2b. All models (optional): Fine-tune footer position by adjusting margin-top value
        #     A negative margin-top (e.g -10px) moves the footer text slightly upwards
        #     further from the bottom bezel/progressbar, closer to the page content
        - Find:    "#caption[newFooter=true][qApp_deviceIsTrilogy=true] {\n  font-size: 14px;\n}"
          Replace: "#caption[newFooter=true] {\n  font-size: 14px; margin-top: 0px;}"
        
        # 2a. Touch/Mini users only: Adjust header font-size as required.
        # 2b. All models (optional): Fine-tune header position by adjusting margin-bottom value.
        #     A negative margin-bottom (e.g -10px) moves the header text slightly downwards
        #     further from the top bezel, closer to the page content
        - Find:    "#caption[newHeader=true][qApp_deviceIsTrilogy=true] {\n  font-size: 14px;\n}"
          Replace: "#caption[newHeader=true] {\n  font-size: 14px; margin-bottom: 0px;}"
and
Spoiler:
Code:
        - Find:    "ReadingFooter[qApp_deviceIsDragon=true] {\n  qproperty-footerMargin: 170;\n}"
          Replace: "ReadingFooter[qApp_deviceIsDragon=true] {\n  qproperty-footerMargin: 70;\n}"
        - Find:    "ReadingFooter[qApp_deviceIsDaylight=true] {\n  qproperty-footerMargin: 221;\n}"
          Replace: "ReadingFooter[qApp_deviceIsDaylight=true] {\n  qproperty-footerMargin: 121;\n}"
with a new name.

IMHO, so it will be clearer.
Semwize is offline   Reply With Quote
Old 12-15-2020, 12:05 PM   #28
jackie_w
Grand Sorcerer
jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.
 
Posts: 5,771
Karma: 14391668
Join Date: Sep 2009
Location: UK
Device: Kobo: H2O, GloHD, KA1, ClaraHD, Forma
Quote:
Originally Posted by Semwize View Post
@jackie

This will turn out to be very huge, confusing, and incomprehensible to many users.

Another option is to make a 3rd patch for the 'ReadingFooter'. And in it to combine <snip> and<snip> with a new name.

IMHO, so it will be clearer.
Adding a 3rd patch for ReadingFooter is not an option I'm prepared to entertain if I'm doing the ongoing maintenance.

If it can't be a single patch it will have to remain at 2 patches and the beta stuff will be added to either of the 2 existing patches.

There's logic for adding it to Custom new header/footer font because that's where all the other caption options are (font-family, font-size, margin-top/bottom).

However, there's also logic for adding it to Reduce new header/footer height because it's currently the least complex of the 2 patches.

The split you suggested is not practical as it would separate caption font-size into 2 different patches (Trilogy & all other models)
jackie_w is offline   Reply With Quote
Old 12-15-2020, 12:31 PM   #29
Semwize
Guru
Semwize ought to be getting tired of karma fortunes by now.Semwize ought to be getting tired of karma fortunes by now.Semwize ought to be getting tired of karma fortunes by now.Semwize ought to be getting tired of karma fortunes by now.Semwize ought to be getting tired of karma fortunes by now.Semwize ought to be getting tired of karma fortunes by now.Semwize ought to be getting tired of karma fortunes by now.Semwize ought to be getting tired of karma fortunes by now.Semwize ought to be getting tired of karma fortunes by now.Semwize ought to be getting tired of karma fortunes by now.Semwize ought to be getting tired of karma fortunes by now.
 
Posts: 726
Karma: 221218
Join Date: Jun 2016
Device: Kobo
@jackie

It doesn't matter where to add, just change the title to make it clearer for beginners, for example, 'Custom new header / footer font, position and caption'.
Semwize is offline   Reply With Quote
Old 12-15-2020, 01:38 PM   #30
jackie_w
Grand Sorcerer
jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.
 
Posts: 5,771
Karma: 14391668
Join Date: Sep 2009
Location: UK
Device: Kobo: H2O, GloHD, KA1, ClaraHD, Forma
Quote:
Originally Posted by JSWolf View Post
For anyone who wants to know what this patch does, it lessens the L/R margin for the footer so more text can be on the footer. See the screenshot to see that there can now be a lot of text on the footer.
Jon,

When I add this feature to standard nickel.yaml I'll be providing a link to your post, in the patch Description, to demo the Before/After effects so users can decide whether they're interested or not.

Your screenshot is only the 'After' so it would be helpful if you could also add a matching 'Before' screenshot for comparison.

Last edited by jackie_w; 12-15-2020 at 02:27 PM.
jackie_w is offline   Reply With Quote
Reply

Tags
kobopatch, patch, patch32lsb, patches, patching

Thread Tools Search this Thread
Search this Thread:

Advanced Search

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
Instructions for patching firmware 3.15.0 GeoffR Kobo Developer's Corner 146 05-24-2016 06:10 AM
Instructions for patching firmware 3.17.3 GeoffR Kobo Developer's Corner 60 09-17-2015 05:35 PM
Instructions for patching firmware 3.11.0 GeoffR Kobo Developer's Corner 226 06-01-2015 05:32 AM
Instructions for patching firmware 3.12.0 GeoffR Kobo Developer's Corner 165 02-07-2015 09:22 AM
Instructions for patching firmware 3.8.0 GeoffR Kobo Developer's Corner 92 10-22-2014 07:22 AM


All times are GMT -4. The time now is 02:11 AM.


MobileRead.com is a privately owned, operated and funded community.