Bug in renaming file in BookBrowser should show full paths mode.

The_book · 02-16-2020, 09:14 PM

There is a bug in renaming file in BookBrowser should show full paths mode.
It happens when your select single file and rename it, but your do not change it. Then it will show the short path, not the full path.

Turtle91 · 02-16-2020, 09:40 PM

I can replicate on Windows 64.

KevinH · 02-16-2020, 10:11 PM

Is it just cosmetic. What happens if you hide the BookBrowser and reopen it?

DNSB · 02-17-2020, 01:50 PM

Quote:

Originally Posted by KevinH

Is it just cosmetic. What happens if you hide the BookBrowser and reopen it?

I closed and reopened book browser and no path was still shown for that one file. Since the epub was not in Sigil's old layout, I did a restructure to Sigl norm and the path showed up in book browser. I did the cancelled rename and the file path disappeared again. I tried changing the file extension to xhtml and no change. I renamed the file and the path reappeared. For what it's worth, the issue seems to be cosmetic only.

Sigil 1.1.0, Windows 10 x64.

DiapDealer · 02-17-2020, 02:17 PM

I ran into this early on when getting ready for the version 1.0.0 release, but I was under the impression it had been fixed. Perhaps I just forgot about it is all.

DNSB · 02-17-2020, 02:29 PM

Quote:

Originally Posted by DiapDealer

I ran into this early on when getting ready for the version 1.0.0 release, but I was under the impression it had been fixed. Perhaps I just forgot about it is all.

Regressions'Я'Us.

DiapDealer · 02-17-2020, 02:38 PM

No. I'm betting I just forgot to mention it.

Hitting the escape key to cancel will preserve the full-path. It's only when bailing on the rename by clicking somewhere else with the mouse that initially makes the cosmetic-only problem show up.

DiapDealer · 02-20-2020, 09:32 AM

I honesty don't see a way around this that doesn't involve some rather drastic measures for such a cosmetic anomaly. We're currently relying on the built-in "edit" feature of QAbstractView (inherited by QTreeView) to do the renaming. Unless I'm missing something obvious, being able to handle the situation where a rename is canceled by clicking the mouse outside of the edit area would involve creating our own custom editor widget either through subclassing or by using a QStyledItemDelegate just to be able to install an event filter that captures the stray rename-"canceling" mouse-click.

My advice? Just train ourselves to hit ESC to cancel a rename instead.

DiapDealer · 03-25-2020, 02:20 PM

Just an FYI that I believe this issue will be fixed in the next release.

02-16-2020, 09:14 PM	#1
The_book Zealot Posts: 100 Karma: 10 Join Date: Aug 2019 Device: none	Bug in renaming file in BookBrowser should show full paths mode. There is a bug in renaming file in BookBrowser should show full paths mode. It happens when your select single file and rename it, but your do not change it. Then it will show the short path, not the full path. Last edited by The_book; 02-16-2020 at 09:50 PM.

02-20-2020, 09:32 AM	#8
DiapDealer Grand Sorcerer Posts: 27,546 Karma: 193191846 Join Date: Jan 2010 Device: Nexus 7, Kindle Fire HD	I honesty don't see a way around this that doesn't involve some rather drastic measures for such a cosmetic anomaly. We're currently relying on the built-in "edit" feature of QAbstractView (inherited by QTreeView) to do the renaming. Unless I'm missing something obvious, being able to handle the situation where a rename is canceled by clicking the mouse outside of the edit area would involve creating our own custom editor widget either through subclassing or by using a QStyledItemDelegate just to be able to install an event filter that captures the stray rename-"canceling" mouse-click. My advice? Just train ourselves to hit ESC to cancel a rename instead. Last edited by DiapDealer; 02-20-2020 at 09:35 AM.

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
Mini Full Screen Mode Not Working / Bug	Kiwisaurus	Kobo Reader	5	10-08-2018 03:13 PM
Renaming an epub file	Frenchguy	Library Management	4	10-20-2017 03:18 AM
Series renaming (bug?)	Athanor66	Library Management	4	08-18-2017 05:28 AM
Edit AZW file to show comics full-screen?	Aikistan	Amazon Kindle	5	10-20-2015 02:01 AM
Renaming File Problem...	Howard098	Sony Reader	3	02-01-2010 10:57 PM

02-16-2020, 09:40 PM	#2
Turtle91 A Hairy Wizard Posts: 3,093 Karma: 18727053 Join Date: Dec 2012 Location: Charleston, SC today Device: iPhone 11/X/6/iPad 1,2,Air & Air Pro/Surface Pro/Kindle PW & Fire	I can replicate on Windows 64.

02-16-2020, 10:11 PM	#3
KevinH Sigil Developer Posts: 7,630 Karma: 5433388 Join Date: Nov 2009 Device: many	Is it just cosmetic. What happens if you hide the BookBrowser and reopen it?

02-17-2020, 02:17 PM	#5
DiapDealer Grand Sorcerer Posts: 27,546 Karma: 193191846 Join Date: Jan 2010 Device: Nexus 7, Kindle Fire HD	I ran into this early on when getting ready for the version 1.0.0 release, but I was under the impression it had been fixed. Perhaps I just forgot about it is all.

02-17-2020, 02:38 PM	#7
DiapDealer Grand Sorcerer Posts: 27,546 Karma: 193191846 Join Date: Jan 2010 Device: Nexus 7, Kindle Fire HD	No. I'm betting I just forgot to mention it. Hitting the escape key to cancel will preserve the full-path. It's only when bailing on the rename by clicking somewhere else with the mouse that initially makes the cosmetic-only problem show up.

03-25-2020, 02:20 PM	#9
DiapDealer Grand Sorcerer Posts: 27,546 Karma: 193191846 Join Date: Jan 2010 Device: Nexus 7, Kindle Fire HD	Just an FYI that I believe this issue will be fixed in the next release.