Register Guidelines E-Books Search Today's Posts Mark Forums Read

Go Back   MobileRead Forums > E-Book Software > KOReader

Notices

Reply
 
Thread Tools Search this Thread
Old 12-10-2019, 06:44 AM   #16
Norbi24
Enthusiast
Norbi24 doesn't litterNorbi24 doesn't litter
 
Posts: 39
Karma: 144
Join Date: Aug 2019
Device: Tolino Vision HD4
@Pazos,

I have just tried with the latest nightly (12.9.) and there are good and bad news.

The first part (allow overrides on 3rd party dictionary list)https://github.com/koreader/koreader...94cb2d59ddbee9
works like a charm, but the 2nd (add support for generic intents) https://github.com/koreader/android-...ab3636b4461173 not:

I added following 3 lines into the dictonaries.lua in koreader folder:
1st the standard way of configuring particular dict app, 2nd and 3rd two ways as how to initiate the picker send intent:

{ "HandyLexEsSk", "Lingea Handylex Plus (ES-SK)", false, "com.lingea.handylex.spskh2", "send" },
{ "GenericSend", "Choose Dict App On Translate", false, "org.koreader.launcher", "picker-send" },
{ "GenericSendNew", "Choose Dict App On Translate New2", false, nil, "send" },

1st works fine, but neither of 2nd nd 3rd does - the 3rd line is even always deactivated in the dict selection menu. Then if I select the 2nd, and mark a word for translation, no picker list gets displayed.

This is related with your checking "add support for generic intents":
On Sunday I locally checked out the last previous checkin, compiled and the 2nd line in the dictionaries.lua was again working fine

I have already written a comment to the checking "add support for generic intents".
Should any logs be helpful, please let me know
Gracias, Norbert
Norbi24 is offline   Reply With Quote
Old 12-10-2019, 09:13 AM   #17
pazos
cosiñeiro
pazos knows what's going on.pazos knows what's going on.pazos knows what's going on.pazos knows what's going on.pazos knows what's going on.pazos knows what's going on.pazos knows what's going on.pazos knows what's going on.pazos knows what's going on.pazos knows what's going on.pazos knows what's going on.
 
Posts: 258
Karma: 25889
Join Date: Apr 2014
Device: BQ Cervantes 4
Quote:
Originally Posted by Norbi24 View Post
@Pazos,

I have just tried with the latest nightly (12.9.) and there are good and bad news.

The first part (allow overrides on 3rd party dictionary list)https://github.com/koreader/koreader...94cb2d59ddbee9
works like a charm, but the 2nd (add support for generic intents) https://github.com/koreader/android-...ab3636b4461173 not:

I added following 3 lines into the dictonaries.lua in koreader folder:
1st the standard way of configuring particular dict app, 2nd and 3rd two ways as how to initiate the picker send intent:

{ "HandyLexEsSk", "Lingea Handylex Plus (ES-SK)", false, "com.lingea.handylex.spskh2", "send" },
{ "GenericSend", "Choose Dict App On Translate", false, "org.koreader.launcher", "picker-send" },
{ "GenericSendNew", "Choose Dict App On Translate New2", false, nil, "send" },

1st works fine, but neither of 2nd nd 3rd does - the 3rd line is even always deactivated in the dict selection menu. Then if I select the 2nd, and mark a word for translation, no picker list gets displayed.

This is related with your checking "add support for generic intents":
On Sunday I locally checked out the last previous checkin, compiled and the 2nd line in the dictionaries.lua was again working fine

I have already written a comment to the checking "add support for generic intents".
Should any logs be helpful, please let me know
Gracias, Norbert
It works as intended.

Your second example is obsolete and your 3rd example - which will do the same thing - needs to be true, to actually being enabled on your menu. Exactly like described in https://github.com/koreader/koreader...ssue-348399680.

So in short: true and nil for an action to show the app picker. false and package name for an action to - after being checked at runtime - open the text directly in that app.

You can also set your local packages to "true", this will avoid runtime checks and save a whooping 0.5ms per each dict on your list.
pazos is offline   Reply With Quote
Old 12-10-2019, 10:00 AM   #18
Norbi24
Enthusiast
Norbi24 doesn't litterNorbi24 doesn't litter
 
Posts: 39
Karma: 144
Join Date: Aug 2019
Device: Tolino Vision HD4
@Pazos, Yes, you are right, sorrrry (:-) I have overlooked that false/true param, although documented by yourself, and was taking the lines from what you previously wrote above in this thread, my fault
Thanks, Norbert
Norbi24 is offline   Reply With Quote
Reply

Thread Tools Search this Thread
Search this Thread:

Advanced Search

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
KOreader on Android Ken Maltby KOReader 251 11-26-2019 06:45 PM
DX(G) Primitive fpt server android and Koreader HoanPiTa Kindle Developer's Corner 2 07-21-2019 12:54 PM
KoReader on android background image mystika1 KOReader 1 02-09-2019 06:30 AM
Folder navigation and/or customisable sleep screen and/or reading stats chlorine Which one should I buy? 10 10-16-2017 02:50 PM
Koreader zoom and navigation DanCa KOReader 2 06-25-2014 10:51 PM


All times are GMT -4. The time now is 04:21 AM.


MobileRead.com is a privately owned, operated and funded community.