Attn plugin developers: new Qt bug regarding dates

chaley · 11-07-2023, 03:03 PM

Kovid found a new bug in how Qt handles dates. Formerly

Code:

QDateTime(some_python_date)

preserved the timezone, where now it doesn't. This can cause problems where the date moves a day.

See https://github.com/kovidgoyal/calibr...b4d3ec86b2a711 for how examples of how he fixed it.

Examples:

Code:

        self.setDateTime(now())
is changed to:
        self.setDateTime(qt_from_dt(now()))

Code:

        return None if is_date_undefined(val) else QDateTime(as_local_time(val))
is changed to
        return None if is_date_undefined(val) else qt_from_dt(val)

ownedbycats · 11-07-2023, 03:25 PM

Is this also present in the Calibre 7 beta?

chaley · 11-07-2023, 03:37 PM

Quote:

Originally Posted by ownedbycats

Is this also present in the Calibre 7 beta?

Yes.

The fix is in both beta (notes) and master source but not yet released in either.

capink · 11-08-2023, 01:09 AM

Thanks for the heads-up. I've put a test version for my plugin.

11-07-2023, 03:03 PM	#1
chaley Grand Sorcerer Posts: 11,741 Karma: 6997045 Join Date: Jan 2010 Location: Notts, England Device: Kobo Libra 2	Attn plugin developers: new Qt bug regarding dates Kovid found a new bug in how Qt handles dates. Formerly Code: QDateTime(some_python_date) preserved the timezone, where now it doesn't. This can cause problems where the date moves a day. See https://github.com/kovidgoyal/calibr...b4d3ec86b2a711 for how examples of how he fixed it. Examples: Code: self.setDateTime(now()) is changed to: self.setDateTime(qt_from_dt(now())) Code: return None if is_date_undefined(val) else QDateTime(as_local_time(val)) is changed to return None if is_date_undefined(val) else qt_from_dt(val)

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
Attn plugin devs: porting to python 3	kovidgoyal	Plugins	129	06-16-2020 01:31 AM
Plugin Developers, a request	Rellwood	Plugins	6	03-31-2020 05:28 PM
Attn plugin developers: calibre moving to Qt 5	kovidgoyal	Plugins	157	01-01-2015 11:22 PM
calibre-plugins.com: A resource for plugin developers	GRiker	Development	2	11-19-2014 03:52 PM
Attn vvv - Minor bug in BD	HarryT	Sony Reader	33	07-11-2007 01:37 AM

11-07-2023, 03:25 PM	#2
ownedbycats Custom User Title Posts: 8,618 Karma: 61176603 Join Date: Oct 2018 Location: Canada Device: Kobo Libra H2O, formerly Aura HD	Is this also present in the Calibre 7 beta?

11-08-2023, 01:09 AM	#4
capink Wizard Posts: 1,090 Karma: 1948136 Join Date: Aug 2015 Device: Kindle	Thanks for the heads-up. I've put a test version for my plugin.

Advert