Instructions for patching firmware 4.25.15875

[blackwalrus]

Originally Posted by JSWolf

Thank you for the patch. I'll apply it later today.

Then post the screenshot after application. To make it clearer for beginners what this patch does and what it is for.

[JSWolf]

Originally Posted by blackwalrus

Then post the screenshot after application. To make it clearer for beginners what this patch does and what it is for.

Will do. What the patch does is remove some of the L/R margins for the header/footer so you get a longer chapter title (header) and book title (footer) before you get cut off text with ...

[JSWolf]

Originally Posted by Semwize

try

Width allocated to the footer captions:
  - Enabled: yes
  - Description: |
  - FindZlib: "ReadingFooter"
  - ReplaceZlibGroup:
      Replacements:
        - Find:    "ReadingFooter[qApp_deviceIsDragon=true] {\n  qproperty-footerMargin: 170;\n}"
          Replace: "ReadingFooter[qApp_deviceIsDragon=true] {\n  qproperty-footerMargin: 70;\n}"

nickel.yaml

For anyone who wants to know what this patch does, it lessens the L/R margin for the footer so more text can be on the footer. See the screenshots to see that there can now be a lot of text on the footer. One is a before and the other is an after even though they are not the same screens.

[icallaci]

So if I wanted to apply this patch to a Forma, would I change "qApp_deviceIsDragon=true" to "qApp_deviceIsDaylight=true"? What about the qproperty-footerMargin properties?

[Semwize]

Originally Posted by icallaci

So if I wanted to apply this patch to a Forma, would I change "qApp_deviceIsDragon=true" to "qApp_deviceIsDaylight=true"? What about the qproperty-footerMargin properties?

Width allocated to the footer captions:
  - Enabled: yes
  - Description: |
  - FindZlib: "ReadingFooter"
  - ReplaceZlibGroup:
      Replacements:
        - Find:    "ReadingFooter[qApp_deviceIsDragon=true] {\n  qproperty-footerMargin: 170;\n}"
          Replace: "ReadingFooter[qApp_deviceIsDragon=true] {\n  qproperty-footerMargin: 70;\n}"
        - Find:    "ReadingFooter[qApp_deviceIsDaylight=true] {\n  qproperty-footerMargin: 221;\n}"
          Replace: "ReadingFooter[qApp_deviceIsDaylight=true] {\n  qproperty-footerMargin: 121;\n}"

[JSWolf]

Originally Posted by Semwize

Width allocated to the footer captions:
  - Enabled: yes
  - Description: |
  - FindZlib: "ReadingFooter"
  - ReplaceZlibGroup:
      Replacements:
        - Find:    "ReadingFooter[qApp_deviceIsDaylight=true] {\n  qproperty-footerMargin: 221;\n}"
          Replace: "ReadingFooter[qApp_deviceIsDaylight=true] {\n  qproperty-footerMargin: 121;\n}"

Would you mind making this patch work for all Kobo?

[icallaci]

Thank you!

ETA: It works perfectly on my Forma. Thank you so much.

[geek1011]

If @Semwize wants, I can add it to the main set of patches too.

[Semwize]

@geek1011

Entities should not be multiplied unnecessarily.

IMHO, it's better to add lines to the "Custom new header / footer font" patch. And rename this patch, since there, besides the font, many things change

[JSWolf]

Originally Posted by geek1011

If @Semwize wants, I can add it to the main set of patches too.

I would appreciate it if this patch could be added to the main set of patches.

[jackie_w]

Originally Posted by geek1011

If @Semwize wants, I can add it to the main set of patches too.

Originally Posted by Semwize

@geek1011

Entities should not be multiplied unnecessarily.

IMHO, it's better to add lines to the "Custom new header / footer font" patch. And rename this patch, since there, besides the font, many things change

I agree with @Semwize. In fact I'd go further and say that this is an opportunity to combine all options for ReadingFooter into a single patch. I really don't like having multiple patches for a single nickel CSS stream. This would mean combining these patches:

1. Reduce new header/footer height
2. Custom new header/footer font
3. this new beta feature to expand the caption width by reducing L/R pageturn tap zone width

Obviously, this may make the new mega-patch appear more complex. I know people can be resistant to change.

Incidentally, if I add the beta item 3 to standard nickel.yaml I don't think I can use @Semwize's new values as the default Replace values. This is because they are too small in some circumstances. If a dogear bookmark is set at top right, then it's possible for the white background of the caption to partially overlay the left edge of the dogear icon - which is ugly. My defaults would be to make the Replace values exactly the same width as each model's dogear icon so that overlaying is not possible.

Of course, individual users will still be able to customise their own values as small as they like if they don't care about the aesthetics.

Thoughts???

[Semwize]

@jackie

This will turn out to be very huge, confusing, and incomprehensible to many users.

Another option is to make a 3rd patch for the 'ReadingFooter'. And in it to combine

Spoiler:

        # 2b. All models (optional): Fine-tune footer position by adjusting margin-top value
        #     A negative margin-top (e.g -10px) moves the footer text slightly upwards
        #     further from the bottom bezel/progressbar, closer to the page content
        - Find:    "#caption[newFooter=true][qApp_deviceIsTrilogy=true] {\n  font-size: 14px;\n}"
          Replace: "#caption[newFooter=true] {\n  font-size: 14px; margin-top: 0px;}"
        
        # 2a. Touch/Mini users only: Adjust header font-size as required.
        # 2b. All models (optional): Fine-tune header position by adjusting margin-bottom value.
        #     A negative margin-bottom (e.g -10px) moves the header text slightly downwards
        #     further from the top bezel, closer to the page content
        - Find:    "#caption[newHeader=true][qApp_deviceIsTrilogy=true] {\n  font-size: 14px;\n}"
          Replace: "#caption[newHeader=true] {\n  font-size: 14px; margin-bottom: 0px;}"

and

Spoiler:

        - Find:    "ReadingFooter[qApp_deviceIsDragon=true] {\n  qproperty-footerMargin: 170;\n}"
          Replace: "ReadingFooter[qApp_deviceIsDragon=true] {\n  qproperty-footerMargin: 70;\n}"
        - Find:    "ReadingFooter[qApp_deviceIsDaylight=true] {\n  qproperty-footerMargin: 221;\n}"
          Replace: "ReadingFooter[qApp_deviceIsDaylight=true] {\n  qproperty-footerMargin: 121;\n}"

with a new name.

IMHO, so it will be clearer.

[jackie_w]

Originally Posted by Semwize

@jackie

This will turn out to be very huge, confusing, and incomprehensible to many users.

Another option is to make a 3rd patch for the 'ReadingFooter'. And in it to combine <snip> and<snip> with a new name.

IMHO, so it will be clearer.

Adding a 3rd patch for ReadingFooter is not an option I'm prepared to entertain if I'm doing the ongoing maintenance.

If it can't be a single patch it will have to remain at 2 patches and the beta stuff will be added to either of the 2 existing patches.

There's logic for adding it to Custom new header/footer font because that's where all the other caption options are (font-family, font-size, margin-top/bottom).

However, there's also logic for adding it to Reduce new header/footer height because it's currently the least complex of the 2 patches.

The split you suggested is not practical as it would separate caption font-size into 2 different patches (Trilogy & all other models)

[Semwize]

@jackie

It doesn't matter where to add, just change the title to make it clearer for beginners, for example, 'Custom new header / footer font, position and caption'.

[jackie_w]

Originally Posted by JSWolf

For anyone who wants to know what this patch does, it lessens the L/R margin for the footer so more text can be on the footer. See the screenshot to see that there can now be a lot of text on the footer.

Jon,

When I add this feature to standard nickel.yaml I'll be providing a link to your post, in the patch Description, to demo the Before/After effects so users can decide whether they're interested or not.

Your screenshot is only the 'After' so it would be helpful if you could also add a matching 'Before' screenshot for comparison.