Suggestions before releasing version 1.0 - Page 5

DiapDealer · 12-12-2019, 11:19 AM

Gotcha, Thanks. I just saw "plugin related Mac bugs" and remembered that there was something Mac plugin-specific in those changes I made.

The m_pluginMapper delete is already removed from the destructor's Mac-specific code. It's just orphaned in MainWindow.h, is all. I'll remove it.

KevinH · 12-12-2019, 01:12 PM

FWIW, I now have two different patches that seem to prevent the segfault Odamizu reported on macOS.

One is extending the workaround, and the other is the patch that was abandoned but that actually works.

I will include one of the two patches in my next Qt build so a fix makes it into the next release after more testing.

It really only matters on Sigil for macOS so no changes to Qt on Windows should be needed.

KevinH

odamizu · 12-12-2019, 03:11 PM

@KevinH — your perseverance in squashing bugs, no matter how obscure, is impressive

The steps to reproduce the crash are not part of my normal workflow, so avoiding it is no effort. I only stumbled on the crash by accident. (I emailed you the crash reports only because you've expressed a desire to see these crash reports.)

Thanks as always to you and also DiapDealer for all your time and effort making Sigil the excellent program that it is.

KevinH · 12-12-2019, 03:49 PM

I just hate crashing bugs, and especially those on my platform of choice!

democrite · 12-14-2019, 12:47 AM

Quote:

Originally Posted by KevinH

That is good to know. We will have to somehow detect when the system changes its mode and completely repaint everything.
…

I also noticed the hard to read text when using dark mode on macOS. Has any consideration been given to color theme presets? I'm not sure how new is dark mode, though now that it's here, schemes for light and dark as well as autoswitching would be great. I don't have any preference for what themes to use though maybe one could pick some from popular themes and perhaps later have some preset file type where one could import, export, and share themes.

KevinH · 12-14-2019, 08:16 AM

There are ways to use qss style sheets and judicial setting of icons and fonts that will provide Sigil with a viable dark theme now, but switching is problematic,

So any integrated support for DarkMode will not be part of Digil 2.9 but it is high on our to-do list for follow-on releases.

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
Feature Suggestions for Future Version	Authorspeak	Sigil	12	03-13-2014 12:21 PM
Releasing a chapter at a time?	jhempel24	Writers' Corner	24	03-15-2013 08:11 AM
Releasing updated eBooks	jhempel24	General Discussions	26	02-20-2013 07:26 AM
PRS 650 releasing on 09/16	sachinwalia	Sony Reader	6	09-09-2010 10:45 AM
Releasing Out of Print Books?	KindleKid	Reading Recommendations	6	12-05-2008 03:24 PM

12-12-2019, 11:19 AM	#61
DiapDealer Grand Sorcerer Posts: 27,549 Karma: 193191846 Join Date: Jan 2010 Device: Nexus 7, Kindle Fire HD	Gotcha, Thanks. I just saw "plugin related Mac bugs" and remembered that there was something Mac plugin-specific in those changes I made. The m_pluginMapper delete is already removed from the destructor's Mac-specific code. It's just orphaned in MainWindow.h, is all. I'll remove it.

12-12-2019, 01:12 PM	#62
KevinH Sigil Developer Posts: 7,644 Karma: 5433388 Join Date: Nov 2009 Device: many	FWIW, I now have two different patches that seem to prevent the segfault Odamizu reported on macOS. One is extending the workaround, and the other is the patch that was abandoned but that actually works. I will include one of the two patches in my next Qt build so a fix makes it into the next release after more testing. It really only matters on Sigil for macOS so no changes to Qt on Windows should be needed. KevinH

12-12-2019, 03:11 PM	#63
odamizu just an egg Posts: 1,586 Karma: 4300000 Join Date: Mar 2015 Device: Kindle, iOS	@KevinH — your perseverance in squashing bugs, no matter how obscure, is impressive The steps to reproduce the crash are not part of my normal workflow, so avoiding it is no effort. I only stumbled on the crash by accident. (I emailed you the crash reports only because you've expressed a desire to see these crash reports.) Thanks as always to you and also DiapDealer for all your time and effort making Sigil the excellent program that it is.

12-12-2019, 03:49 PM	#64
KevinH Sigil Developer Posts: 7,644 Karma: 5433388 Join Date: Nov 2009 Device: many	I just hate crashing bugs, and especially those on my platform of choice!

12-14-2019, 08:16 AM	#66
KevinH Sigil Developer Posts: 7,644 Karma: 5433388 Join Date: Nov 2009 Device: many	There are ways to use qss style sheets and judicial setting of icons and fonts that will provide Sigil with a viable dark theme now, but switching is problematic, So any integrated support for DarkMode will not be part of Digil 2.9 but it is high on our to-do list for follow-on releases.