[GUI Plugin] Embed Comic Metadata

[dickloraine]

If I find time, I may look at this. Shouldn't be that difficult, I hope. I have to look a little deeper into qt to make the option gui and look at the api functions for customn columns. I hope it is as easy as just expanding my mapping functions.

[DreamStatic]

Sounds good. This is really working awesomely so far, thank you again.

I did run into one issue that you might want to check - when the issue number is 1/2 it errors with "could not convert to string". I would prefer that if it encounters a "1/2" it converts it to .5 on import so the series number would work well with Calibre. I try to catch these during tagging but I missed a couple and then ran into this error.

Nice, nice work. Do you have any donation avenues set up as I know time is VERY valuable?

[dickloraine]

When do you get the error? When you import to calibre? How is the 1/2 written? As "1/2" or with a special character? And I would have thought the error would be more like "couldn't convert string to float". Curious. Can you maybe send me a comic.xml file with this type of metadata, so that I could test it?

Never thought about donations. I have a paypal account, maybe I look into it, if it is easy.

[DreamStatic]

Yes you are correct it was error that could not convert string to float. I have attached the relative documents. Let me know if you need anything further.

I get the error after the file is imported into Calibre and I choose your option to Import from the comic archive into Calibre.

[dickloraine]

Fixed

[DreamStatic]

Thank you, but now I am getting another error on regular issue numbers. "TypeError:must be unicode, not str"

Sorry.

[dickloraine]

Should work now. I just forgot to check for the type.

[dickloraine]

I experimented a little with custom columns and it looks like it wouldn't be hard to implement that feature. In fact, my test column did work, so now I need to generalize the functions and implement the different fields. Should be ready in a few days

[DreamStatic]

OH MY GOODNESS!! That is pretty awesome news!!!

[DreamStatic]

Looking good so far!! I did find one item that could be confusing for future users. You may plan on updating this already, just thought I would mention in case you hadn't noticed it yet. When you are showing the extended menu all three import options read the same (see screenshot). I went and reviewed the code to see what each did, but I assume the text should explain what each does.

Also, I ran your current Custom Column branch through 200 comics and only ran into one error. One comic has a ComicInfo.xml file in the cbz file, but it states no metadata found. I have attached the ComicInfo.xml in case it helps. Additionally, it also gave this error: 'NoneType' object has no attribute 'strip'

Traceback (most recent call last):
File "calibre_plugins.EmbedComicMetadata.ui", line 96, in sub_menu_triggered
File "calibre_plugins.EmbedComicMetadata.main", line 66, in update_metadata
File "calibre_plugins.EmbedComicMetadata.main", line 190, in write_calibre_metadata
File "calibre_plugins.EmbedComicMetadata.main", line 239, in update_calibre_metadata
AttributeError: 'NoneType' object has no attribute 'strip'

Thanks again.

[dickloraine]

The same text was a typical copy&paste error, I just forgot to change that.
The error was because the comicinfo.xml had no comment field. In the latest build checks for cases like that are implemented, so it should now not throw an error.

The current build is hopefully very near to the final build. It now needs some more testing and maybe some final tweaks.

[DreamStatic]

Option choices make more sense now.

I no longer get an error when trying to import that comic without a comment node; however, it is like it just stops importing or something as none of the artist nodes, etc are imported.

[dickloraine]

That is strange, I can import them just fine. Maybe you have not the last version? Depending on when you downloaded it, you may have not got the last commit, which fixed exactly that problem (or so I thought). I have attached the last version on this post. Hopefully this one works

[DreamStatic]

Yes, that seemed to have fixed the issue. Nice work!! Thank you.

[DreamStatic]

Plugin coming along VERY nicely! I am following along with your updates and so far you are knocking it out of the park! Thanks again. I will keep you updated if I spot any issues.