Add an option to not convert filename to ASCII while uploading to device

[bebugz]

Hi,

I had raised the following issue on launchpad

https://bugs.launchpad.net/bugs/1035886

The filename is explicitly set to ASCII while uploading to device.
Please, add a capability to turn off this conversion as all devices can
be UTF-8 complaint and this can be much more convinient to have file
structure defined in UTF-8 (national characters).

The functionality I am asking for is already implemented for `Save to
disk` function by turning off:

Preferences->Saving Books To Disk->Convert non-English characters to
English equivalents.

Please, do the same option for `Sending books to devices`

Kovid Goyal replied that that won't be fixed (no reason had been provided), but I still would like to make a patch locally.

Here I'm asking the community - can you see any hidden caveats of this solution?

[bebugz]

I have found that there are already two topics (2010, 2012) raised on the forum requesting the same


Is it possible to sent books to device with filename in non-ascii characters?
https://www.mobileread.com/forums/sho...d.php?t=102686

add option to non-english filename...
https://www.mobileread.com/forums/sho...d.php?t=179579


Also I found that the main reason to not implement this feature is that some devices are FAT32 and this will be error-prone to use non ASCII. I think that better option is to warn and let power users to decide either to take risk and enable such option or not.