Beta testing calibre 4

[Sirtel]

Originally Posted by kovidgoyal

@sirtel: How are you inserting paragraph margins? As in what code are you using and what procedure to insert it?

Both by hand in the individual book comments (metadata editor, comments field, the html view) and S&R in the bulk metadata editor (tried both character match and regex). As there already were <p> tags with a style attached in the comments (font family and font size), I just added margin: 0 0 0 0 to the paragraph style, to remove excessive spacing. Like <p style="font-family: 'Verdana'; font-size: 12px; margin: 0 0 0 0">

Worked in the current release, didn't work in the beta (inserted code for margins just vanished every time).

[kovidgoyal]

Works for me with:

<p style="margin: 0">xxx</p>
<p style="margin: 0">yyy</p>

[kovidgoyal]

Note that the book details panel/comments editor has support for mch more limited set of html and css because it is no longer based ona ful browser. https://doc.qt.io/qt-5/richtext-html-subset.html

[kovidgoyal]

Actually scratch that while setting the margin in the html view and switch back to normal view works it gets stripped during actual setting, I will look into it.

[Hopkins]

Originally Posted by jhack-jos

Dear Kovid,

excellent bug fixes!
All the problems previously mentioned are now solved.

Thanks to that, I was able to find another important breaking bug for the Japanese users. It seems that it is still not possible to properly turn page, both with the arrow keys or the page up / page down keys.
When trying to turn page, the viewer instead skips huge blocks of texts and goes to the "next section" of the book. I found no way to view the missing blocks of text.

FWIW, I can also confirm this on Chinese books. The paging of vertical text books (specifically writing-mode: vertical-rl) jumps more than 1 page. The same book laid out horizontally pages correctly. I suppose this could be a Qt problem.

[Sirtel]

Originally Posted by kovidgoyal

Actually scratch that while setting the margin in the html view and switch back to normal view works it gets stripped during actual setting, I will look into it.

Thank you.

[kovidgoyal]

@Sirtel: The margins are explicitly removed, because Qt tends to set margins on every paragraph automatically, leading to very messy markup. To address your use case, however, I have made it easy to configure the CSS used inthe book details panel via Preferences->Look & feel_>Book details just add the following rule there:

p { margin: 0}

and you should be fine.

[Sirtel]

Originally Posted by kovidgoyal

@Sirtel: The margins are explicitly removed, because Qt tends to set margins on every paragraph automatically, leading to very messy markup. To address your use case, however, I have made it easy to configure the CSS used inthe book details panel via Preferences->Look & feel_>Book details just add the following rule there:

p { margin: 0}

and you should be fine.

Many, many thanks! I'll try it when I get to my computer later.

[Sirtel]

Works perfectly. Thank you, Kovid. Calibre rocks!

[Aeroblast]

Would you like to add support for a rtl page-progression-direction to the viewer? For japanese and traditional Chinese books.

[kovidgoyal]

Originally Posted by Aeroblast

Would you like to add support for a rtl page-progression-direction to the viewer? For japanese and traditional Chinese books.

Patches are welcome.

[kovidgoyal]

I looked at the scrolling issue with vertical text and basically I dont see a good way to implement it in a general fashion. One would need to detect that the file is using vertical text (I suppose one could use EPUB properties for that) and then implement specialised scrolling routines for it. Since I cant read the text and I dont have a good sense for how it should work, I am not the right person to do that. But as I said patches are welcome. The relevant code is in two places:

Initial preparation of the book happens in srv/render_book.py that would need to be changed to pass along the metadata about vertical text/page progression etc. Then in view.pyj look at show_spine_item_stage2() where data about the HTML file is sent to the iframe where it is rendered. Add the necessary metadata there about display properties.

Then look in iframe.pyj where that data is actually used and finally look in flow_mode.pyj and paged_mode.pyj for actual scrolling implementations.

Set up a calibre development environment following: https://manual.calibre-ebook.com/develop.html

If you run the viewer as

calibre-debug -w file.epub

changes to the pyj files should be auto-compiled and any console.log() or print() calls in the pyj files shouldbe printed out to the terminal for debugging.

[Aeroblast]

Originally Posted by kovidgoyal

I looked at the scrolling issue with vertical text and basically I dont see a good way to implement it in a general fashion. One would need to detect that the file is using vertical text (I suppose one could use EPUB properties for that) and then implement specialised scrolling routines for it. Since I cant read the text and I dont have a good sense for how it should work, I am not the right person to do that. But as I said patches are welcome. The relevant code is in two places:

Initial preparation of the book happens in srv/render_book.py that would need to be changed to pass along the metadata about vertical text/page progression etc. Then in view.pyj look at show_spine_item_stage2() where data about the HTML file is sent to the iframe where it is rendered. Add the necessary metadata there about display properties.

Then look in iframe.pyj where that data is actually used and finally look in flow_mode.pyj and paged_mode.pyj for actual scrolling implementations.

Set up a calibre development environment following: https://manual.calibre-ebook.com/develop.html

If you run the viewer as

calibre-debug -w file.epub

changes to the pyj files should be auto-compiled and any console.log() or print() calls in the pyj files shouldbe printed out to the terminal for debugging.

Thanks for your reply!
I'll find out what can I do for it.

[rashkae]

Comments on 3.99.4

I don't know if it can be fixed, but I observe that height in proportion to the screen no longer work, (ex: height: 100% or max-height: 100%)

Also, the inspector in the Book viewer doesn't seem to work. Data doesn't populate into the bottom half of the inspector pane.. but it works perfectly in the Editor.

[gbm]

Originally Posted by rashkae

Comments on 3.99.4

I don't know if it can be fixed, but I observe that height in proportion to the screen no longer work, (ex: height: 100% or max-height: 100%)

Also, the inspector in the Book viewer doesn't seem to work. Data doesn't populate into the bottom half of the inspector pane.. but it works perfectly in the Editor.

Edit:

Change the maximum screen area (in pixels) used to display text. A value of zero means that all available screen area is used.

Use full screen inspector will be on the right, if you are not using full screen then undock inspector and move it.

bernie