[GUI Plugin] Goodreads Sync

[davidfor]

Originally Posted by dunhill

If you could bring any goodreads import information through a configuration, that would be great. To think.

Sorry, I don't know what you mean. The "Sync from shelf" and "Download tags from shelves" already pull information from GR. Is there something else you want?

[Rellwood]

Hey, could you pretty please check out this bug report and see if you can identify why it takes so long to sync.


DEBUG: 15.4 sync_shelves - start
DEBUG: 18.4 HttpHelper::get_goodreads_books_on_shelves: user_name=Scarlett Rue
DEBUG: 18.4 HttpHelper::get_goodreads_books_on_shelves: shelf='currently-reading', page=1
DEBUG: 18.4 _oauth_request_get: url=https://www.goodreads.com/review/list.xml?v=2&shelf=currently-reading&page=1&per_page=200
DEBUG: 20.7 sync_shelves - returned from ChooseShelvesToSyncDialog
DEBUG: 20.7 sync_shelves - About to open DoShelfSyncDialog
DEBUG: 27.7 CalibreDbHelper::apply_actions_to_calibre - actions: [{u'action': u'ADD', u'value': u'Currently Reading', u'column': u'#exclusiveshelf'}, {u'action': u'ADD', u'value': u'date_added', u'column': u'#grdateadded'}, {u'action': u'ADD', u'value': u'Currently Reading', u'column': u'#readstatus'}, {u'action': u'ADD', u'value': u'date_updated', u'column': u'#gr_updateded'}, {u'action': u'ADD', u'value': u'1.Current', u'column': u'#calibrelibrary'}, {u'action': u'ADD', u'value': u'Y', u'column': u'#ingr'}, {u'action': u'REMOVE', u'value': u'Placeholder.Maybe', u'column': u'#book_style'}, {u'action': u'REMOVE', u'value': u'Placeholder.Pre-Ordered', u'column': u'#book_style'}, {u'action': u'REMOVE', u'value': u'Placeholder.Waiting for it', u'column': u'#book_style'}, {u'action': u'REMOVE', u'value': u'Placeholder.Want to Read', u'column': u'#book_style'}]
DEBUG: 28.0 sync_shelves - returned from DoShelfSyncDialog
DEBUG: 28.0 sync_shelves - About to _update_goodreads_ids
DEBUG: 41.3 sync_shelves - finished _update_goodreads_ids
DEBUG: 47.6 sync_shelves - start
DEBUG: 50.7 HttpHelper::get_goodreads_books_on_shelves: user_name=Scarlett Rue
DEBUG: 50.7 HttpHelper::get_goodreads_books_on_shelves: shelf='dnf', page=1
DEBUG: 50.7 _oauth_request_get: url=https://www.goodreads.com/review/list.xml?v=2&shelf=dnf&page=1&per_page=200
DEBUG: 61.9 _convert_review_xml_node_to_book: length of review_text= 181
DEBUG: 61.9 _convert_review_xml_node_to_book: length of review_text= 193
DEBUG: 61.9 _convert_review_xml_node_to_book: length of review_text= 300
DEBUG: 61.9 _convert_review_xml_node_to_book: length of review_text= 299
DEBUG: 61.9 _convert_review_xml_node_to_book: length of review_text= 299
DEBUG: 61.9 _convert_review_xml_node_to_book: length of review_text= 310
DEBUG: 61.9 _convert_review_xml_node_to_book: length of review_text= 300
DEBUG: 61.9 _convert_review_xml_node_to_book: length of review_text= 310
DEBUG: 61.9 _convert_review_xml_node_to_book: length of review_text= 299
DEBUG: 61.9 _convert_review_xml_node_to_book: length of review_text= 310
DEBUG: 61.9 _convert_review_xml_node_to_book: length of review_text= 230
DEBUG: 61.9 _convert_review_xml_node_to_book: length of review_text= 54
DEBUG: 61.9 _convert_review_xml_node_to_book: length of review_text= 310
DEBUG: 61.9 _convert_review_xml_node_to_book: length of review_text= 320
DEBUG: 61.9 _convert_review_xml_node_to_book: length of review_text= 320
DEBUG: 61.9 _convert_review_xml_node_to_book: length of review_text= 310
DEBUG: 61.9 _convert_review_xml_node_to_book: length of review_text= 260
DEBUG: 61.9 _convert_review_xml_node_to_book: length of review_text= 228
DEBUG: 61.9 _convert_review_xml_node_to_book: length of review_text= 154
DEBUG: 61.9 _convert_review_xml_node_to_book: length of review_text= 300
DEBUG: 61.9 _convert_review_xml_node_to_book: length of review_text= 319
DEBUG: 61.9 _convert_review_xml_node_to_book: length of review_text= 34
DEBUG: 61.9 _convert_review_xml_node_to_book: length of review_text= 300
DEBUG: 62.0 _convert_review_xml_node_to_book: length of review_text= 310
DEBUG: 62.0 _convert_review_xml_node_to_book: length of review_text= 160
DEBUG: 62.0 _convert_review_xml_node_to_book: length of review_text= 236
DEBUG: 62.0 _convert_review_xml_node_to_book: length of review_text= 315
DEBUG: 62.0 _convert_review_xml_node_to_book: length of review_text= 300
DEBUG: 62.0 sync_shelves - returned from ChooseShelvesToSyncDialog
DEBUG: 62.0 sync_shelves - About to open DoShelfSyncDialog
DEBUG: 64.6 CalibreDbHelper::apply_actions_to_calibre - actions: [{u'action': u'ADD', u'value': u'DNF', u'column': u'#exclusiveshelf'}, {u'action': u'ADD', u'value': u'date_updated', u'column': u'#gr_updateded'}, {u'action': u'ADD', u'value': u'date_added', u'column': u'#grdateadded'}, {u'action': u'ADD', u'value': u'Y', u'column': u'#ingr'}, {u'action': u'ADD', u'value': u'DNF', u'column': u'#readstatus'}, {u'action': u'ADD', u'value': u'1.Archived', u'column': u'#calibrelibrary'}, {u'action': u'ADD', u'value': u'none', u'column': u'#dr1'}, {u'action': u'ADD', u'value': u'none', u'column': u'#dr1'}, {u'action': u'ADD', u'value': u'none', u'column': u'#grdateread'}, {u'action': u'REMOVE', u'value': u'1.Current', u'column': u'#calibrelibrary'}, {u'action': u'REMOVE', u'value': u'1.Erotic', u'column': u'#calibrelibrary'}, {u'action': u'REMOVE', u'value': u'1.Erotica', u'column': u'#calibrelibrary'}, {u'action': u'REMOVE', u'value': u'1.Re-reads', u'column': u'#calibrelibrary'}, {u'action': u'REMOVE', u'value': u'1.Unread', u'column': u'#calibrelibrary'}, {u'action': u'REMOVE', u'value': u'1/aNext up tbr', u'column': u'#details'}, {u'action': u'REMOVE', u'value': u'Amazon.On Deck', u'column': u'#details'}, {u'action': u'REMOVE', u'value': u'in1221', u'column': u'#details'}]
DEBUG: 67.4 sync_shelves - returned from DoShelfSyncDialog
DEBUG: 67.4 sync_shelves - About to _update_goodreads_ids
DEBUG: 157.5 sync_shelves - finished _update_goodreads_ids

Actually, it is running a bit faster, but I am trying it on different shelves that either have a lot of reviews, or no review but both have no additional sync rules beyond updating two shelves. I will post the results

[Mrs_Often]

Originally Posted by davidfor

Are you using my Kobo Utilities plugin to fetch the reading status from the Kobo device? If so, the status dialog has an option to call the Goodreads Sync to send the progress to the Goodreads. This will add the book to the reading shelf and the read shelf when the book is finished.

Huh.... For me that has never worked. It does move the book to the read shelf when it is finished, but it only updates the reading progress without moving the book to the reading shelf when the book isn't finished yet...

Is there a setting somewhere I need to toggle? I can't find it...

[davidfor]

Originally Posted by Rellwood

Hey, could you pretty please check out this bug report and see if you can identify why it takes so long to sync.

As always, you supply so little information with you reports that I you should not be surprised when you seem to be ignored. I mean, you should always state what you were actually doing. And I mean explicitly state the steps. And the versions in involve (which is why I always want a full debug log as will see the versions). And, most importantly, where you think the problem is. I mean, from the log, the only think I can guess is that you think there is to much time taken between the last two lines. Which of course leaves the other important piece of data, how many books are involved. Yes, that time is to long for 1 book, but, is it to long for 10? Or 100? Or a 1000?

DEBUG: 15.4 sync_shelves - start
DEBUG: 18.4 HttpHelper::get_goodreads_books_on_shelves: user_name=Scarlett Rue
DEBUG: 18.4 HttpHelper::get_goodreads_books_on_shelves: shelf='currently-reading', page=1
DEBUG: 18.4 _oauth_request_get: url=https://www.goodreads.com/review/list.xml?v=2&shelf=currently-reading&page=1&per_page=200
DEBUG: 20.7 sync_shelves - returned from ChooseShelvesToSyncDialog
DEBUG: 20.7 sync_shelves - About to open DoShelfSyncDialog
DEBUG: 27.7 CalibreDbHelper::apply_actions_to_calibre - actions: [{u'action': u'ADD', u'value': u'Currently Reading', u'column': u'#exclusiveshelf'}, {u'action': u'ADD', u'value': u'date_added', u'column': u'#grdateadded'}, {u'action': u'ADD', u'value': u'Currently Reading', u'column': u'#readstatus'}, {u'action': u'ADD', u'value': u'date_updated', u'column': u'#gr_updateded'}, {u'action': u'ADD', u'value': u'1.Current', u'column': u'#calibrelibrary'}, {u'action': u'ADD', u'value': u'Y', u'column': u'#ingr'}, {u'action': u'REMOVE', u'value': u'Placeholder.Maybe', u'column': u'#book_style'}, {u'action': u'REMOVE', u'value': u'Placeholder.Pre-Ordered', u'column': u'#book_style'}, {u'action': u'REMOVE', u'value': u'Placeholder.Waiting for it', u'column': u'#book_style'}, {u'action': u'REMOVE', u'value': u'Placeholder.Want to Read', u'column': u'#book_style'}]
DEBUG: 28.0 sync_shelves - returned from DoShelfSyncDialog
DEBUG: 28.0 sync_shelves - About to _update_goodreads_ids
DEBUG: 41.3 sync_shelves - finished _update_goodreads_ids
DEBUG: 47.6 sync_shelves - start
DEBUG: 50.7 HttpHelper::get_goodreads_books_on_shelves: user_name=Scarlett Rue
DEBUG: 50.7 HttpHelper::get_goodreads_books_on_shelves: shelf='dnf', page=1
DEBUG: 50.7 _oauth_request_get: url=https://www.goodreads.com/review/list.xml?v=2&shelf=dnf&page=1&per_page=200
DEBUG: 61.9 _convert_review_xml_node_to_book: length of review_text= 181
DEBUG: 61.9 _convert_review_xml_node_to_book: length of review_text= 193
DEBUG: 61.9 _convert_review_xml_node_to_book: length of review_text= 300
DEBUG: 61.9 _convert_review_xml_node_to_book: length of review_text= 299
DEBUG: 61.9 _convert_review_xml_node_to_book: length of review_text= 299
DEBUG: 61.9 _convert_review_xml_node_to_book: length of review_text= 310
DEBUG: 61.9 _convert_review_xml_node_to_book: length of review_text= 300
DEBUG: 61.9 _convert_review_xml_node_to_book: length of review_text= 310
DEBUG: 61.9 _convert_review_xml_node_to_book: length of review_text= 299
DEBUG: 61.9 _convert_review_xml_node_to_book: length of review_text= 310
DEBUG: 61.9 _convert_review_xml_node_to_book: length of review_text= 230
DEBUG: 61.9 _convert_review_xml_node_to_book: length of review_text= 54
DEBUG: 61.9 _convert_review_xml_node_to_book: length of review_text= 310
DEBUG: 61.9 _convert_review_xml_node_to_book: length of review_text= 320
DEBUG: 61.9 _convert_review_xml_node_to_book: length of review_text= 320
DEBUG: 61.9 _convert_review_xml_node_to_book: length of review_text= 310
DEBUG: 61.9 _convert_review_xml_node_to_book: length of review_text= 260
DEBUG: 61.9 _convert_review_xml_node_to_book: length of review_text= 228
DEBUG: 61.9 _convert_review_xml_node_to_book: length of review_text= 154
DEBUG: 61.9 _convert_review_xml_node_to_book: length of review_text= 300
DEBUG: 61.9 _convert_review_xml_node_to_book: length of review_text= 319
DEBUG: 61.9 _convert_review_xml_node_to_book: length of review_text= 34
DEBUG: 61.9 _convert_review_xml_node_to_book: length of review_text= 300
DEBUG: 62.0 _convert_review_xml_node_to_book: length of review_text= 310
DEBUG: 62.0 _convert_review_xml_node_to_book: length of review_text= 160
DEBUG: 62.0 _convert_review_xml_node_to_book: length of review_text= 236
DEBUG: 62.0 _convert_review_xml_node_to_book: length of review_text= 315
DEBUG: 62.0 _convert_review_xml_node_to_book: length of review_text= 300
DEBUG: 62.0 sync_shelves - returned from ChooseShelvesToSyncDialog
DEBUG: 62.0 sync_shelves - About to open DoShelfSyncDialog
DEBUG: 64.6 CalibreDbHelper::apply_actions_to_calibre - actions: [{u'action': u'ADD', u'value': u'DNF', u'column': u'#exclusiveshelf'}, {u'action': u'ADD', u'value': u'date_updated', u'column': u'#gr_updateded'}, {u'action': u'ADD', u'value': u'date_added', u'column': u'#grdateadded'}, {u'action': u'ADD', u'value': u'Y', u'column': u'#ingr'}, {u'action': u'ADD', u'value': u'DNF', u'column': u'#readstatus'}, {u'action': u'ADD', u'value': u'1.Archived', u'column': u'#calibrelibrary'}, {u'action': u'ADD', u'value': u'none', u'column': u'#dr1'}, {u'action': u'ADD', u'value': u'none', u'column': u'#dr1'}, {u'action': u'ADD', u'value': u'none', u'column': u'#grdateread'}, {u'action': u'REMOVE', u'value': u'1.Current', u'column': u'#calibrelibrary'}, {u'action': u'REMOVE', u'value': u'1.Erotic', u'column': u'#calibrelibrary'}, {u'action': u'REMOVE', u'value': u'1.Erotica', u'column': u'#calibrelibrary'}, {u'action': u'REMOVE', u'value': u'1.Re-reads', u'column': u'#calibrelibrary'}, {u'action': u'REMOVE', u'value': u'1.Unread', u'column': u'#calibrelibrary'}, {u'action': u'REMOVE', u'value': u'1/aNext up tbr', u'column': u'#details'}, {u'action': u'REMOVE', u'value': u'Amazon.On Deck', u'column': u'#details'}, {u'action': u'REMOVE', u'value': u'in1221', u'column': u'#details'}]
DEBUG: 67.4 sync_shelves - returned from DoShelfSyncDialog
DEBUG: 67.4 sync_shelves - About to _update_goodreads_ids
DEBUG: 157.5 sync_shelves - finished _update_goodreads_ids

Actually, it is running a bit faster, but I am trying it on different shelves that either have a lot of reviews, or no review but both have no additional sync rules beyond updating two shelves. I will post the results

Now, looking at what happens between those last two lines, there is a problem. And there is a weird interaction between the progress bar and what is done that makes it a little longer. But, more importantly, there are some errors in that code that means that it is doing more work than it should, and, more importantly, not doing something that it is supposed to.

The attached beta should solve this. And it also has a lot of debugging output in between those last two lines that should give me a better idea of what is going on.

[davidfor]

Originally Posted by Mrs_Often

Huh.... For me that has never worked. It does move the book to the read shelf when it is finished, but it only updates the reading progress without moving the book to the reading shelf when the book isn't finished yet...

Is there a setting somewhere I need to toggle? I can't find it...

No and Yes.

No, because there isn't an option for it. When you set progress, it should have caused the book to be put on the "Currently Reading" shelf. But, it didn't always happen. And, I've never worked out why.

The "Yes" is because someone convinced me to add an option to do it. The recent betas have this. There is an option on the update progress dialog to put the book on the "Currently Reading" shelf when setting the progress. It actually does this each time the progress is updated (until finished) but it doesn't seem to harm anything.

Try the beta I just posted and tell me if it is OK.

[Mrs_Often]

Originally Posted by davidfor

No and Yes.

No, because there isn't an option for it. When you set progress, it should have caused the book to be put on the "Currently Reading" shelf. But, it didn't always happen. And, I've never worked out why.

The "Yes" is because someone convinced me to add an option to do it. The recent betas have this. There is an option on the update progress dialog to put the book on the "Currently Reading" shelf when setting the progress. It actually does this each time the progress is updated (until finished) but it doesn't seem to harm anything.

Try the beta I just posted and tell me if it is OK.

Hah such coincidental timing. Just tried the beta: it works! Books with a book progress are now magically sitting on my Currently Reading shelf in Goodreads.

Thank you!

[Lewapq]

Hello,

When I try to authorzie Plugin with Goodreads I get the below error. Can you please suggest what might be the problem ?

Thanks in advance,
Lewapq

calibre, version 5.4.2
ERROR: Unhandled exception: <b>SSLHandshakeError</b>:[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get issuer certificate (_ssl.c:1123)

calibre 5.4.2  embedded-python: True is64bit: False
Windows-10-10.0.18362 Windows ('32bit', 'WindowsPE')
32bit process running on 64bit windows
('Windows', '10', '10.0.18362')
Python 3.8.5
Windows: ('10', '10.0.18362', '', 'Multiprocessor Free')
Interface language: None
Successfully initialized third party plugins: Gather KFX-ZIP (from KFX Input) (1, 35, 0) && Package KFX (from KFX Input) (1, 35, 0) && Amazon.com Multiple Countries (1, 0, 0) && Author Book Count (2, 1, 9) && Barnes & Noble (1, 2, 16) && Find Duplicates (1, 8, 3) && Goodreads (1, 5, 1) && Goodreads Sync (1, 14, 3) && Goodreads_Rating (3, 1, 0) && KFX metadata reader (from KFX Input) (1, 35, 0) && KFX Input (1, 35, 0) && Kindle Collections (1, 7, 29) && LubimyCzytac (2, 0, 46)
Traceback (most recent call last):
  File "calibre_plugins.goodreads_sync.httplib2.__init__", line 1096, in connect
  File "calibre_plugins.goodreads_sync.httplib2.__init__", line 117, in _ssl_wrap_socket
  File "ssl.py", line 500, in wrap_socket
  File "ssl.py", line 1040, in _create
  File "ssl.py", line 1309, in do_handshake
ssl.SSLCertVerificationError: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get issuer certificate (_ssl.c:1123)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "calibre_plugins.goodreads_sync.config", line 1118, in authorize_plugin
  File "calibre_plugins.goodreads_sync.core", line 215, in get_request_token_secret
  File "calibre_plugins.goodreads_sync.core", line 131, in _oauth_request_get
  File "calibre_plugins.goodreads_sync.oauth2.__init__", line 689, in request
  File "calibre_plugins.goodreads_sync.httplib2.__init__", line 1689, in request
  File "calibre_plugins.goodreads_sync.httplib2.__init__", line 1429, in _request
  File "calibre_plugins.goodreads_sync.httplib2.__init__", line 1349, in _conn_request
  File "calibre_plugins.goodreads_sync.httplib2.__init__", line 1122, in connect
calibre_plugins.goodreads_sync.httplib2.SSLHandshakeError: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get issuer certificate (_ssl.c:1123)

[davidfor]

Originally Posted by Lewapq

Hello,

When I try to authorzie Plugin with Goodreads I get the below error. Can you please suggest what might be the problem ?

Thanks in advance,
Lewapq

calibre, version 5.4.2
ERROR: Unhandled exception: <b>SSLHandshakeError</b>:[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get issuer certificate (_ssl.c:1123)

calibre 5.4.2  embedded-python: True is64bit: False
Windows-10-10.0.18362 Windows ('32bit', 'WindowsPE')
32bit process running on 64bit windows
('Windows', '10', '10.0.18362')
Python 3.8.5
Windows: ('10', '10.0.18362', '', 'Multiprocessor Free')
Interface language: None
Successfully initialized third party plugins: Gather KFX-ZIP (from KFX Input) (1, 35, 0) && Package KFX (from KFX Input) (1, 35, 0) && Amazon.com Multiple Countries (1, 0, 0) && Author Book Count (2, 1, 9) && Barnes & Noble (1, 2, 16) && Find Duplicates (1, 8, 3) && Goodreads (1, 5, 1) && Goodreads Sync (1, 14, 3) && Goodreads_Rating (3, 1, 0) && KFX metadata reader (from KFX Input) (1, 35, 0) && KFX Input (1, 35, 0) && Kindle Collections (1, 7, 29) && LubimyCzytac (2, 0, 46)
Traceback (most recent call last):
  File "calibre_plugins.goodreads_sync.httplib2.__init__", line 1096, in connect
  File "calibre_plugins.goodreads_sync.httplib2.__init__", line 117, in _ssl_wrap_socket
  File "ssl.py", line 500, in wrap_socket
  File "ssl.py", line 1040, in _create
  File "ssl.py", line 1309, in do_handshake
ssl.SSLCertVerificationError: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get issuer certificate (_ssl.c:1123)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "calibre_plugins.goodreads_sync.config", line 1118, in authorize_plugin
  File "calibre_plugins.goodreads_sync.core", line 215, in get_request_token_secret
  File "calibre_plugins.goodreads_sync.core", line 131, in _oauth_request_get
  File "calibre_plugins.goodreads_sync.oauth2.__init__", line 689, in request
  File "calibre_plugins.goodreads_sync.httplib2.__init__", line 1689, in request
  File "calibre_plugins.goodreads_sync.httplib2.__init__", line 1429, in _request
  File "calibre_plugins.goodreads_sync.httplib2.__init__", line 1349, in _conn_request
  File "calibre_plugins.goodreads_sync.httplib2.__init__", line 1122, in connect
calibre_plugins.goodreads_sync.httplib2.SSLHandshakeError: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get issuer certificate (_ssl.c:1123)

Can you try visiting the Goodread page with the current Microsoft browser? A lot of certificate issues are because they haven't been updated where the OS stores them. I can't decide if that is one of them, or if it is a transitory problem that will probably work the nect time.

I have checked that it is working from here. One of the above reasons is the most likely cause.

[Lewapq]

Originally Posted by davidfor

Can you try visiting the Goodread page with the current Microsoft browser? A lot of certificate issues are because they haven't been updated where the OS stores them. I can't decide if that is one of them, or if it is a transitory problem that will probably work the nect time.

I have checked that it is working from here. One of the above reasons is the most likely cause.

I visited the page with Microsoft Edge. I checked certificates (certmgr). I searched for certificate that contains "good"/"Good" in inssued by field. None was found. Are you able to share what certificate I should have ?

[davidfor]

Originally Posted by Lewapq

I visited the page with Microsoft Edge. I checked certificates (certmgr). I searched for certificate that contains "good"/"Good" in inssued by field. None was found. Are you able to share what certificate I should have ?

The issue that has happened in the past is that because the MS browser was never used, the CA was not being updated. Other browsers using managed it themselves. The plugin uses the OS store. Visiting the site in question with the MS browser would fix this. This might have changed with Edge, or the Chrome version the browser.

Looking at the certificate, it is issued by Amazon with themselves as the CA. Though there seems to be "Starfire" involved as well.

Looking at discussion about the error on the web, it does look like how the certificates are handled has changed with Python 3.6 or thereabout. I'll have to think about what can be done.

[sarasas]

I tried the last attached Beta to see if it would solve my performance problem. I have a large database both at Goodreads and locally and Sync used to need about 1 second per book as it slowly updated them (there was a progress bar).

With the beta version I did a dummy sync and the final phase that used to take half an hour was fast enough for me to not notice. I hope that means that your fix works.

Also, thanks a lot for your work on these plugins. I really appreciate it!

[Lewapq]

OK thanks.

[jwilker]

Hopefully this belongs here When plugging my Kobo Clara in and letting the reading percentage update. I get an error on the "Upload to Goodreads" portion.

calibre, version 5.5.0
ERROR: Unhandled exception: <b>TypeError</b>:can only concatenate str (not "bytes") to str

calibre 5.5 embedded-python: True is64bit: True
macOS-10.16-x86_64-i386-64bit Darwin ('64bit', '')
('Darwin', '20.1.0', 'Darwin Kernel Version 20.1.0: Sat Oct 31 00:07:11 PDT 2020; root:xnu-7195.50.7~2/RELEASE_X86_64')
Python 3.8.5
OSX: ('10.16', ('', '', ''), 'x86_64')
Interface language: None
Successfully initialized third party plugins: Goodreads Sync (1, 14, 3) && KePub Output (3, 4, 1) && Kobo Books (1, 8, 0) && Kobo Utilities (2, 11, 8) && KoboTouchExtended (3, 4, 1) && Prettify Cover (1, 5, 0)
Traceback (most recent call last):
File "calibre_plugins.goodreads_sync.dialogs", line 713, in action_button_clicked
self.grhttp.update_status(client, goodreads_id, progress, self.progress_is_percent, review_text)
File "calibre_plugins.goodreads_sync.core", line 386, in update_status
response, _content = self._oauth_request_post(oauth_client, url, body, success_status)
File "calibre_plugins.goodreads_sync.core", line 151, in _oauth_request_post
return self._handle_failure(response, content, url)
File "calibre_plugins.goodreads_sync.core", line 195, in _handle_failure
detail = 'URL: ' + url + '\nResponse Code: ' + response['status'] +'\n' + content
TypeError: can only concatenate str (not "bytes") to str


I also get this error when manually running the sync from shelf function.

[davidfor]

Originally Posted by jwilker

Hopefully this belongs here When plugging my Kobo Clara in and letting the reading percentage update. I get an error on the "Upload to Goodreads" portion.

calibre, version 5.5.0
ERROR: Unhandled exception: <b>TypeError</b>:can only concatenate str (not "bytes") to str

calibre 5.5 embedded-python: True is64bit: True
macOS-10.16-x86_64-i386-64bit Darwin ('64bit', '')
('Darwin', '20.1.0', 'Darwin Kernel Version 20.1.0: Sat Oct 31 00:07:11 PDT 2020; root:xnu-7195.50.7~2/RELEASE_X86_64')
Python 3.8.5
OSX: ('10.16', ('', '', ''), 'x86_64')
Interface language: None
Successfully initialized third party plugins: Goodreads Sync (1, 14, 3) && KePub Output (3, 4, 1) && Kobo Books (1, 8, 0) && Kobo Utilities (2, 11, 8) && KoboTouchExtended (3, 4, 1) && Prettify Cover (1, 5, 0)
Traceback (most recent call last):
File "calibre_plugins.goodreads_sync.dialogs", line 713, in action_button_clicked
self.grhttp.update_status(client, goodreads_id, progress, self.progress_is_percent, review_text)
File "calibre_plugins.goodreads_sync.core", line 386, in update_status
response, _content = self._oauth_request_post(oauth_client, url, body, success_status)
File "calibre_plugins.goodreads_sync.core", line 151, in _oauth_request_post
return self._handle_failure(response, content, url)
File "calibre_plugins.goodreads_sync.core", line 195, in _handle_failure
detail = 'URL: ' + url + '\nResponse Code: ' + response['status'] +'\n' + content
TypeError: can only concatenate str (not "bytes") to str


I also get this error when manually running the sync from shelf function.

That is an error when displaying an error from the call to the Goodreads site. It is fixed in the beta that I posted recently. Please try that. I'll release the beta when I have more feedback that it solves the performance problems and doesn't break anything else.

[jwilker]

Awesome, that seemed to have solved it. Synced right away (well after I re-authorized, LOL).

Can keep an eye on it and report back, is there anything you need me to pay special attention to? Happy to send along any logs ya need.