[GUI Plugin] Annotations

[Terisa de morgan]

Originally Posted by Leonatus

When I used it, it worked correctly, also on connected device. But this lasted only few days, because of updating Calibre.

Which were your previous calibre version?

[Leonatus]

Originally Posted by Terisa de morgan

Which were your previous calibre version?

It was 8.16.2 (see #1250).

[Terisa de morgan]

Originally Posted by Leonatus

It was 8.16.2 (see #1250).

So, it worked for you at 8.16.2. Curious, it didn't work for me. I'll check as I'm staying in calibre 8 for now.

[PeterT]

OK. Lets try this again; this time I have done some testing and managed to load annotations cfrom my Kobo into calibre 9.x (and also using this plugin 8.x).

The issue last time was my being "smart" and using a 4 digit version number to make it easier to track production vs beta releases Conside this as a beta release with version number 1.17.15.

[Leonatus]

@PeterT: works for me (v.9.1)! Great!

[aik099]

Originally Posted by PeterT

OK. Lets try this again; this time I have done some testing and managed to load annotations cfrom my Kobo into calibre 9.x (and also using this plugin 8.x).

The issue last time was my being "smart" and using a 4 digit version number to make it easier to track production vs beta releases Conside this as a beta release with version number 1.17.15.

1. Would this work for Calibre 8.x as well?
2. Are you making these changes to the https://github.com/PeterJT/calibre-annotations as well?
3. I've noticed a massive line-ending change (from \n to \r\n). Not sure if that was intentional.
4. what about these changes (see the screenshot from Sublime Merge), that are absent in every uploaded "Annotations.zip", but present on GitHub Repo (see https://github.com/davidfor/calibre-...c8429f7652fec1). I guess David forgot to make a releases including them:

https://cln.sh/NFJbV95fQJ887llmMxr4

5. These changes in the "reader_app_support.py" seem to be inconsistent (the "\\W" instead of "\W"; see screenshot):

https://cln.sh/0lxtd9tTkQSRYr91WF24

I suggest:

- updating the "about.txt" to keep track of the changes in a particular version
- use GitHub repo to make changes & releasing to have a single source of truth

Thank you.

P.S.
I can try sending PRs with all that stuff, and we'll continue code-related discussions there. Easier this way, than doing putting code screenshots in here.

[PeterT]

Actually I'd forgotten about GitHub; I was developing purely locally

It's been tested with calibre 5.x 6.x and 8.x with no issue.

I've no idea about the colour changes or line endings. These changes were based solely on the build from this thread

Sent from my TB350FU using Tapatalk

[JSWolf]

Originally Posted by PeterT

Actually I'd forgotten about GitHub; I was developing purely locally

It's been tested with calibre 5.x 6.x and 8.x with no issue.

I've no idea about the colour changes or line endings. These changes were based solely on the build from this thread

Sent from my TB350FU using Tapatalk

Is Annotations going to be tested on 9.x before its released?

[DNSB]

Test on calibre 9.1.0 on Windows 11 (OS Build 26220-7752) and the fetch annotation from device worked. On my main library, it returned 14 annotations which were all left over edits to correct errors.

"I clamped all twenty fingers around his arm"???

[PeterT]

Originally Posted by JSWolf

Is Annotations going to be tested on 9.x before its released?

Um.. try reading the post with the plugin in it.

Sent from my Pixel 9a using Tapatalk

[aik099]

Originally Posted by PeterT

Actually I'd forgotten about GitHub; I was developing purely locally

It's been tested with calibre 5.x 6.x and 8.x with no issue.

I've no idea about the colour changes or line endings. These changes were based solely on the build from this thread

Sent from my TB350FU using Tapatalk

I'll try to arrange some PRs to the https://github.com/PeterJT/calibre-annotations repository. We'll see how it goes considering that the release version is incremented with each change and having parallel PR development would result in 100% merge conflicts. Hopefully, GitHub will figure that out.

I wonder if we could connect with Calibre author to push new plugin versions in the Calibre repository so that people would officially get updated via Calibre without jumping through the hoops to get the latest fixes.

Thank you.

[Terisa de morgan]

Originally Posted by aik099

I'll try to arrange some PRs to the https://github.com/PeterJT/calibre-annotations repository. We'll see how it goes considering that the release version is incremented with each change and having parallel PR development would result in 100% merge conflicts. Hopefully, GitHub will figure that out.

I wonder if we could connect with Calibre author to push new plugin versions in the Calibre repository so that people would officially get updated via Calibre without jumping through the hoops to get the latest fixes.

Thank you.

It shouldn't be necessary. When a release is ready, a moderaton can make the changes so calibre offers new version of the plugin and the zip file is in the first message.