Attn plugin devs: porting to python 3

[eschwartz]

Works fine for me.

P.S. There is a "copy to clipboard" button for a reason, please use it (and back it up with a screenshot if you really want to). It's quite awkward to look at screenshots of text and try to extract useful information from it.

[DaltonST]

See the attached. Apparently specific to Windows 10 x86.

[eschwartz]

I can replicate this on the frozen Linux binaries. Removing and regenerating the file calibre-4.99.4-x86_64/lib/python3.8/site-packages/calibre/gui2/preferences/look_feel_ui.pyc based on the py3 branch was sufficient to get it to work.

The problem doesn't manifest if, like me, you build your own or use the CALIBRE_DEVELOP_FROM environment variable pointed at a copy of the source. In that case, calibre/gui2/preferences/look_feel.ui will be regenerated with pyuic and the problem will go away.

Looks like something went wrong in the build environment. The source code is fine though.

[kovidgoyal]

This is likely just an artifact of 4.99.4 being very old, I need to release an updated build.

[DaltonST]

Originally Posted by kovidgoyal

This is likely just an artifact of 4.99.4 being very old, I need to release an updated build.

Nothing changed in 4.99.5 for Windows x86.


DaltonST

[kovidgoyal]

wait 4.99.5 is not complete yet, the initial upload was a mistake. I will post here when the new build is ready.

[kovidgoyal]

4.99.5 with the fix, and a fully updated calibre code base is now uploaded.

[JSWolf]

Is there a way to prevent Linux repositories from grabbing the Python 3 beta? I've been reading a few posts of Linux users saying that some plugin no longer works because of this botch jib by the Linux repositories.

[kovidgoyal]

No, linux repositories do pretty much whatever they feel like, there is no controlling them, and in a way it is a good thing, those people will come and post here and their posts might get some plugin authors to port their plugins.

[davidfor]

@Kovid, thanks for the update. I haven't been doing as much work on the plugins as the beta was getting out of date. And I just had to step away from it at one point.

I have just posted a beta of the Count Pages plugin. Thanks to the poke from @JimmXinu. I'd done it ages ago, just hadn't posted it.

I do have one problem left in it. It can get the page count from Goodreads. To do that, it downloads the books page and parses it for the page count. Most of my test cases work. But, for https://www.goodreads.com/book/show/33701864 it produces an error.

The code that does this is basically:

        br = browser()
        raw = br.open_novisit(self.url, timeout=self.timeout).read().strip()
        raw = raw.decode('utf-8', errors='replace')
        root = fromstring(clean_ascii_chars(raw))

For the link above it produces an error:

        Traceback (most recent call last):
          File "calibre_plugins.count_pages.download", line 77, in _get_details
          File "__init__.py", line 875, in fromstring
          File "__init__.py", line 761, in document_fromstring
          File "src/lxml/etree.pyx", line 3222, in lxml.etree.fromstring
          File "src/lxml/parser.pxi", line 1877, in lxml.etree._parseMemoryDocument
          File "src/lxml/parser.pxi", line 1758, in lxml.etree._parseDoc
          File "src/lxml/parser.pxi", line 1068, in lxml.etree._BaseParser._parseUnicodeDoc
          File "src/lxml/parser.pxi", line 601, in lxml.etree._ParserContext._handleParseResultDoc
          File "src/lxml/parser.pxi", line 711, in lxml.etree._handleParseResult
          File "src/lxml/parser.pxi", line 640, in lxml.etree._raiseParseError
          File "<string>", line 1
        lxml.etree.XMLSyntaxError: encoding not supported USC4 little endian, line 1, column 1

I can't find anything useful on the web for dealing with this. Or working out where it is. Anyone have any ideas?

[kovidgoyal]

@davidfor; That will happen if there is a BOM at the start of the data. Remove it and you should be fine.

[davidfor]

Thanks, that gave me the hint to find it. I just needed to change the decode to use "utf-8-sig" and it worked.

[Terisa de morgan]

Something that is happening to me: aside of migrating plugins... if we have function inside the library, we have to migrate them too, haven't we?

[eschwartz]

What kind of functions? Plugboard functions?

If you're using templates the boring way, you shouldn't need to change anything. If you've used Preferences => Template Functions to define your own, then you would need to port your own stuff over, though if you're not doing anything complicated there's a good chance you're already compatible with python3...

[Terisa de morgan]

Originally Posted by eschwartz

What kind of functions? Plugboard functions?

If you're using templates the boring way, you shouldn't need to change anything. If you've used Preferences => Template Functions to define your own, then you would need to port your own stuff over, though if you're not doing anything complicated there's a good chance you're already compatible with python3...

Let's see... because, yes, they are template fuctions.