[Device Plugin] Kobo Touch Extended Driver

[NiLuJe]

@GeoffR: That might be it, feeding it to Mantano leads it to try to open it as an epub3 (which fails spectacularly, FWIW) .

That said, I still (mostly) don't see anything cut-off, except for the very edge of the italic g on the left.

What I do see is stuff cut-off from the top/bottom, with some fonts/line-spacing combo, but that's on every kind of kepub (with or without the book-inner/book-columns divs), and might be related to my extreme lack of margins, and/or the fact that I only patched for the left/right padding (although that would only apply to stuff w/ book-inner divs)?

EDIT: Although I guess that's probably a question more related to full-screen mode/the patches than this, since you pretty much answered my original question about why those kepubs weren't getting the book-inner treatment .

[GeoffR]

Originally Posted by NiLuJe

@GeoffR: That might be it, feeding it to Mantano leads it to try to open it as an epub3 (which fails spectacularly, FWIW) .

That said, I still (mostly) don't see anything cut-off, except for the very edge of the italic g on the left.

The f in the font you are using doesn't have such a large right bearing as the f in Georgia, I wonter if you could try it with Georgia?

What I do see is stuff cut-off from the top/bottom, with some fonts/line-spacing combo, but that's on every kind of kepub (with or without the book-inner/book-columns divs), and might be related to my extreme lack of margins, and/or the fact that I only patched for the left/right padding (although that would only apply to stuff w/ book-inner divs)?

I'm pretty sure this is to do with the smaller line spacing that is possible with the patch. It seems to happen with recent firmware in the kepub reader once the lines start to overlap (which happens once you get the line spacing down to about 0.85, depending on font family).

[NiLuJe]

@GeoffR: Ooh, it's subtle, I missed it at first, since it's still fairly readable, and I'm not used to Georgia, but, yep, Gorgia's f's get chopped up a tiny bit!

So, to recap: all's well with the world, the patch is doing its job perfectly, we just have to know that synced kepubs than originated from an epub3 are constructed, and thus behave, differently .

----

As for the top/bottom thing, yep, thanks for confirming that, larger line-heights indeed help .

----

@jgoguen: Now that all my annoying questions have been answered, I'll clean up my GH tree and send the PRs tomorrow . Then we'll get to wait with bated breath to see how much I broke stuff for people ^^.

EDIT: Although I guess that means I'll first have to actually figure out what goes wrong with books using div's instead of p's instead of working-around the issue by not adding the book-inner/book-columns div's in those cases...

[NiLuJe]

@jgoguen:

PRs sent .

[PeterT]

@NiLuJe: Not so sure you want to up the version required to 2.1.0. While YES, calibre 1.48 didn;t support the H2O, davidfor (developer of the Kobo driver) does have ideas on how to add the required USB id's into the driver for 1.48

[NiLuJe]

@PeterT: It's not so much the IDs as using the isAuraH2O() API call that doesn't exist before that point that I'm worried about, but I'm open to suggestions .

[PeterT]

Lets see what davidfor has to say.

[Terisa de morgan]

Originally Posted by NiLuJe

@jgoguen:

PRs sent .

I've got a question. I see the code is adding the the Kobo style hacks. Do they exist at the driver which is working now? Is it going to add some characteristics at my own stylesheet? Or modify them? Because I like my margins as they are now

[NiLuJe]

It doesn't affect margins at all, and the kobo_extra stuff always wins anyways .

[Terisa de morgan]

Originally Posted by NiLuJe

It doesn't affect margins at all, and the kobo_extra stuff always win anyways .

Ok, thank you (I edit my css so I like to use it )

[jgoguen]

I know how to add support for the H20 without updating the calibre version required. Once I'm at a computer (couple days, I'm on vacation right now) I'll show you the code unless someone else here does first

[JSWolf]

Can we have an added feature where if we already have a kepub, that we can tell the driver not to try to make it into a kepub and just put it on the Kobo and add it to the database?

[jgoguen]

That already exists. If a file within an ePub contains a single (or more) <span> with class "koboSpan" or id starting with "kobo." then the content file is skipped and assumed to be in KePub format already.

[JSWolf]

Originally Posted by jgoguen

That already exists. If a file within an ePub contains a single (or more) <span> with class "koboSpan" or id starting with "kobo." then the content file is skipped and assumed to be in KePub format already.

Thanks. I'll give it a go then.

[jgoguen]

Version up for testing! This incorporates the changes made to wrap the body in div#book-columns and div#book-inner. Please give it a shot and let us know here if something breaks for you.