[GUI Plugin] Action Chains

[capink]

Originally Posted by ownedbycats

Does that include using a custom folder instead of resources/images?

Yes. Although I'm not sure whether I should create a new custom folder or re-use the cc_icons folder calibre already creates.

The idea is to have one centralized folder for custom icons. I can see that the cc_icons have some requirements for icons inside it (It must be 128x128 png file). If @chaley does not see this post I will pm to ask if he have any objections or suggestions.

[chaley]

Originally Posted by capink

Yes. Although I'm not sure whether I should create a new custom folder or re-use the cc_icons folder calibre already creates.

The idea is to have one centralized folder for custom icons. I can see that the cc_icons have some requirements for icons inside it (It must be 128x128 png file). If @chaley does not see this post I will pm to ask if have any objections or suggestions.

That folder is used for icons on the book list. If that is like what you are doing then it is a good place to put them.

The opther option is tb_icons, where calibre's tag browser keeps icons used for categories in the tag browser. There are name rules that calibre used to identify the icon for a column. If you use different rules then there can be no name conflict. I think this is what @OBC is talking about

[BetterRed]

My 2¢ - if optional plugins mingle resources with the core or one another, then its hard to get rid of them when the optional plugin is removed - IMO plugins should be self contained.

BR

[ownedbycats]

Yes. If using the cc_icons folder, I'd also be concerned about collision with files in there. Clutter might also be an issue; the icons I use for column icons I usually would not use for AC and vice-versa. This is less a concern for tb_icons though.

[bigwoof]

Hi,

I'm getting this error when running the modified chain iterator code @capink generously provided a few pages back

calibre 6.17  embedded-python: True
Windows-10-10.0.22621-SP0 Windows ('64bit', 'WindowsPE')
('Windows', '10', '10.0.22621')
Python 3.10.1
Windows: ('10', '10.0.22621', 'SP0', 'Multiprocessor Free')
Interface language: None
Successfully initialized third party plugins: Action Chains (1, 18, 6) && Count Pages (1, 13, 0) && Editor Chains (0, 8, 5) && EpubCheck (0, 2, 4) && EpubMerge (2, 15, 0) && EpubSplit (3, 6, 0) && FanFicFare (4, 22, 1) && Favourites Menu (1, 3, 0) && Find Duplicates (1, 10, 8) && Generate Cover (2, 3, 2) && Job Spy (1, 0, 237) && KePub Input (3, 6, 3) && KePub Metadata Reader (3, 4, 3) && KePub Metadata Writer (3, 4, 3) && KePub Output (3, 6, 3) && Kobo Utilities (2, 16, 6) && KoboTouchExtended (3, 6, 3) && Modify ePub (1, 8, 1) && Quality Check (1, 13, 4) && Reading List (1, 15, 1) && Save Virtual Libraries To Column (2, 0, 1) && Save Virtual Libraries To Column GUI (2, 3, 0)
Traceback (most recent call last):
  File "calibre_plugins.action_chains.action", line 448, in run_chain
  File "calibre_plugins.action_chains.chains", line 391, in run
  File "calibre_plugins.action_chains.chains", line 206, in _run_loop
  File "calibre_plugins.action_chains.chains", line 181, in _run_loop
  File "Modified Chain Iterator", line 122, in run
TypeError: Chain.__init__() got an unexpected keyword argument 'add_to_vars'

line 122 is

target_chain = Chain(self.plugin_action, target_chain_config, show_progress=False,
add_to_vars=add_to_vars, chain_caller=True)

Thanks!

[capink]

There was a change to the latest version of the plugin that broke it. I modified the action in the original post. Update to the new code and it should run normally.

[bigwoof]

Originally Posted by capink

There was a change to the latest version of the plugin that broke it. I modified the action in the original post. Update to the new code and it should run normally.

Thanks!! :-)

[ownedbycats]

@capink - Did 6.17 break chain caller? The caller actions went red/invalidated in my chains and cannot re-select them.

[capink]

Originally Posted by ownedbycats

@capink - Did 6.17 break chain caller? The caller actions went red/invalidated in my chains and cannot re-select them.

No. The Chain Caller is the one action that does not depend on any calibre code, so it cannot be broken by calibre upgrades. Double click on the error cell in the chain dialog and copy the error message.

[ownedbycats]

I already removed it from my chain so I could run it without erroring...

They aren't available in the action selector anymore, if that's a clue. Also I just noticed that the Modified Chain Caller had to be fixed. Maybe same issue?

[capink]

Originally Posted by ownedbycats

Also I just noticed that the Modified Chain Caller had to be fixed. Maybe same issue?

No. These modifications were already added to the stock Chain Caller in the last version. They also did not affect the chain validation in any way. They made chain to fail with and error when running.

[ownedbycats]

If you can send me an older version of AC I'll check the error.

[capink]

deleted.

[ownedbycats]

Chain Caller is still missing!



Do you have the JSON for the Caller action? I can try adding that into my settings file.

[capink]

Chain Caller is and experimental action and needs the following plugin tweak

action_chains_experimental = True

Are you sure you have not changed or deleted this? If you have done so, it should also affect chain variants.