Sigil-1.9.1 Release

[snarkophilus]

Originally Posted by DiapDealer

Has to be a race. What about a slight delay between finds? There's no valid need for cycling through finds at one-million mile per hour. Anything faster than than the eye can recognize is wasted anyway.

I have seen this with sorta relatively quick finds without holding down a key combo. See my description of ctrl-] and tap,tap,tap above. The press-and-hold ctrl-g just happens to make it relatively reproducable instead of happens some times but not sure how.

[PapaKilo]

Originally Posted by KevinH

Actually, I just remembered the CodeView current line highlight colour is controlled by a Sigil user Preferences setting under Appearance then the CodeView tab.

So a user can make those highlight line background colours match if they so desire.

Yes, but that setting is ignored when coming from Saved Searches or Spellcheck.

But other than that all of the other things that I use that were messed up have been corrected.

Except for a very minor one.

On earlier versions of Sigil when in spellcheck and used the 'Change Selected Word To' button. The next misspelled word that was shown was also highlighted in CV.

Like I said minor.

Thank You Very Much.

Paul

[KevinH]

No that User Preference is always used in CodeView if set. The colour changes are due to active vs inactive palette colours. When using Spellcheck or Saved Searches, those windows always have focus and so CodeView is inactive as it uses inactive palette colours to indicate that.

As for selecting the next word, that does happen but only when the "All Words" checkbox is not checked. If only showing misspelled words, once that word is corrected it is removed from the list advancing the selection. When the "all words" is selected, fixing a misspelled word does not advance anything.

In addition, the search for the selected word automatically with a single click is gone and has been fow a few releases now as it tremendously slowed down spell checking when huge word lists (huge epubs) are being used (the search for the next instance in the text took too long making hopping around too slow). That is now expected behaviour. Double-clicking now forces the search to be done if you really need to see context.

This hopping around delay is pretty much unnoticeable in short epubs/word lists butwas intolerable in very large epubs, thus the change.

Thanks for testing and confirming your issue was fixed. These fixes will appear in the upcoming Sigil-1.9.2 follow-on release that will hopefully be out soon.

Originally Posted by PapaKilo

Yes, but that setting is ignored when coming from Saved Searches or Spellcheck.

But other than that all of the other things that I use that were messed up have been corrected.

Except for a very minor one.

On earlier versions of Sigil when in spellcheck and used the 'Change Selected Word To' button. The next misspelled word that was shown was also highlighted in CV.

Like I said minor.

Thank You Very Much.

Paul

[pete6055]

Thanks Kevin! I've always used switches to indicate placeholders, regardless of whether I fill them using Regex or by other means. Yes, I agree with you and DiapDealer that this a sloppy habit, but prior versions of Sigil covered for me, so thank you for that too. To tell the truth, I was more concerned about how newline (\n) was executed, or not, and reported what I saw so as to contribute to background knowledge.

As always, thank you Team Sigil for the care shown in meeting user concerns, no matter how small.

[KevinH]

I am glad you can recreate it. If it does not happen with Linux and macOS, then it may be a Qt issue.

A crash dump file and backtrace from it would surely help!

Does this thing still crash when using a Qt6 build of current master on Windows? If not, maybe we can track down the Qt fix that prevents that segfault by searching Qt 6 windows specific code for changes since Qt 5.12.9.

Other than that we are grasping at straws. I have no idea what the equivalent of lldb (mac) and gdb (linux) are on Windows anymore. They must have something equivalent.

Originally Posted by DiapDealer

OK, I can reproduce the ctrl-g hold-down crash on Windows (but not Linux). But I cannot for the life of me get Windows to create a dumpfile for the crash.

The key for me was that the search needs to be able to find many occurrences for the crash to happen. Searching for the word "the" in a novel-sized epub did it for me.

The crash is in QtGui. I know that's not all that helpful, but until I can convince Windows that this is a dumpfile-worthy crash, it's all I've got.

[KevinH]

Thanks for your report. It matches what DiapDealer is seeing.

From a web search of your exception code, it is a stack overflow deep inside QtGui:

ExceptionCode: c00000fd (Stack overflow)

So my guess is Qt is storing the repeated key sequence someplace and search slows the processing down enough that it fills the stack frame where the key sequences are being accumulated and eventually causes a stack over flow.

Either that or there is a recursive call being invoked in Qt that never gets to unwind before the call stack overflows the process stack size.

Not sure what we can do about it, as the issue is deep inside Qt Windows specific code.


Delaying after a key is processed may actually cause more build ups and faster stack overflow in Qt.

On Windows, is there any way to set the process or thread stack size allocation?

Kevin

Originally Posted by snarkophilus

@kevinh - Your talk about Windows debugging info prompted me to dig around. I found this app error crash info via the Windows event viewer after my hold-down-ctrl-g test. Other than saying it happened inside Qt I'm not sure what else to make of this info.

Spoiler:

Version=1
EventType=APPCRASH
EventTime=132913003427981800
ReportType=2
Consent=1
UploadTime=132913003457918176
ReportStatus=268435456
ReportIdentifier=41627c8f-396a-4085-922a-0fe1e53c71de
IntegratorReportIdentifier=92e19824-abe0-4a0b-83c3-c35775b882b9
Wow64Host=34404
NsAppName=Sigil.exe
OriginalFilename=Sigil.exe
AppSessionGuid=0000a8f8-0001-0019-059a-4808ac33d801
TargetAppId=W:0006d9d0fa9ade2638f89a299a0521443a1700000904!000000043a52331817c373ab964a244844c295fa2e5b!Sigil.exe
TargetAppVer=2022//03//07:20:54:43!6272f6!Sigil.exe
BootId=4294967295
TargetAsId=114260
UserImpactVector=808452912
IsFatal=1
EtwNonCollectReason=1
Response.BucketId=0d62cbf8c55a1203f9090a5aa07e07c0
Response.BucketTable=4
Response.LegacyBucketId=1803984510094542784
Response.type=4
Sig[0].Name=Application Name
Sig[0].Value=Sigil.exe
Sig[1].Name=Application Version
Sig[1].Value=1.9.1.0
Sig[2].Name=Application Timestamp
Sig[2].Value=62267113
Sig[3].Name=Fault Module Name
Sig[3].Value=Qt5Gui.dll
Sig[4].Name=Fault Module Version
Sig[4].Value=5.12.9.0
Sig[5].Name=Fault Module Timestamp
Sig[5].Value=5ef7924e
Sig[6].Name=Exception Code
Sig[6].Value=c00000fd
Sig[7].Name=Exception Offset
Sig[7].Value=00000000003a5348
DynamicSig[1].Name=OS Version
DynamicSig[1].Value=10.0.19043.2.0.0.768.101
DynamicSig[2].Name=Locale ID
DynamicSig[2].Value=3081
DynamicSig[22].Name=Additional Information 1
DynamicSig[22].Value=9861
DynamicSig[23].Name=Additional Information 2
DynamicSig[23].Value=9861e578cc24a204ea4d9e4def4e96a2
DynamicSig[24].Name=Additional Information 3
DynamicSig[24].Value=96aa
DynamicSig[25].Name=Additional Information 4
DynamicSig[25].Value=96aa7e80daf82377e9eb98f90b31b9a1
UI[2]=C:\Program Files\Sigil\Sigil.exe
LoadedModule[0]=C:\Program Files\Sigil\Sigil.exe
LoadedModule[1]=C:\WINDOWS\SYSTEM32\ntdll.dll
LoadedModule[2]=C:\WINDOWS\System32\KERNEL32.DLL
LoadedModule[3]=C:\WINDOWS\System32\KERNELBASE.dll
LoadedModule[4]=C:\WINDOWS\System32\USER32.dll
LoadedModule[5]=C:\WINDOWS\System32\win32u.dll
LoadedModule[6]=C:\WINDOWS\System32\GDI32.dll
LoadedModule[7]=C:\Program Files\Sigil\Qt5WebEngineWidgets.dll
LoadedModule[8]=C:\WINDOWS\System32\gdi32full.dll
LoadedModule[9]=C:\WINDOWS\System32\msvcp_win.dll
LoadedModule[10]=C:\WINDOWS\System32\ucrtbase.dll
LoadedModule[11]=C:\WINDOWS\System32\SHELL32.dll
LoadedModule[12]=C:\Program Files\Sigil\Qt5Concurrent.dll
LoadedModule[13]=C:\Program Files\Sigil\python39.dll
LoadedModule[14]=C:\Program Files\Sigil\Qt5WinExtras.dll
LoadedModule[15]=C:\WINDOWS\System32\ole32.dll
LoadedModule[16]=C:\WINDOWS\System32\RPCRT4.dll
LoadedModule[17]=C:\WINDOWS\System32\combase.dll
LoadedModule[18]=C:\WINDOWS\System32\WS2_32.dll
LoadedModule[19]=C:\WINDOWS\System32\ADVAPI32.dll
LoadedModule[20]=C:\WINDOWS\System32\msvcrt.dll
LoadedModule[21]=C:\WINDOWS\System32\sechost.dll
LoadedModule[22]=C:\Program Files\Sigil\Qt5PrintSupport.dll
LoadedModule[23]=C:\WINDOWS\System32\COMDLG32.dll
LoadedModule[24]=C:\WINDOWS\System32\shcore.dll
LoadedModule[25]=C:\WINDOWS\System32\SHLWAPI.dll
LoadedModule[26]=C:\Program Files\Sigil\Qt5Widgets.dll
LoadedModule[27]=C:\Program Files\Sigil\Qt5Gui.dll
LoadedModule[28]=C:\Program Files\Sigil\Qt5Core.dll
LoadedModule[29]=C:\WINDOWS\SYSTEM32\MSVCP140.dll
LoadedModule[30]=C:\WINDOWS\SYSTEM32\VCRUNTIME140.dll
LoadedModule[31]=C:\Program Files\Sigil\hunspell.dll
LoadedModule[32]=C:\Program Files\Sigil\Qt5Quick.dll
LoadedModule[33]=C:\Program Files\Sigil\sigilgumbo.dll
LoadedModule[34]=C:\Program Files\Sigil\Qt5Network.dll
LoadedModule[35]=C:\WINDOWS\System32\CRYPT32.dll
LoadedModule[36]=C:\Program Files\Sigil\Qt5QuickWidgets.dll
LoadedModule[37]=C:\WINDOWS\SYSTEM32\VERSION.dll
LoadedModule[38]=C:\WINDOWS\SYSTEM32\dwmapi.dll
LoadedModule[39]=C:\WINDOWS\SYSTEM32\WINSPOOL.DRV
LoadedModule[40]=C:\WINDOWS\WinSxS\amd64_microsoft.windows.common-controls_6595b64144ccf1df_5.82.19041.1110_none_792d1c772443f647\COMCTL32.dll
LoadedModule[41]=C:\WINDOWS\SYSTEM32\UxTheme.dll
LoadedModule[42]=C:\WINDOWS\SYSTEM32\MPR.dll
LoadedModule[43]=C:\WINDOWS\SYSTEM32\NETAPI32.dll
LoadedModule[44]=C:\WINDOWS\SYSTEM32\USERENV.dll
LoadedModule[45]=C:\WINDOWS\SYSTEM32\WINMM.dll
LoadedModule[46]=C:\WINDOWS\SYSTEM32\VCRUNTIME140_1.dll
LoadedModule[47]=C:\Program Files\Sigil\Qt5Qml.dll
LoadedModule[48]=C:\WINDOWS\SYSTEM32\DNSAPI.dll
LoadedModule[49]=C:\WINDOWS\SYSTEM32\IPHLPAPI.DLL
LoadedModule[50]=C:\WINDOWS\SYSTEM32\SRVCLI.DLL
LoadedModule[51]=C:\WINDOWS\SYSTEM32\NETUTILS.DLL
LoadedModule[52]=C:\WINDOWS\SYSTEM32\CRYPTBASE.DLL
LoadedModule[53]=C:\Program Files\Sigil\Qt5WebEngineCore.dll
LoadedModule[54]=C:\WINDOWS\System32\OLEAUT32.dll
LoadedModule[55]=C:\WINDOWS\System32\PSAPI.DLL
LoadedModule[56]=C:\Program Files\Sigil\Qt5WebChannel.dll
LoadedModule[57]=C:\WINDOWS\SYSTEM32\dbghelp.dll
LoadedModule[58]=C:\Program Files\Sigil\Qt5Positioning.dll
LoadedModule[59]=C:\WINDOWS\SYSTEM32\USP10.dll
LoadedModule[60]=C:\WINDOWS\SYSTEM32\dhcpcsvc.DLL
LoadedModule[61]=C:\WINDOWS\SYSTEM32\ncrypt.dll
LoadedModule[62]=C:\WINDOWS\SYSTEM32\urlmon.dll
LoadedModule[63]=C:\WINDOWS\SYSTEM32\WINHTTP.dll
LoadedModule[64]=C:\WINDOWS\SYSTEM32\DWrite.dll
LoadedModule[65]=C:\WINDOWS\SYSTEM32\Secur32.dll
LoadedModule[66]=C:\WINDOWS\SYSTEM32\msdmo.dll
LoadedModule[67]=C:\WINDOWS\SYSTEM32\dxgi.dll
LoadedModule[68]=C:\WINDOWS\SYSTEM32\d3d11.dll
LoadedModule[69]=C:\WINDOWS\SYSTEM32\d3d9.dll
LoadedModule[70]=C:\WINDOWS\SYSTEM32\iertutil.dll
LoadedModule[71]=C:\WINDOWS\SYSTEM32\kernel.appcore.dll
LoadedModule[72]=C:\WINDOWS\SYSTEM32\HID.DLL
LoadedModule[73]=C:\WINDOWS\SYSTEM32\windows.storage.dll
LoadedModule[74]=C:\WINDOWS\SYSTEM32\dxva2.dll
LoadedModule[75]=C:\WINDOWS\SYSTEM32\Wldp.dll
LoadedModule[76]=C:\WINDOWS\SYSTEM32\SSPICLI.DLL
LoadedModule[77]=C:\WINDOWS\System32\IMM32.DLL
LoadedModule[78]=C:\WINDOWS\System32\NSI.dll
LoadedModule[79]=C:\WINDOWS\SYSTEM32\NTASN1.dll
LoadedModule[80]=C:\WINDOWS\System32\bcryptPrimitives.dll
LoadedModule[81]=C:\Program Files\Sigil\platforms\qwindows.dll
LoadedModule[82]=C:\WINDOWS\SYSTEM32\WTSAPI32.dll
LoadedModule[83]=C:\Program Files (x86)\Sizer\hook64.dll
LoadedModule[84]=C:\WINDOWS\SYSTEM32\profapi.dll
LoadedModule[85]=C:\WINDOWS\System32\bcrypt.dll
LoadedModule[86]=C:\WINDOWS\SYSTEM32\opengl32.dll
LoadedModule[87]=C:\WINDOWS\SYSTEM32\GLU32.dll
LoadedModule[88]=C:\WINDOWS\System32\MSCTF.dll
LoadedModule[89]=C:\WINDOWS\System32\clbcatq.dll
LoadedModule[90]=C:\Windows\System32\AppXDeploymentClient.dll
LoadedModule[91]=C:\WINDOWS\SYSTEM32\ig8icd64.dll
LoadedModule[92]=C:\WINDOWS\SYSTEM32\igdusc64.dll
LoadedModule[93]=C:\WINDOWS\SYSTEM32\dxcore.dll
LoadedModule[94]=C:\WINDOWS\System32\cfgmgr32.dll
LoadedModule[95]=C:\WINDOWS\SYSTEM32\powrprof.dll
LoadedModule[96]=C:\WINDOWS\SYSTEM32\UMPDC.dll
LoadedModule[97]=C:\Program Files\Sigil\styles\qwindowsvistastyle.dll
LoadedModule[98]=C:\WINDOWS\SYSTEM32\CRYPTSP.dll
LoadedModule[99]=C:\WINDOWS\system32\rsaenh.dll
LoadedModule[100]=C:\WINDOWS\system32\NLAapi.dll
LoadedModule[101]=C:\WINDOWS\SYSTEM32\dhcpcsvc6.DLL
LoadedModule[102]=C:\WINDOWS\SYSTEM32\mscms.dll
LoadedModule[103]=C:\WINDOWS\SYSTEM32\ColorAdapterClient.dll
LoadedModule[104]=C:\WINDOWS\SYSTEM32\icm32.dll
LoadedModule[105]=C:\WINDOWS\system32\audioses.dll
LoadedModule[106]=C:\WINDOWS\system32\MMDevAPI.DLL
LoadedModule[107]=C:\WINDOWS\system32\DEVOBJ.dll
LoadedModule[108]=C:\WINDOWS\System32\SETUPAPI.dll
LoadedModule[109]=C:\WINDOWS\System32\WINTRUST.dll
LoadedModule[110]=C:\WINDOWS\SYSTEM32\MSASN1.dll
LoadedModule[111]=C:\WINDOWS\system32\mf.dll
LoadedModule[112]=C:\WINDOWS\system32\mfplat.dll
LoadedModule[113]=C:\WINDOWS\system32\RTWorkQ.DLL
LoadedModule[114]=C:\WINDOWS\system32\mfreadwrite.dll
LoadedModule[115]=C:\WINDOWS\system32\MFCaptureEngine.dll
LoadedModule[116]=C:\Windows\System32\mfh264enc.dll
LoadedModule[117]=C:\WINDOWS\system32\CompPkgSup.DLL
LoadedModule[118]=C:\Windows\System32\Windows.Media.dll
LoadedModule[119]=C:\Windows\System32\Windows.ApplicationModel.dll
LoadedModule[120]=C:\Windows\System32\twinapi.appcore.dll
LoadedModule[121]=C:\Program Files\Sigil\python3.DLL
LoadedModule[122]=C:\Program Files\Sigil\DLLs\_socket.pyd
LoadedModule[123]=C:\Program Files\Sigil\DLLs\select.pyd
LoadedModule[124]=C:\Program Files\Sigil\DLLs\unicodedata.pyd
LoadedModule[125]=C:\WINDOWS\system32\mswsock.dll
LoadedModule[126]=C:\Program Files\Sigil\DLLs\_hashlib.pyd
LoadedModule[127]=C:\Program Files\Sigil\DLLs\libcrypto-1_1.dll
LoadedModule[128]=C:\Program Files\Sigil\DLLs\_ssl.pyd
LoadedModule[129]=C:\Program Files\Sigil\DLLs\libssl-1_1.dll
LoadedModule[130]=C:\Program Files\Sigil\DLLs\_bz2.pyd
LoadedModule[131]=C:\Program Files\Sigil\DLLs\_lzma.pyd
LoadedModule[132]=C:\Windows\System32\rasadhlp.dll
LoadedModule[133]=C:\WINDOWS\System32\fwpuclnt.dll
LoadedModule[134]=C:\Program Files\Sigil\iconengines\qsvgicon.dll
LoadedModule[135]=C:\Program Files\Sigil\Qt5Svg.dll
LoadedModule[136]=C:\Program Files\Sigil\imageformats\qsvg.dll
LoadedModule[137]=C:\Windows\System32\appresolver.dll
LoadedModule[138]=C:\Windows\System32\Bcp47Langs.dll
LoadedModule[139]=C:\Windows\System32\SLC.dll
LoadedModule[140]=C:\Windows\System32\sppc.dll
LoadedModule[141]=C:\WINDOWS\system32\propsys.dll
LoadedModule[142]=C:\WINDOWS\System32\coml2.dll
LoadedModule[143]=C:\WINDOWS\SYSTEM32\LINKINFO.dll
LoadedModule[144]=C:\WINDOWS\SYSTEM32\ntmarta.dll
LoadedModule[145]=C:\Windows\System32\TaskFlowDataEngine.dll
LoadedModule[146]=C:\WINDOWS\SYSTEM32\wintypes.dll
LoadedModule[147]=C:\Windows\System32\cdp.dll
LoadedModule[148]=C:\Windows\System32\dsreg.dll
LoadedModule[149]=C:\Windows\System32\msvcp110_win.dll
LoadedModule[150]=C:\Windows\System32\OneCoreCommonProxyStub.dll
LoadedModule[151]=C:\Program Files\Sigil\imageformats\qdds.dll
LoadedModule[152]=C:\Program Files\Sigil\imageformats\qgif.dll
LoadedModule[153]=C:\Program Files\Sigil\imageformats\qicns.dll
LoadedModule[154]=C:\Program Files\Sigil\imageformats\qico.dll
LoadedModule[155]=C:\Program Files\Sigil\imageformats\qjp2.dll
LoadedModule[156]=C:\WINDOWS\SYSTEM32\MSVCP120.dll
LoadedModule[157]=C:\WINDOWS\SYSTEM32\MSVCR120.dll
LoadedModule[158]=C:\Program Files\Sigil\imageformats\qjpeg.dll
LoadedModule[159]=C:\Program Files\Sigil\imageformats\qmng.dll
LoadedModule[160]=C:\Program Files\Sigil\imageformats\qtga.dll
LoadedModule[161]=C:\Program Files\Sigil\imageformats\qtiff.dll
LoadedModule[162]=C:\Program Files\Sigil\imageformats\qwbmp.dll
LoadedModule[163]=C:\Program Files\Sigil\imageformats\qwebp.dll
LoadedModule[164]=C:\WINDOWS\WinSxS\amd64_microsoft.windows.common-controls_6595b64144ccf1df_6.0.19041.1110_none_60b5254171f9507e\comctl32.dll
LoadedModule[165]=C:\WINDOWS\SYSTEM32\WindowsCodecs.dll
LoadedModule[166]=C:\Windows\System32\thumbcache.dll
LoadedModule[167]=C:\WINDOWS\SYSTEM32\policymanager.dll
LoadedModule[168]=C:\Program Files\Sigil\DLLs\_elementtree.pyd
LoadedModule[169]=C:\Program Files\Sigil\DLLs\pyexpat.pyd
LoadedModule[170]=C:\Program Files\Sigil\Lib\site-packages\lxml\etree.cp39-win_amd64.pyd
LoadedModule[171]=C:\Program Files\Sigil\Lib\site-packages\lxml\_elementpath.cp39-win_amd64.pyd
LoadedModule[172]=C:\WINDOWS\SYSTEM32\edputil.dll
LoadedModule[173]=C:\WINDOWS\system32\dataexchange.dll
LoadedModule[174]=C:\WINDOWS\system32\dcomp.dll
LoadedModule[175]=C:\WINDOWS\SYSTEM32\textinputframework.dll
LoadedModule[176]=C:\WINDOWS\System32\CoreUIComponents.dll
LoadedModule[177]=C:\WINDOWS\System32\CoreMessaging.dll
LoadedModule[178]=C:\WINDOWS\SYSTEM32\igd10iumd64.dll
LoadedModule[179]=C:\WINDOWS\SYSTEM32\apphelp.dll
LoadedModule[180]=C:\Program Files\Google\Drive File Stream\55.0.3.0\drivefsext.dll
LoadedModule[181]=C:\WINDOWS\SYSTEM32\d2d1.dll
LoadedModule[182]=C:\WINDOWS\SYSTEM32\WININET.dll
LoadedModule[183]=C:\WINDOWS\WinSxS\amd64_microsoft.windows.gdiplus_6595b64144ccf1df_1.1.19041.1348_none_91a2627ccc89e3fb\gdiplus.dll
LoadedModule[184]=C:\Windows\System32\OneCoreUAPCommonProxyStub.dll
LoadedModule[185]=C:\Windows\System32\EhStorShell.dll
State[0].Key=Transport.DoneStage1
State[0].Value=1
OsInfo[0].Key=vermaj
OsInfo[0].Value=10
OsInfo[1].Key=vermin
OsInfo[1].Value=0
OsInfo[2].Key=verbld
OsInfo[2].Value=19043
OsInfo[3].Key=ubr
OsInfo[3].Value=1415
OsInfo[4].Key=versp
OsInfo[4].Value=0
OsInfo[5].Key=arch
OsInfo[5].Value=9
OsInfo[6].Key=lcid
OsInfo[6].Value=2057
OsInfo[7].Key=geoid
OsInfo[7].Value=12
OsInfo[8].Key=sku
OsInfo[8].Value=101
OsInfo[9].Key=domain
OsInfo[9].Value=0
OsInfo[10].Key=prodsuite
OsInfo[10].Value=768
OsInfo[11].Key=ntprodtype
OsInfo[11].Value=1
OsInfo[12].Key=platid
OsInfo[12].Value=10
OsInfo[13].Key=sr
OsInfo[13].Value=0
OsInfo[14].Key=tmsi
OsInfo[14].Value=221518937
OsInfo[15].Key=osinsty
OsInfo[15].Value=3
OsInfo[16].Key=iever
OsInfo[16].Value=11.789.19041.0-11.0.1000
OsInfo[17].Key=portos
OsInfo[17].Value=0
OsInfo[18].Key=ram
OsInfo[18].Value=16261
OsInfo[19].Key=svolsz
OsInfo[19].Value=237
OsInfo[20].Key=wimbt
OsInfo[20].Value=0
OsInfo[21].Key=blddt
OsInfo[21].Value=191206
OsInfo[22].Key=bldtm
OsInfo[22].Value=1406
OsInfo[23].Key=bldbrch
OsInfo[23].Value=vb_release
OsInfo[24].Key=bldchk
OsInfo[24].Value=0
OsInfo[25].Key=wpvermaj
OsInfo[25].Value=0
OsInfo[26].Key=wpvermin
OsInfo[26].Value=0
OsInfo[27].Key=wpbuildmaj
OsInfo[27].Value=0
OsInfo[28].Key=wpbuildmin
OsInfo[28].Value=0
OsInfo[29].Key=osver
OsInfo[29].Value=10.0.19041.1415.amd64fre.vb_release.191206-1406
OsInfo[30].Key=buildflightid
OsInfo[30].Value=52B26023-6AFB-4B98-A9BA-096039A02240.1
OsInfo[31].Key=edition
OsInfo[31].Value=Core
OsInfo[32].Key=ring
OsInfo[32].Value=Retail
OsInfo[33].Key=expid
OsInfo[33].Value=FX:117B9872,FX:1180989E,FX:119E26AD,FX:11A8C293,FX:11A8C2FE,FX:11C0E96C,FX:11C3F9D5,FX:11C6E5C2,FX:11C7EB6A,FX:11C9408A,FX:11C940DB,FX:11C96C7A,FX:11CB9A9F,FX:11CB9AC1,FX:11CC111C,FX:11D5BFCD,FX:11D898D7,FX:11DB147C,FX:1A92E6F
OsInfo[34].Key=fconid
OsInfo[35].Key=containerid
OsInfo[36].Key=containertype
OsInfo[37].Key=edu
OsInfo[37].Value=0
FriendlyEventName=Stopped working
ConsentKey=APPCRASH
AppName=Sigil is a multi-platform EPUB ebook editor
AppPath=C:\Program Files\Sigil\Sigil.exe
NsPartner=windows
NsGroup=windows8
ApplicationIdentity=1AAF5F10399A63B64D675C1AC2B6CDD3
MetadataHash=36998096

I'll also report any sort of crash in the future just for visibility that it happens.

[KevinH]

I think for Windows, when the ctrl-g or ctrl-shift-g shortcuts are received in MainWindow before passing them onto search, we may want to send them to a routine that does nothing and returns quickly, and then pass only new ones on to search once the previous search is complete.

That should prevent any overflow of queued event signals waiting to be delivered and hopefully prevent the stack overflow from happening.

For this to work, MainWindow just needs to know if search is running or not to know how to treat it when it gets the shortcut.

I see a quick way to test this hypothesis. I will push those changes and hopefully people can check to make sure the crashing stops on Windows.

I am building a new test build now to see if it helps prevent the crashing, I will post the link when ready.

[KevinH]

Hi All,

As far as my testing shows, this one seems to fix all of the bugs reported so far. This includes a fix for capture groups \1 being improperly processed when no capture groups in regex.

All of the debug output has been removed so it may react a bit quicker.

And it has a potential "fix" for the ctrl-g (held down) segfault for Windows but whether this really fixes the problem seen remains to be tested.

The test builds can be downloaded from my repo here:

https://github.com/kevinhendricks/Bu...OnMac/releases

- Sigil-master-f2157d4-build_num-378-Mac.tar.xz

- Sigil-master-f2157d4-build_num-378-Win-Setup.exe

Again thanks to everyone who tests and helps make Sigil better!

If you have a Windows box and could create the ctrl-g repeated too quickly crash, please give this test version a try and let me know if it prevents the crash or if the crash still happens just someplace else.

[BeckyEbook]

I confirm – no crash after long press Ctrl-G!

Edit: I also did a private build and it works too!

[KevinH]

Wow that is great news!

Thanks for testing and reporting back.

Originally Posted by BeckyEbook

I confirm – no crash after long press Ctrl-G!

Edit: I also did a private build and it works too!

[DiapDealer]

I've gotten no long-press crtl-g crashes with the latest test version, but this is a different Windows machine from the one where I was able to reproduce the crash consistently.

[KevinH]

The change just drops shortcuts that are delivered when the previous shortcut request had not completed yet. I applied it for all platforms since it can not hurt. If the screen has not updated from the last search yet, another search makes no sense.

Hopefully this will fix it on your other machine as well, it can not hurt!

[PapaKilo]

Originally Posted by KevinH

No that User Preference is always used in CodeView if set. The colour changes are due to active vs inactive palette colours. When using Spellcheck or Saved Searches, those windows always have focus and so CodeView is inactive as it uses inactive palette colours to indicate that.

As for selecting the next word, that does happen but only when the "All Words" checkbox is not checked. If only showing misspelled words, once that word is corrected it is removed from the list advancing the selection. When the "all words" is selected, fixing a misspelled word does not advance anything.

In addition, the search for the selected word automatically with a single click is gone and has been fow a few releases now as it tremendously slowed down spell checking when huge word lists (huge epubs) are being used (the search for the next instance in the text took too long making hopping around too slow). That is now expected behaviour. Double-clicking now forces the search to be done if you really need to see context.

This hopping around delay is pretty much unnoticeable in short epubs/word lists butwas intolerable in very large epubs, thus the change.

Thanks for testing and confirming your issue was fixed. These fixes will appear in the upcoming Sigil-1.9.2 follow-on release that will hopefully be out soon.

Like I said it was a minor issue.

However, I went back to a previous version (1.3) and did spellcheck and saved searches and both of them used the highlight color displayed in the CV because that version put the CV in focus and didn't keep focus themselves.

Paul

[PapaKilo]

Originally Posted by PapaKilo

Like I said it was a minor issue.

However, I went back to a previous version (1.3) and did spellcheck and saved searches and both of them used the highlight color displayed in the CV because that version put the CV in focus and didn't keep focus themselves.

Paul

Actually that was an incorrect statement.

Find & Replace Spellcheck and Saved Searches all kept focus. But they displayed the found item in the CV using the line highlight color.

Spellcheck highlights the line and the incorrect spelled word on a "single click".

Paul

[KevinH]

Just to be clear.

The different line highlight in CodeView due to focus came in Sigil-1.5 to make focus difference visually clearer.

And the change to need double-click to sync Spellcheck word in CodeView came in Sigil-1.7 to make hopping around and paging very long lists of much words faster.

So both are changes not bugs (minor or otherwise) and they work as expected and have been that way for a couple of releases over the past year or more.

Kevin

Originally Posted by PapaKilo

Actually that was an incorrect statement.

Find & Replace Spellcheck and Saved Searches all kept focus. But they displayed the found item in the CV using the line highlight color.

Spellcheck highlights the line and the incorrect spelled word on a "single click".

Paul