Suggestions for Sigil Improvements or New Features

[KevinH]

Originally Posted by BeckyEbook

Yes, this is a issue/feature of Qt in Windows.
I even checked it on version 0.9.13 in Windows XP, and it was the same there.

It must be clearly stated that the button should be:

setWindowFlags(windowFlags() | Qt::WindowMinimizeButtonHint);

Hmm, that is something I never knew. Of course I only dabble on Windows and when Linux and Mac both worked, I just assumed it would work on Windows.

I will see about adding that to the Reports code.

Are there any other particular windows in Sigil that would benefit from such a treatment?

[KevinH]

Originally Posted by BeckyEbook

I confirm that the force_titlecase function now works for all files.

Okay I just pushed to master the following addition to functionsearch.py

def create_sigilmatch_copy(m):
    grouplist = []
    n = len(m.groups())
    if  n > 0: n = n + 1
    s = m.start()
    for i in range(n):
        grouplist.append([m.span(i)[0] - s, m.span(i)[1] - s])
    nm = SigilMatch(m.group(0), grouplist)
    return nm

This function makes it much easier to use multiple replace_* functions in a single python function replace function.

With this change the force_titlecase function now simplifies to the following:

def replace(match, number, file_name, metadata, data):
    if match:
        new_match = create_sigilmatch_copy(match)
        new_match.string = replace_lowercase(match, number, file_name, metadata, data)
        return replace_titlecase(new_match, number, file_name, metadata, data)

[BeckyEbook]

Important note: add setWindowsFlags after

ui.setupUi(this);

Other windows to minimize? I really have no idea. I've lived without it for years, so I just don't miss that option. But maybe @philja will suggest something, maybe Spellcheck?

[KevinH]

Originally Posted by BeckyEbook

Important note: add setWindowsFlags after

ui.setupUi(this);

Other windows to minimize? I really have no idea. I've lived without it for years, so I just don't miss that option. But maybe @philja will suggest something, maybe Spellcheck?

Thanks for the important note! I will add that to Reports.cpp along with the maximizebuttonhint as well so both are available just like on Mac and Linux.

So far the list of where to make these changes is:

Reports
Spellcheck

But there are a number of other informational windows that it may be useful for, such as GetInfo, some of the RepoManager windows, and etc.

I had no idea about this difference between platforms.

[DNSB]

So far the changes look good here. I was able to see a slowdown in the character report but that involved preloading an ~16K block of data which was then "typed" into Code View. The delay was about 2 seconds between the two versions of Sigil.

As for the minimize/full screen, much like @BeckyEbook, I don't remember ever seeing them so I never missed them. It is nice to have them now.

[DiapDealer]

I never needed to minimize anything other than the main window on any OS. So I never noticed there being (or not being) a minimize button.

EDIT: It's not just Windows by the way. The 'x' (close) button is the only button visible on any Sigil dialog on my Arch Linux machine using the Cinnamon desktop. I just checked.

[KevinH]

Whereas on Manjaro under KDE Plasma 6, I get both the min and max buttons on the Reports window title bar.

[KevinH]

Originally Posted by BeckyEbook

This is intentionally limited to commonly used Latin-based European characters (PL, CZ, SK, SI, HR, LT, LV, EE, DE, AT, CH, FR, ES, PT, IT, NO, SE, DK, FI, NL, HU, RO).
Non-Latin scripts (CJK, RTL, etc.) are deliberately excluded and will continue to fall back to Python on demand.

static const QString XHTML_CHARS =
    "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ"
    "1234567890!@#$%^&*()_-+={}[]:;\"'<>,.?/|\\…„”“’»«"
    "ąćęłńóśżźĄĆĘŁŃÓŚŻŹáàâäãåÁÀÂÄÃÅéèêëÉÈÊËíìîïÍÌÎÏ"
    "òôöõøÓÒÔÖÕØúùûüÚÙÛÜýÿÝŸçÇñÑšžŠŽđĐœæŒÆß";

P.S. I also added some punctuation marks.

Wonderful. I will modify CodepointNames.cpp to pre-cache those as well.