Koreader on H2O Edition 2 (H2O2)

[bandario]

Only thing that doesn't work with the original files for me is pinch to zoom, but i'm not sure if that was ever a feature of KOReader.

[Frenzie]

@Ken
With pan I mean dragging a file around in scroll mode.

Anyway, it won't be as simple as just the input.lua changes, see here. I'm surprised to hear it works on the Aura HD and not on the Glo HD though.

@bandario
It's a KOReader feature, but hardware-wise it's only a feature on select Kobo models (only Glo?). Or actually that's not quite true, see here. The hardware supports it, but the kernel doesn't expose it. Perhaps because Kobo deemed the multitouch on the hardware of insufficient quality. Anyway, so with a custom kernel it might work.

If you mean that the H2Ov2 does multitouch in Nickel then some kind of workaround must be possible. This is basically the one area where Android isn't frustrating compared to Kobo: it emits standard multitouch events.

[cola]

Yes, I agree. I thought I still needed to have touchAlyssumProtocol because it sets ev.time = TimeVal:now(), but now that I look at it again I think it's redundant.

I think this patch is basically how I want it to be, but I haven't run it! So there's probably some dumb syntax error in there or some other problem.

Spoiler:

diff -U 3 -r koreader/frontend/device/input.lua koreader2/frontend/device/input.lua
--- koreader/frontend/device/input.lua	2018-02-12 02:36:04.000000000 -0500
+++ koreader2/frontend/device/input.lua	2018-03-01 15:21:21.631488838 -0500
@@ -411,10 +411,32 @@
         if ev.code == SYN_REPORT then
             for _, MTSlot in pairs(self.MTSlots) do
                 self:setMtSlot(MTSlot.slot, "timev", TimeVal:new(ev.time))
+                if self.snow_protocol then
+                    -- if a slot appears in the current touch event, clear "unused"
+                    self:setMtSlot(MTSlot.slot, "unused", nil) 
+                end
+            end
+            if self.snow_protocol then
+                -- reset every slot that doesn't appear in the current touch event
+                -- (because on the H2O2, this is the only way we detect finger-up)
+                self.MTSlots = {}
+                for _, slot in pairs(self.ev_slots) do
+                    table.insert(self.MTSlots, slot)
+                    if slot.unused then
+                        slot.id = -1
+                        slot.timev = TimeVal:new(ev.time)
+                    end
+                end
             end
             -- feed ev in all slots to state machine
             local touch_ges = self.gesture_detector:feedEvent(self.MTSlots)
             self.MTSlots = {}
+            if self.snow_protocol then
+                -- go through all the ev_slots and set them to unused
+                for _, slot in pairs(self.ev_slots) do
+                    slot.unused = true
+                end
+            end
             if touch_ges then
                 self:gestureAdjustHook(touch_ges)
                 return Event:new("Gesture",
diff -U 3 -r koreader/frontend/device/kobo/device.lua koreader2/frontend/device/kobo/device.lua
--- koreader/frontend/device/kobo/device.lua	2018-02-12 02:36:04.000000000 -0500
+++ koreader2/frontend/device/kobo/device.lua	2018-03-01 15:21:34.948594206 -0500
@@ -104,7 +104,8 @@
 local KoboSnow = Kobo:new{
     model = "Kobo_snow",
     hasFrontlight = yes,
-    touch_alyssum_protocol = true,
+    touch_snow_protocol = true,
+    touch_mirrored_x = false,
     touch_probe_ev_epoch_time = true,
     display_dpi = 265,
     -- the bezel covers the top 11 pixels:
@@ -296,6 +297,10 @@
         self.input:registerEventAdjustHook(adjustTouchAlyssum)
     end
 
+    if self.touch_snow_protocol then
+        self.input.snow_protocol = true
+    end
+
     if self.touch_probe_ev_epoch_time then
         self.input:registerEventAdjustHook(function(_, ev)
             probeEvEpochTime(_, ev)

[Frenzie]

Yes, that's basically what I was thinking for now.

[Ken Maltby]

Just a point to keep in mind, I am still using older v3.05 Kobo firmware. The GloHD having some multitouch was a surprise. Strange that the GlowHD would loose touch altogether, though.

Luck;
Ken

[gilali]

Hello,

Natural light is also supported on H2O2. Here's the settings :

frontend/device/kobo/device.lua, add hasNaturalLight = yes, like this

-- Kobo Aura H2O2:
local KoboSnow = Kobo:new{
    model = "Kobo_snow",
    hasFrontlight = yes,
    hasNaturalLight = yes,

AND modify frontend/device/kobo/sysfs_light.lua (

    frontlight_white = "/sys/class/backlight/lm3630a_led1b",
    frontlight_red = "/sys/class/backlight/lm3630a_led1a",
    frontlight_green = "/sys/class/backlight/lm3630a_ledb",

to this :

    frontlight_white = "/sys/class/backlight/lm3630a_ledb",
    frontlight_red = "/sys/class/backlight/lm3630a_led",
    frontlight_green = "/sys/class/backlight/lm3630a_leda",

And the new "two-column gesture control" feature works nice too.

[Frenzie]

Originally Posted by cola

I think this patch is basically how I want it to be, but I haven't run it! So there's probably some dumb syntax error in there or some other problem.

Do you want to put it in a PR?

[Frenzie]

Could you guys with an H2Ov2 please confirm all's more or less working as it should with the latest nightly build? At the time of writing that's http://build.koreader.rocks/download...1546-gd0130ae/

[gilali]

Upside down patch is missing on this release. So touching is inverted.
But when applyed : touching OK, natural light : OK
(tested on KSM08)

[boriar]

Originally Posted by Frenzie

It's a KOReader feature, but hardware-wise it's only a feature on select Kobo models (only Glo?). Or actually that's not quite true, see here. The hardware supports it, but the kernel doesn't expose it. Perhaps because Kobo deemed the multitouch on the hardware of insufficient quality. Anyway, so with a custom kernel it might work.

About multitouch kernel. I remember, when my H2O was in 3.12.1 use the patch for it (the same you link before) and worked like a charm. I haven't tried with all 4.x FW because I don't know if there's too much changes from these old days in the original kernel. I will try the next weekend

[Frenzie]

Do you have the latest KSM? https://www.mobileread.com/forums/sh...d.php?t=293804 It should take care of that by setting something like this in kbmenu/onstart/start_koreader.sh

  if [ "$PRODUCT" == "snow" ]; then
    koreaderrotate=2

[gilali]

With KSM 09 update001, and koreader 1546-gd0130ae
Screen is not inverted : OK
touching OK
natural light : OK

Release is OK, thank you

[Frenzie]

Alright, all that's left now then is the sdcv issue. Although I don't necessarily have to fix that for a new "stable" release I suppose since I could manually replace the file in the archive.

[gilali]

And Evernote #3600 fixed with the same method

[Frenzie]

Heh, not sure what's going on there or how to test (yeah, yeah, make an account, yada yada :P) but I suppose.