Why did Add Existing Files Dialog UI change? - Page 4

DNSB · Yesterday, 01:34 PM

The image/text preview is working for me. However I now find it rather humorous that I can see previews of svg files when adding them but not when clicking on the filename in Images after it is imported.

KevinH · Yesterday, 01:35 PM

To make testing simpler, I added the ability to change theme dark vs light on the fly, and then pushed it with deploy.

So hopefully, it will build a second round of testing versions that I can post.

BeckyEbook · Yesterday, 01:36 PM

@DNSB: I paid attention to that too!
The view of SVG is in the "Insert File" window, but not when you double-click the SVG file in BookBrowser.

KevinH · Yesterday, 01:43 PM

Quote:

Originally Posted by DNSB

The image/text preview is working for me. However I now find it rather humorous that I can see previews of svg files when adding them but not when clicking on the filename in Images after it is imported.

After it is imported, since an svg file is an xml file it defaults to being loaded into CodeView so you can edit it.

You should be able to see the svg image preview when you use the "Insert Image" but I typically add an "Open With" to see it in my preferred browser, or Inkscape if that is available on your platform for more serious editing.

If that bothers people, we can look into showing the svg via a BookBrowser context pop-up menu.

DiapDealer · Yesterday, 01:54 PM

The new stuff works great on Windows! The text preview is much more legible and on-the-fly palette changes are aesthetically pleasing. Thanks! I'm not near my linux machine right now, but I wouldn't expect any trouble there.

DNSB · Yesterday, 02:05 PM

Quote:

Originally Posted by KevinH

You should be able to see the svg image preview when you use the "Insert Image" but I typically add an "Open With" to see it in my preferred browser, or Inkscape if that is available on your platform for more serious editing.

I've used Inkscape and occasionally GIMP for working with SVG images but neither seems to work from Open With on my Windows 11 machine. Most of the svg images I've dealt with are small logos and giving a filename that indicates the contents is enough on most occasions (bookbub_logo.svg instead of 0017_image_<isbn13number>.svg for instance).

Quote:

Originally Posted by KevinH

If that bothers people, we can look into showing the svg via a BookBrowser context pop-up menu.

Would be handy on a few occasions.

Edit: just tried on a compile of the latest code and GIMP now opens but Run Inkscape!.bat still does not open. However running Inkscape.exe does work.

DiapDealer · Yesterday, 02:19 PM

Quote:

Originally Posted by DNSB

Edit: just tried on a compile of the latest code and GIMP now opens but Run Inkscape!.bat still does not open. However running Inkscape.exe does work.

I did a lot work a long time ago to make sure .bat and .cmd files could be used in conjunction with the "Open With" feature of Sigil on Windows. Maybe it's something specific to that particular .bat file, or maybe something has broken since then (I'm looking at you, Windows 11). I admit that I'm usually the one who created the batch scripts I was using to test that feature with. Is that batch file doing anything unusually complex? The batch file (or exe for that matter) needs to accept a path (to the file to open) as a parameter for things to work.

I can make a Windows build that will spit out some useful debug info when launching external programs/scripts if interested.

KevinH · Yesterday, 02:32 PM

For others interested, I have made new "testing2" binaries available of current master here:

https://github.com/kevinhendricks/Bu...nMac/releases/

KevinH · Yesterday, 03:37 PM

Regarding a quick way to view but not edit svg files ...

Quote:

Would be handy on a few occasions.

If you pull from master now and rebuild ...

In BookBrowser under the context popup menu for Image Resources, you should now see a "View Image" menu item that will allow a user to generate a fast non-modal viewer for an image (both svg and regular images) to pop up.

I have also added extended the View Image content menu in CodeView when editing xhtml and when your cursor on an img src attribute, you can launch the same image viewer (this already worked for regular images but now works for svg as well).

When you get a free moment, give it a try and let me know if this is useful.

DiapDealer · Yesterday, 04:27 PM

I'm seeing the View Image context menu item in Code View and it opens fine. But I'm not seeing a context menu item for View Image in Book Browser when right-clicking on an image resource. This is on Linux.

The first opening of the dialog was a tiny box that opened outside of Sigil's main Window. I almost didn't see it. It retained it's size/position on subsequent opens, though.

KevinH · Yesterday, 04:36 PM

Hmm ... no menu item in the BookBrowser context menu for an image is strange.
On my MacOS machine, it is there. And yes the Image Viewer is a non-modal viewer window that pops up outside the MainWindow and floats. It is meant to give users a fast peek without the need to open a new Tab.

I will try a pull and build on my Manjaro box to see.

KevinH · Yesterday, 04:53 PM

Okay, I pulled from Sigil master on my Manjaro Linux box and did a clean rebuild.

I opened our user guide as it has png and a few svgs in it.

I was able to highlight an image in BookBrowser under Images and right click and "View Image" was in the menu. It all worked but the first time with an svg it opened up a tiny window whose size had to be adjusted. But opening regular images and other svg images all worked fine after that.

Not sure why you are not seeing it. I had to add a signal to BookBrowser.h so perhaps a clean rebuild is needed?

DiapDealer · Yesterday, 05:14 PM

I tried a clean rebuild already. No luck. I'll keep investigating.

KevinH · Yesterday, 05:20 PM

Wow, it is towards the bottom of the pop-up menu with exact text "View Image". The changes that add that should be in BookBrowser.cpp.

See https://github.com/Sigil-Ebook/Sigil...f9f3b29c466442

DiapDealer · Yesterday, 05:47 PM

Suddenly it's working. I have no idea what kind of brainfart I must've been having. I was careful about building from scratch. Careful about where I was installing. And careful about making sure which binary I was using to launch, but the menu item just wasn't there. I tried a few more times and it suddenly was. I've got no idea.

Anyway... it works! Nothing to see here.

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
Problem with add existing files 2.6.0	jwes	Sigil	5	07-28-2025 03:05 PM
calibre - Not using existing metadata from *.opf files when Add books	rolandt99	Library Management	19	06-15-2020 04:43 PM
File name syntax change, existing files?	martienne	Library Management	5	02-09-2014 08:48 AM
Crashes when attempting to add existing files to images	BooksToGo	Sigil	3	10-01-2013 06:17 AM
Sigil crashes when Add Existing Files.	frichrdsn	Sigil	2	05-28-2013 06:35 PM

Yesterday, 01:34 PM	#46
DNSB Bibliophagist Posts: 46,564 Karma: 169115148 Join Date: Jul 2010 Location: Vancouver Device: Kobo Sage, Libra Colour, Lenovo M8 FHD, Paperwhite 4, Tolino epos	The image/text preview is working for me. However I now find it rather humorous that I can see previews of svg files when adding them but not when clicking on the filename in Images after it is imported.

Yesterday, 01:35 PM	#47
KevinH Sigil Developer Posts: 8,837 Karma: 6120478 Join Date: Nov 2009 Device: many	To make testing simpler, I added the ability to change theme dark vs light on the fly, and then pushed it with deploy. So hopefully, it will build a second round of testing versions that I can post.

Yesterday, 01:36 PM	#48
BeckyEbook Guru Posts: 849 Karma: 3341026 Join Date: Jan 2017 Location: Poland Device: Various	@DNSB: I paid attention to that too! The view of SVG is in the "Insert File" window, but not when you double-click the SVG file in BookBrowser.

Yesterday, 01:54 PM	#50
DiapDealer Grand Sorcerer Posts: 28,643 Karma: 204624552 Join Date: Jan 2010 Device: Nexus 7, Kindle Fire HD	The new stuff works great on Windows! The text preview is much more legible and on-the-fly palette changes are aesthetically pleasing. Thanks! I'm not near my linux machine right now, but I wouldn't expect any trouble there.

Yesterday, 02:32 PM	#53
KevinH Sigil Developer Posts: 8,837 Karma: 6120478 Join Date: Nov 2009 Device: many	For others interested, I have made new "testing2" binaries available of current master here: https://github.com/kevinhendricks/Bu...nMac/releases/

Yesterday, 04:27 PM	#55
DiapDealer Grand Sorcerer Posts: 28,643 Karma: 204624552 Join Date: Jan 2010 Device: Nexus 7, Kindle Fire HD	I'm seeing the View Image context menu item in Code View and it opens fine. But I'm not seeing a context menu item for View Image in Book Browser when right-clicking on an image resource. This is on Linux. The first opening of the dialog was a tiny box that opened outside of Sigil's main Window. I almost didn't see it. It retained it's size/position on subsequent opens, though.

Yesterday, 04:36 PM	#56
KevinH Sigil Developer Posts: 8,837 Karma: 6120478 Join Date: Nov 2009 Device: many	Hmm ... no menu item in the BookBrowser context menu for an image is strange. On my MacOS machine, it is there. And yes the Image Viewer is a non-modal viewer window that pops up outside the MainWindow and floats. It is meant to give users a fast peek without the need to open a new Tab. I will try a pull and build on my Manjaro box to see.

Yesterday, 04:53 PM	#57
KevinH Sigil Developer Posts: 8,837 Karma: 6120478 Join Date: Nov 2009 Device: many	Okay, I pulled from Sigil master on my Manjaro Linux box and did a clean rebuild. I opened our user guide as it has png and a few svgs in it. I was able to highlight an image in BookBrowser under Images and right click and "View Image" was in the menu. It all worked but the first time with an svg it opened up a tiny window whose size had to be adjusted. But opening regular images and other svg images all worked fine after that. Not sure why you are not seeing it. I had to add a signal to BookBrowser.h so perhaps a clean rebuild is needed?

Yesterday, 05:14 PM	#58
DiapDealer Grand Sorcerer Posts: 28,643 Karma: 204624552 Join Date: Jan 2010 Device: Nexus 7, Kindle Fire HD	I tried a clean rebuild already. No luck. I'll keep investigating.

Yesterday, 05:20 PM	#59
KevinH Sigil Developer Posts: 8,837 Karma: 6120478 Join Date: Nov 2009 Device: many	Wow, it is towards the bottom of the pop-up menu with exact text "View Image". The changes that add that should be in BookBrowser.cpp. See https://github.com/Sigil-Ebook/Sigil...f9f3b29c466442

Advert

Advert

Yesterday, 05:47 PM	#60
DiapDealer Grand Sorcerer Posts: 28,643 Karma: 204624552 Join Date: Jan 2010 Device: Nexus 7, Kindle Fire HD	Suddenly it's working. I have no idea what kind of brainfart I must've been having. I was careful about building from scratch. Careful about where I was installing. And careful about making sure which binary I was using to launch, but the menu item just wasn't there. I tried a few more times and it suddenly was. I've got no idea. Anyway... it works! Nothing to see here.