kobopatch - A new (WIP) patching system

[jackie_w]

Originally Posted by geek1011

As for the extra dot, that does not make a difference in the extraction, as it means the current directory. If it bothers you, I can remove it though.

But would it have fouled up my Kobo if I'd actually copied it over to install the patches? I don't have the skills to rebuild a bricked device from an SD image.

I guess I'm saying 'it bothers me' - unless enough knowledgeable people (excluding yourself) tell me to stop worrying

[geek1011]

Originally Posted by jackie_w

But would it have fouled up my Kobo if I'd actually copied it over to install the patches? I don't have the skills to rebuild a bricked device from an SD image.

I guess I'm saying 'it bothers me' - unless enough knowledgeable people (excluding yourself) tell me to stop worrying

It will not foul up your kobo (because the official update tgz uses the dot too, and even if it didn't, the worst it could do is create a whole bunch of useless files in a dir named .), but I still would not recommend trying it right now, as I'm still having issues with consistency of the generated tgz.

[geek1011]

Originally Posted by jackie_w

Here's my patched KoboRoot.tgz The file was too big to be renamed as a .txt for MR so I've renamed it as a .zip

OK. I think that confirms the issue I think oren and you are having. It is most likely to kobopatch generating a POSIX tar rather than a GNU tar. I will probably be able to fix this for the next version.

[tshering]

Originally Posted by jackie_w

But would it have fouled up my Kobo if I'd actually copied it over to install the patches? I don't have the skills to rebuild a bricked device from an SD image.

I guess I'm saying 'it bothers me' - unless enough knowledgeable people (excluding yourself) tell me to stop worrying

No need to worry. If you check the original kobo firmware update archives, you can see that they do have the dot folder.

Note: I refer only to the directory structure.

[jackie_w]

Originally Posted by tshering

No need to worry. If you check the original kobo firmware update archives, you can see that they do have the dot folder.

Note: I refer only to the directory structure.

Thank you for that. I drilled down an original kobo firmware .zip and see that the \. directory does indeed exist there as well.

I feel better now

[dmapr]

Originally Posted by geek1011

I've implemented a new instruction for the new patch format: FindReplaceString.

An example:
Instead of:

- FindBaseAddress: "ReadingFooter {\n  qproperty-footerMargin: 105;\n}\n"
- ReplaceString: {Offset: 0x0, Find: "ReadingFooter {\n  qproperty-footerMargin: 105;\n}\n", Replace: "ReadingFooter {min-height:15px;max-height:15px;}\n"}

You can do:

- FindReplaceString: {Find: "ReadingFooter {\n  qproperty-footerMargin: 105;\n}\n", Replace: "ReadingFooter {min-height:15px;max-height:15px;}\n"}

Sounds good to me, thanks!

[oren64]

Originally Posted by geek1011

I think there were two issues. One is the one I mentioned above, and the other is due to the way I save the output (there may be a race condition).

Can you and jackie_w post the patched KoboRoot.tgz itself so I can try a few things with it (just add .txt to the file extension so you can upload it)?

Okay I will wait until you fix it.

One thing I really like about this patcher is the ability to fold the patches, so I can fold all patches and see them in a small section.
Can you make the "- Enabled: yes/no" visible when I fold the patches.

Also can you add a feature to keep the "- Enabled: yes/no" of patches in a configuration file so when there is a new firmware it will take enabled status from the conf file.
Somthing like:

[conf]
read = yes

[libnickel.so.1.0.0.yaml]
My 10 line spacing values = no
My 24 line spacing values = yes
Custom left & right margins = yes
...
[nickel.yaml]
Disable reading footer = yes
...

[Terisa de morgan]

Originally Posted by oren64

Also can you add a feature to keep the "- Enabled: yes/no" of patches in a configuration file so when there is a new firmware it will take enabled status from the conf file.

I think this would be a very useful addition for every user, not only the patch creators.

[geek1011]

Originally Posted by oren64

Okay I will wait until you fix it.

One thing I really like about this patcher is the ability to fold the patches, so I can fold all patches and see them in a small section.
Can you make the "- Enabled: yes/no" visible when I fold the patches.

Also can you add a feature to keep the "- Enabled: yes/no" of patches in a configuration file so when there is a new firmware it will take enabled status from the conf file.
Somthing like:

[conf]
read = yes

[libnickel.so.1.0.0.yaml]
My 10 line spacing values = no
My 24 line spacing values = yes
Custom left & right margins = yes
...
[nickel.yaml]
Disable reading footer = yes
...

It folds because your code editor supports YAML. I cannot control how it folds though, but I can move the enabled/disabled into a separate file. I will probably do this by having an optional override file so it isn't confusing for users who don't know about it.

As for fixing it, I'll release a fixed version once I have enough info, and once it works, I'll probably take a break for a week or so (I've been quite busy with all the recent kobo stuff like the new hardware, the changes in update URLS for kobo7 devices, kepubify improvements, and this patch tool).

Can you upload your corrupted KoboRoot.tgz (the original file itself, not the contents) so I can inspect it?

[oren64]

Can you upload your corrupted KoboRoot.tgz (the original file itself, not the contents) so I can inspect it?

https://drive.google.com/file/d/1oVz...ew?usp=sharing

[geek1011]

Originally Posted by oren64

https://drive.google.com/file/d/1oVz...ew?usp=sharing

It seems to be OK. Even Google Drive has all 4 files. I'm going to upload a new release which uses GNU-style TARs instead of POSIX ones. It should fix your issue.

[geek1011]

Here it is: https://github.com/geek1011/kobopatc...ses/tag/v0.5.1 . Please try it and tell me whether the tgz is still corrupted.

[oren64]

Same thing, the WinRar only show two files and the KoboRoot.tgz file have different file size every run.

[geek1011]

Originally Posted by oren64

Same thing, the WinRar only show two files and the KoboRoot.tgz file have different file size every run.

OK. I'm going to see if I can figure out why this is happening only on Windows. Which Windows version do you use (so I can test it)?

[oren64]

Originally Posted by geek1011

OK. I'm going to see if I can figure out why this is happening only on Windows. Which Windows version do you use (so I can test it)?

Windows 10 64bit.