[Plugin] Access-Aide - help improve epub accessibility - Page 4

thiago.eec · 02-03-2021, 04:02 PM

Quote:

Originally Posted by thiago.eec

My system:
Windows 10 x64. Sigil 1.4.3. Acces-aide 0.5.1.

No. I'm using the most recent version of both.
No clue about this, then. I'll try it on Linux.

DNSB · 02-03-2021, 04:07 PM

Quote:

Originally Posted by thiago.eec

Attached is a scrambled version of a test case book. But I must say this didn't work with any of the books I tested. I even mended html files, before running the plugin (so, the DOCTYPE wouldn't be a problem).

I did a quick look at the file and there was no DOCTYPE visible. The first code block is prior to the mend while the second is after running mend.

Code:

<?xml version='1.0' encoding='utf-8'?>
<html xmlns="http://www.w3.org/1999/xhtml" xmlns:epub="http://www.idpf.org/2007/ops" lang="pt-BR" xml:lang="pt-BR">
  <head>
    <title></title>

Code:

<?xml version="1.0" encoding="utf-8"?>
<!DOCTYPE html>

<html xmlns="http://www.w3.org/1999/xhtml" xmlns:epub="http://www.idpf.org/2007/ops" lang="pt-BR" xml:lang="pt-BR">
<head>
  <title></title>

Doitsu · 02-03-2021, 04:16 PM

Quote:

Originally Posted by thiago.eec

I'll try it on Linux.

I just tested the plugin with a pre-release version of Sigil 1.5.0 built on 12/23/2020 from master on my Arch Linux machine, and the titles were properly populated with the toc entries.
However, on my 64bit Windows 10 machine, I got the same results as thiago.eec with Sigi 1.4.3.

thiago.eec · 02-03-2021, 04:17 PM

Quote:

Originally Posted by DNSB

I did a quick look at the file and there was no DOCTYPE visible. The first code block is prior to the mend while the second is after running mend.

Yes, I didn't mend it before sending (just cleared the title tags). But I did tested here after mending.

thiago.eec · 02-03-2021, 04:18 PM

Quote:

Originally Posted by Doitsu

I just tested the plugin with a pre-release version of Sigil 1.5.0 built on 12/23/2020 from master on my Arch Linux machine, and the titles were properly populated with the toc entries.
However, on my 64bit Windows 10 machine, I got the same results as thiago.eec with Sigi 1.4.3.

Thanks @Doitsu. Then it seems to be a Windows specific problem.

KevinH · 02-03-2021, 04:24 PM

Wow. I can not think of a change that would impact this plugin only on Windows since Sigil-1.4.3.

But I have so many Sigil builds lying around that my Sigil 1.4.3 on my mac may not be identical to whatever is on the releases page. I will download exactly that version and try the testcase with that exact version just in case it is a generic plugin bug that only exists in 1.4.3.

Quote:

Originally Posted by Doitsu

I just tested the plugin with a pre-release version of Sigil 1.5.0 built on 12/23/2020 from master on my Arch Linux machine, and the titles were properly populated with the toc entries.
However, on my 64bit Windows 10 machine, I got the same results as thiago.eec with Sigi 1.4.3.

KevinH · 02-03-2021, 04:33 PM

Okay, grabbed an official release build of Sigil-1.4.3 for mac from the Official Sigil github releases and wonloaded and installed it and ran Access-Aide on the provided testcase.

On load I had to run Mend to add the Doctypes and then invoked Access-Aide and it did its job correctly.

So something very Windows specific that impacts plugins is happening.

Very strange.

KevinH · 02-03-2021, 04:36 PM

I will ask DiapDealer to investigate this on his Windows build to see if he has any ideas.

Edit:

Passed along the testcase to him and asked DiapDealer to take a look when he gets a chance.

Interestingly enough I could not e-mail the plugin zip code to him as gmail barfed saying it was infected when of course it is just a zip with an executable inside and a bunch of python code. The executable is just to help see svg images in a tk plugin and is not needed.

Hopefully he will be able to track down what the issue is and hopefully fix it in master.

DiapDealer · 02-03-2021, 05:10 PM

I was going to say I was seeing the same thing on Windows, but it looks like I should just skip to seeing why it might work differently on Windows.

KevinH · 02-03-2021, 05:12 PM

Does it fail on master on Windows too?

BeckyEbook · 02-03-2021, 05:25 PM

Yes (Windows 10). I have the build prepared just now and the problem exists.

DiapDealer · 02-03-2021, 05:25 PM

I haven't tried that yet. I was using a version of Sigil (somewhat newer than 1.4.3) that I have on my work laptop in order to give it a quick test.

KevinH · 02-03-2021, 06:07 PM

So the problem may be with the executable as that is pretty much the only Windows specific thing. Perhaps it is causing the plugin to exit abnormally?

BeckyEbook · 02-03-2021, 06:15 PM

No, I see issue.

Code:

apath = os.path.normcase(apath)

For example:
titlemap says "OEBPS/introducao.xhtml",
but the bookpath says "OEBPS/Introducao.xhtml".

Since the bookpath in the titlemap is different than the actual name in the EPUB file – the condition is not met and the title is not inserted.

---
Edit: If the xhtml file name is written in lowercase (e.g. toc.xhtml) then the title is inserted because the bookpath matches the titlemap.

KevinH · 02-03-2021, 06:44 PM

But how does it work on Linux which is fully case sensitive?

02-03-2021, 04:36 PM	#53
KevinH Sigil Developer Posts: 9,070 Karma: 6361556 Join Date: Nov 2009 Device: many	I will ask DiapDealer to investigate this on his Windows build to see if he has any ideas. Edit: Passed along the testcase to him and asked DiapDealer to take a look when he gets a chance. Interestingly enough I could not e-mail the plugin zip code to him as gmail barfed saying it was infected when of course it is just a zip with an executable inside and a bunch of python code. The executable is just to help see svg images in a tk plugin and is not needed. Hopefully he will be able to track down what the issue is and hopefully fix it in master. Last edited by KevinH; 02-03-2021 at 04:50 PM.

02-03-2021, 06:15 PM	#59
BeckyEbook Guru Posts: 899 Karma: 3501166 Join Date: Jan 2017 Location: Poland Device: Various	No, I see issue. Code: apath = os.path.normcase(apath) For example: titlemap says "OEBPS/introducao.xhtml", but the bookpath says "OEBPS/Introducao.xhtml". Since the bookpath in the titlemap is different than the actual name in the EPUB file – the condition is not met and the title is not inserted. --- Edit: If the xhtml file name is written in lowercase (e.g. toc.xhtml) then the title is inserted because the bookpath matches the titlemap. Last edited by BeckyEbook; 02-03-2021 at 06:30 PM.

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
[Plugin] ACE - DAISY EPUB Accessibility Checker wrapper	Doitsu	Plugins	37	07-15-2024 11:38 AM
Easier access to plugin prefs	slowsmile	Plugins	14	10-22-2017 01:42 PM
Help me improve my EPUB converter	epubler	Workshop	2	07-20-2011 09:15 PM
Epub Revision - accessibility support	Nate the great	ePub	1	02-23-2011 03:47 AM
Kindle 2 Accessibility Access Mode suggestions	scotty1024	Amazon Kindle	4	02-28-2009 06:06 PM

02-03-2021, 04:33 PM	#52
KevinH Sigil Developer Posts: 9,070 Karma: 6361556 Join Date: Nov 2009 Device: many	Okay, grabbed an official release build of Sigil-1.4.3 for mac from the Official Sigil github releases and wonloaded and installed it and ran Access-Aide on the provided testcase. On load I had to run Mend to add the Doctypes and then invoked Access-Aide and it did its job correctly. So something very Windows specific that impacts plugins is happening. Very strange.

02-03-2021, 05:10 PM	#54
DiapDealer Grand Sorcerer Posts: 28,880 Karma: 207000000 Join Date: Jan 2010 Device: Nexus 7, Kindle Fire HD	I was going to say I was seeing the same thing on Windows, but it looks like I should just skip to seeing why it might work differently on Windows.

02-03-2021, 05:12 PM	#55
KevinH Sigil Developer Posts: 9,070 Karma: 6361556 Join Date: Nov 2009 Device: many	Does it fail on master on Windows too?

02-03-2021, 05:25 PM	#56
BeckyEbook Guru Posts: 899 Karma: 3501166 Join Date: Jan 2017 Location: Poland Device: Various	Yes (Windows 10). I have the build prepared just now and the problem exists.

02-03-2021, 06:07 PM	#58
KevinH Sigil Developer Posts: 9,070 Karma: 6361556 Join Date: Nov 2009 Device: many	So the problem may be with the executable as that is pretty much the only Windows specific thing. Perhaps it is causing the plugin to exit abnormally?

02-03-2021, 06:44 PM	#60
KevinH Sigil Developer Posts: 9,070 Karma: 6361556 Join Date: Nov 2009 Device: many	But how does it work on Linux which is fully case sensitive?

Advert

Advert