[Editor Plugin] Otter's Editing Toolbag

[JSWolf]

Originally Posted by Lukusaukko

Thanks for the bug report.

I'm now testing an additional option to also convert dashes that begin a block to a closed style (it needs to be an option, so I don't break a typical Finnish convention of beginning dialogue with em dash + space).

There was also another bug related to the same behaviour nearby: if a <p> element ended with space + em dash + </p> then the em dash wasn't normalized to closed style, because the code didn't take the closing tag into account.

I'll try to get a new testing version uploaded tomorrow.

The same bug prevents en-dashes being converted to en-dashes. regardless of a spaces or no space.

A better idea is to make it an option to do it the Finnish way since more people will want to do it as it should be working.

[Lukusaukko]

Originally Posted by JSWolf

The same bug prevents en-dashes being converted to en-dashes. regardless of a spaces or no space.

Do you mean <p>—Word</p> not getting converted into <p>– Word</p> or something else? <p>–Word</p> vs <p>– Word</p>? If so, that's probably the result of too-strict conversion logic between dash types that gets thrown off-course at the beginning of a line. I'll check that one as well.

[Lukusaukko]

There is now a new test version 0.6.1 that improves dash conversion behaviour and fixes some bugs involving it.

[JSWolf]

Originally Posted by Lukusaukko

Do you mean <p>—Word</p> not getting converted into <p>– Word</p> or something else? <p>–Word</p> vs <p>– Word</p>? If so, that's probably the result of too-strict conversion logic between dash types that gets thrown off-course at the beginning of a line. I'll check that one as well.

I mean <p>— Word not having the space removed. It also does the same thing if it's a <div> instead of <p>/

[BetterRed]

Dash (em and en) are used as dialogue markers in many languages, not just Finnish - e.g. Spanish, Russian, French, Italian, Portuguese, Romanian… etc.

And the usage of the dash as a dialogue marker is not consistent across languages, IIRC In Spanish, an em dash (raya) after a spoken word at the end of a paragraph indicates 'more to come'.

And James Joyce throws a spanner in the works by using em dash as a dialogue marker in his major works — Ulysses, Dubliners etc, which are written in English (sort of ).

BR

[JSWolf]

0.6.1 needs to be fixed. The option Also apply dash style to leading dashes at the start of a paragraph is worded wrong because you are also doing it at the end of a paragraph as well. #

There is something that does need to be fixed. When you click the icon, I get the option screen. The option screen should be in the settings which should be when you click the arrow next tot he icon. Clicking the icon should just do it. It should not bring up an option screen to then make us click OK.

[Lukusaukko]

End-of-paragraph dash behaviour was a bug with the dash conversion logic, while the start-of-paragraph behaviour was an attempted guard against changing dialogue-starting dashes. So the wording is more or less right, for a given value.

I'm currently working on a version that adds the possibility to use the icons as they are now, or tick a box that allows them to run the tool with the last-used settings (except Span/Div, which always needs active input in any case), with the settings accessible from the dropdown. I edit books in multiple languages with different typographical conventions, so I often need to check the settings before running the tools anyway, but this allows both workflows, according to taste.

[JSWolf]

Originally Posted by Lukusaukko

End-of-paragraph dash behaviour was a bug with the dash conversion logic, while the start-of-paragraph behaviour was an attempted guard against changing dialogue-starting dashes. So the wording is more or less right, for a given value.

I'm currently working on a version that adds the possibility to use the icons as they are now, or tick a box that allows them to run the tool with the last-used settings (except Span/Div, which always needs active input in any case), with the settings accessible from the dropdown. I edit books in multiple languages with different typographical conventions, so I often need to check the settings before running the tools anyway, but this allows both workflows, according to taste.

Sounds good. Are you going to have an option in the settings to bring up the settings or not when you click the icon? That to me would work with a settings option under the arrow.