[Plugin] cssRemoveUnusedSelectors

[odamizu]

Greetings!

This wonderful plug-in is failing when I run it in Sigil 0.9.18 :(

Here's the error message:

Status: failed

Traceback (most recent call last):
File "/Applications/Sigil.app/Contents/plugin_launchers/python/launcher.py", line 135, in launch
self.exitcode = target_script.run(container)
File "/Users/oda/Library/Application Support/sigil-ebook/sigil/plugins/cssRemoveUnusedSelectors/plugin.py", line 600, in run
css_to_change[sel_data[0]] = sel_data[4].cssText
File "site-packages/css_parser/css/cssstylesheet.py", line 139, in _getCssText
File "/Users/oda/Library/Application Support/sigil-ebook/sigil/plugins/cssRemoveUnusedSelectors/customCssutils.py", line 53, in do_CSSStyleSheet
text = self._linenumnbers(self.prefs.lineSeparator.join(out))
AttributeError: 'MyCSSSerializer' object has no attribute '_linenumnbers'
Error: 'MyCSSSerializer' object has no attribute '_linenumnbers'

Any help great appreciated. Thank you!

[Doitsu]

Originally Posted by odamizu

This wonderful plug-in is failing when I run it in Sigil 0.9.18 — guessing something to do with the replacement of cssutils module with new css-parser??

Please edit customCssutils.py in the cssRemoveUnusedSelectors plugin folder and change line 53

from

        text = self._linenumnbers(self.prefs.lineSeparator.join(out))

to:

        text = self._linenumbers(self.prefs.lineSeparator.join(out))

[odamizu]

Originally Posted by Doitsu

Please edit customCssutils.py in the cssRemoveUnusedSelectors plugin folder and change line 53 ...

Awesome! for the speedy and simple fix!

I'm not even going to wonder why that typo hasn't caused a problem before.

[wrCisco]

That was a systematic typo in cssutils that some overzealous would-be developer corrected in the upgrade to css-parser...

When I have the time I will add a new version of the plugin that will directly use the new serializer.

In the meantime to Doitsu for the ready handmade patch.

[odamizu]

Originally Posted by wrCisco

That was a systematic typo in cssutils that some overzealous would-be developer corrected in the upgrade to css-parser...

When I have the time I will add a new version of the plugin that will directly use the new serializer.

I love your plugin. I use it often.

[wrCisco]

Just uploaded version 0.3.1 of the plugin, which adds compatibility with css-parser and Sigil 0.9.18 (secondarily, it shows some minor GUI improvements).

Originally Posted by odamizu

I love your plugin. I use it often.

I'm glad to hear that.

[DiapDealer]

Just curious: was there some serious jury-rigging you were doing to get cssutils to work (or were you including your own cssutils) or something? just curious why this typo didn't cause trouble before now. We made sure that all calls to import any part of cssutils were hijacked and silently redirected to the equivalent css_parser pieces when we made the change. That was done specifically so any plugins that used cssutils could still work (giving the dev time to change to css_parser at their leisure). Sorry that didn't seem to work for your plugin.

[KevinH]

wrCisco fixed the typo in css-parser when he ported his improvements over for us into css-parser. I had forgotten that typo worked "as is" in cssutils but since it was fixed in css-parser it created this plugin issue which he has now fixed!

[wrCisco]

The plugin includes a sublcass of the cssutils's serializer, and in that subclass I had to copy some parent's methods in full along with the typo in order to add some lines of code in between to circumvent some issues with the old serializer.

Since the typo was in a private attribute, it's probably just me that's been hit by myself...

[DiapDealer]

Ah... I get it now. Thanks! I'd forgotten you were the one who was helping Kevin and Kovid get css-parser up and going.

[odamizu]

Originally Posted by wrCisco

Just uploaded version 0.3.1 of the plugin, which adds compatibility with css-parser and Sigil 0.9.18 (secondarily, it shows some minor GUI improvements).

[mcdummy]

Hi wrCisco,

Could you also add a feature that does the opposite, i.e. looks in the html/xhtml/xml files for classes that are used in these files, but do not have a corresponding defintion in the css file?

I've downloaded several ebook from gutenberg.org, which did not provide definitions for all classes used in the html/... files. Since I guess that the creator intended to have a special formating of the corresponding text passages, but forgot to add the defintions to the css, it would be good to be informed about the missing defintions to be able to format these passages.

Regards,

McDummy

[DNSB]

Originally Posted by mcdummy

Hi wrCisco,

Could you also add a feature that does the opposite, i.e. looks in the html/xhtml/xml files for classes that are used in these files, but do not have a corresponding defintion in the css file?

I've downloaded several ebook from gutenberg.org, which did not provide definitions for all classes used in the html/... files. Since I guess that the creator intended to have a special formating of the corresponding text passages, but forgot to add the defintions to the css, it would be good to be informed about the missing defintions to be able to format these passages.

Regards,

McDummy

You could use the Reports tool. The Classes Used report will show undefined classes at the top of the report with no matched selector or found in. See attached image.

And yes, this is a commercial book I'm cleaning up for my wife.. If you want really bad examples, check for ebooks created by Vellum.

[hobnail]

Originally Posted by DNSB

You could use the Reports tool. The Classes Used report will show undefined classes at the top of the report with no matched selector or found in.

But you'd still need to go in and manually remove them, one by one. A coworker of mine had a useful phrase about automated things like this; "Never send a man to do a computer's job" (a twist on the old proverb).

[DNSB]

Originally Posted by hobnail

But you'd still need to go in and manually remove them, one by one. A coworker of mine had a useful phrase about automated things like this; "Never send a man to do a computer's job" (a twist on the old proverb).

But @mcdummy did not want the undefined classes removed. He wanted to be informed about them so he could add the required classes. For that, I thought the Report tool was an already implemented solution.

Since I guess that the creator intended to have a special formating of the corresponding text passages, but forgot to add the defintions to the css, it would be good to be informed about the missing defintions to be able to format these passages.

I suppose cssRemoveUnusedSelectors plugin could be modified so undefined classes would be added to the stylesheet as a blank selector ( .whatever {} ) but not sure how much easier that would make the job. Are you volunteering to code and test this?