Templates: various questions not worth their own thread

[ownedbycats]

Those both work.

Also, would I be imagining things, or can splitting up a stored template (before, icons_cleanup was all one big template) be a bit more efficient? I split it mostly for ease of editing.

[chaley]

Originally Posted by ownedbycats

Also, would I be imagining things, or can splitting up a stored template (before, icons_cleanup was all one big template) be a bit more efficient? I split it mostly for ease of editing.

There is almost no performance gain or loss from splitting stored templates. Do it for the reason you gave, ease of editing and understanding what they do.

[ownedbycats]

Thanks.

Is it intended that a single-column colour rule always overrides an all-column rule, regardless of position in the rules list? I think I opened a ticket about this a few days ago but I can't find it now.

[chaley]

Originally Posted by ownedbycats

Is it intended that a single-column colour rule always overrides an all-column rule, regardless of position in the rules list? I think I opened a ticket about this a few days ago but I can't find it now.

I hadn't answered the ticket.

The behavior is intended. "Single column" rules are applied first, possibly coloring a column. Next "all column" rules color any remaining uncolored columns. For any given column a "single column" rule always overrides the "all column" rules.

[ownedbycats]

That makes sense. I just modified my single-column rule then. Now it shows the same colour for the whole row.

[ownedbycats]

On the topic of that single-column rule:

program:

	if readstatus()=='currentlyreading' then
		read = $$#lastread;
		updated = $$#fanficupdated;

		if fanfic_unreadchaps()==#1 && $$#percentread==#99 then '#00aaff' 
		elif fanfic_unreadchaps()==#1 && days_between (read, updated) <#0 then '#00d400'
		elif fanfic_unreadchaps()>=#1 && days_between (read, updated) <#0 then '#ffff7f' 
		fi
	
	else colours_daysbetween($#lastread, '#00aaff', '#69cfff', '#9bdeff')
	
	fi

If the colours_daybetween on line 12 is outside the inner fi (line 10), it doesn't colour currentlyreadings that don't match the other rules. But if I put it inside the fi it only colours currentlyreadings. Do I need to duplicate that line?

[chaley]

Originally Posted by ownedbycats

On the topic of that single-column rule:

program:

	if readstatus()=='currentlyreading' then
		read = $$#lastread;
		updated = $$#fanficupdated;

		if fanfic_unreadchaps()==#1 && $$#percentread==#99 then '#00aaff' 
		elif fanfic_unreadchaps()==#1 && days_between (read, updated) <#0 then '#00d400'
		elif fanfic_unreadchaps()>=#1 && days_between (read, updated) <#0 then '#ffff7f' 
		fi
	
	else colours_daysbetween($#lastread, '#00aaff', '#69cfff', '#9bdeff')
	
	fi

If the colours_daybetween on line 12 is outside the inner fi (line 10), it doesn't colour currentlyreadings that don't match the other rules. But if I put it inside the fi it only colours currentlyreadings. Do I need to duplicate that line?

It isn't clear to me what you want to do. If you want the color in the else clause to be used if no other color is selected then this would do it.

program:

	colour = if readstatus()=='currentlyreading' then
		read = $$#lastread;
		updated = $$#fanficupdated;

		if fanfic_unreadchaps()==#1 && $$#percentread==#99 then '#00aaff' 
		elif fanfic_unreadchaps()==#1 && days_between (read, updated) <#0 then '#00d400'
		elif fanfic_unreadchaps()>=#1 && days_between (read, updated) <#0 then '#ffff7f' 
		fi
	fi;
	if !colour then colour = colours_daysbetween($#lastread, '#00aaff', '#69cfff', '#9bdeff')
	fi;
	colour

[ownedbycats]

Yes, that works. Thank you.

As for what I'm doing -- the rule's for Last Read column.
books 2 - 10 all match the checks.

The others are using colours_daysbetween().

Before, either book 1 (currentlyreading) or books 11-17 (not currentlyreading) would be uncoloured, depending on where I had colours_daysbetween()

[ownedbycats]

Mostly out of curiosity:



The 'Title' placeholder is presumably because I didn't have any books selected when I opened the dialog. In this case, it shows the firstmost available result, but sometimes I've seen it show the last one instead, or sometimes an empty one. What is it based on?

[chaley]

Originally Posted by ownedbycats

The 'Title' placeholder is presumably because I didn't have any books selected when I opened the dialog. In this case, it shows the firstmost available result, but sometimes I've seen it show the last one instead, or sometimes an empty one. What is it based on?

It shows the first book selected. If you select from row 5 then row 4 it will show row 5.

That said, there is no reason not to show all the books selected. I will change that. I will also make the dialog remember whether "help" is showing or not.

[chaley]

Originally Posted by chaley

That said, there is no reason not to show all the books selected. I will change that. I will also make the dialog remember whether "help" is showing or not.

Changes are now in source.

[ownedbycats]

Thanks. That'll make it easier to make quick changes without copying to the template tester to make sure it works as intended.

[ownedbycats]

Question: What does
Duplicate user function name icons_fanfic. Change the name or ensure that the functions are identical
mean?

It showed up in another templateafter modifying the icons_fanfic() to add some new items, but went away when I restarted Calibre.

EDIT: It hasn't recurred since, so I think it might've been a one-time glitch.

[chaley]

Originally Posted by ownedbycats

Question: What does
Duplicate user function name icons_fanfic. Change the name or ensure that the functions are identical
mean?

It showed up in another template after modifying the icons_fanfic() to add some new items, but went away when I restarted Calibre.

EDIT: It hasn't recurred since, so I think it might've been a one-time glitch.

For completeness, the message means that you created a user-defined template function (in python) with a name that matches an existing function but with different code. The problem is detected when the function is registered -- made available to the template language. The change could happen any time before that. I don't know how to make the error happen.

[ownedbycats]

Could it have been possible there were, via some glitch, two versions of the stored template temporarily in memory? I checked and saw there was only one icons_fanfic(), but restarting Calibre fixed the error.