Register Guidelines E-Books Today's Posts Search

Go Back   MobileRead Forums > E-Book Software > Calibre > Development

Notices

Closed Thread
 
Thread Tools Search this Thread
Old 12-10-2013, 12:02 PM   #286
kovidgoyal
creator of calibre
kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.
 
kovidgoyal's Avatar
 
Posts: 45,382
Karma: 27756918
Join Date: Oct 2006
Location: Mumbai, India
Device: Various
Quote:
Originally Posted by arspr View Post
OK, I suppose page layout support is fully pointless. But, please, could you implement full font support? Fonts not being used because of their "conflictive" names can be REALLY distracting and completely user-unfriendly. I fear you are going to receive a lot of complaints, like my original one, about "My font doesn't render" despite all the warnings you put in the tool opening.
Since that comes from a Qt bug, I cannot fix it. Fortunately, I have automatic bug closing for oft-repeated bug reports.
kovidgoyal is offline  
Old 12-10-2013, 12:09 PM   #287
arspr
Dead account. Bye
arspr ought to be getting tired of karma fortunes by now.arspr ought to be getting tired of karma fortunes by now.arspr ought to be getting tired of karma fortunes by now.arspr ought to be getting tired of karma fortunes by now.arspr ought to be getting tired of karma fortunes by now.arspr ought to be getting tired of karma fortunes by now.arspr ought to be getting tired of karma fortunes by now.arspr ought to be getting tired of karma fortunes by now.arspr ought to be getting tired of karma fortunes by now.arspr ought to be getting tired of karma fortunes by now.arspr ought to be getting tired of karma fortunes by now.
 
Posts: 587
Karma: 668244
Join Date: Mar 2011
Device: none
Kovid, since we have crossed while posting, I repeat here the last edit from my previous post:

And another suggestion related to the ";" issue. Currently, Beautify CSS removes the last ";". As a safety measure I would do the opposite action, I would always add it even if not necessary...

Last edited by arspr; 12-10-2013 at 12:13 PM.
arspr is offline  
Advert
Old 12-10-2013, 12:11 PM   #288
samy2
Ebook-Fan
samy2 ought to be getting tired of karma fortunes by now.samy2 ought to be getting tired of karma fortunes by now.samy2 ought to be getting tired of karma fortunes by now.samy2 ought to be getting tired of karma fortunes by now.samy2 ought to be getting tired of karma fortunes by now.samy2 ought to be getting tired of karma fortunes by now.samy2 ought to be getting tired of karma fortunes by now.samy2 ought to be getting tired of karma fortunes by now.samy2 ought to be getting tired of karma fortunes by now.samy2 ought to be getting tired of karma fortunes by now.samy2 ought to be getting tired of karma fortunes by now.
 
Posts: 398
Karma: 698564
Join Date: Feb 2011
Device: PRS T1
I dont like the name of the when I spit files:

Now its:
part0000_1
part0000_1_1
part0000_1_1_1

After a view splits i had a monster like this:
"part0000_1_1_1_1_1_1"

I like to have it like in sigil:
part0000_1
part0000_2
part0000_3
part0000_4

Last edited by samy2; 12-10-2013 at 12:14 PM.
samy2 is offline  
Old 12-10-2013, 12:25 PM   #289
kovidgoyal
creator of calibre
kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.
 
kovidgoyal's Avatar
 
Posts: 45,382
Karma: 27756918
Join Date: Oct 2006
Location: Mumbai, India
Device: Various
@samy2: While that scheme works well in your particular case, consider when you have two files, already named:

part000_1.html
part000_2.html

Now when you split part000_1.html you will get
part000_1.html
part000_3.html
part000_2.html

So that the names become out of order.

@arspr: Checking CSS for validity will be implemented soon. And you are right, it's better to have the trailing semi-colon to avoid unnecessary mistakes.
kovidgoyal is offline  
Old 12-10-2013, 03:39 PM   #290
arspr
Dead account. Bye
arspr ought to be getting tired of karma fortunes by now.arspr ought to be getting tired of karma fortunes by now.arspr ought to be getting tired of karma fortunes by now.arspr ought to be getting tired of karma fortunes by now.arspr ought to be getting tired of karma fortunes by now.arspr ought to be getting tired of karma fortunes by now.arspr ought to be getting tired of karma fortunes by now.arspr ought to be getting tired of karma fortunes by now.arspr ought to be getting tired of karma fortunes by now.arspr ought to be getting tired of karma fortunes by now.arspr ought to be getting tired of karma fortunes by now.
 
Posts: 587
Karma: 668244
Join Date: Mar 2011
Device: none
Some additional little things about Check Book:
  • I've just performed a test deleting the first ending </p> (in line 16). And the warning/error I get is mismatch with the ending </body> (in line 69). Is this behaviour correct? I mean: can <p> be nested INSIDE other <p>, which is what is actually happening? I also ask this because if I perform a Fix HTML what I actually get is the ending </p> in line 16, not in line 69 just before </body> (Possible incoherency between Check Book and Fix HTML?).
  • As a suggestion: I would add the file name in the left window list. The current list is somehow confusing (as example I have a loooong list of nbsps with no hint about being different files, till you click on each one).
  • I know that you are going to ignore entities like &nbsp; which is probably the best thing to do. But nevertheless, why &nbsp; generates a warning/error but, as example, &mdash; or &sup2; don't? Irrelevant? Or the symptom of another possible hidden issue?

And another one about Fix HTML which actually looks like a bug:
  • If I run it on a "good" HTML file from Sigil. <html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en-US" xmlns:xml="http://www.w3.org/XML/1998/namespace"> is changed into just <html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en-US">
  • But if I delete the very first ending </p> (or any other </p> BTW) and then I run it what I got is this <html xmlns="http://www.w3.org/1999/xhtml" lang="en-US" xmlnsU0003Axml="http://www.w3.org/XML/1998/namespace">

Last edited by arspr; 12-10-2013 at 03:43 PM.
arspr is offline  
Advert
Old 12-10-2013, 09:07 PM   #291
jackie_w
Grand Sorcerer
jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.
 
Posts: 6,252
Karma: 16544692
Join Date: Sep 2009
Location: UK
Device: ClaraHD, Forma, Libra2, Clara2E, LibraCol, PBTouchHD3
@kovid,

Another few comments for your consideration (using beta 1.14 10th Dec on Windows 7) :
  • If I open an epub just to have a look at something then Quit without making any changes, the epub is updated and the file's OS date/time is changed - although the calibre last_modified date does remain unchanged. Is this deliberate?

    I think I recall you saying that the metadata would be automatically updated during an edit, but if I Quit without saving I think I want the file to be totally unchanged. I don't know how others feel.

    On the other hand, if I do make changes and then File-Save, the calibre last_modified date is not updated. This doesn't seem logical either.

  • Re: Find/Replace
    Firstly, when doing Find/Replaces one-by-one checking results each time, the fact that the match is positioned right at the top of the Preview pane is less helpful than if you are able to see some content both immediately before & after the match to get some context. I didn't realise how much I appreciated Sigil positioning each match in the vertical centre of the Preview pane until I didn't have it.

    Secondly, when working your way through a series of Find matches across all text files the highlighted file in the left panel File Browser is not changing as each new match is found. Should it be?

  • Lastly, this one is purely cosmetic and a matter of opinion, therefore not at all urgent. Regarding the 3 dark themes in Edit - Prefs. I'm not sure if these are canned themes over which there is no control, however...

    wombat-dark would be my favourite were it not for the fact that the dark grey used during Find/Replace does not stand out well from the black background. Also if there is syntax highlighting of those pesky nbsp unicode chars in this theme, I can't see it - maybe it's a grey even closer to black.

    Similarly, solarized-dark isn't much easier to see in these same 2 respects and solarized-x-dark is even harder IMO.
jackie_w is offline  
Old 12-10-2013, 10:04 PM   #292
BetterRed
null operator (he/him)
BetterRed ought to be getting tired of karma fortunes by now.BetterRed ought to be getting tired of karma fortunes by now.BetterRed ought to be getting tired of karma fortunes by now.BetterRed ought to be getting tired of karma fortunes by now.BetterRed ought to be getting tired of karma fortunes by now.BetterRed ought to be getting tired of karma fortunes by now.BetterRed ought to be getting tired of karma fortunes by now.BetterRed ought to be getting tired of karma fortunes by now.BetterRed ought to be getting tired of karma fortunes by now.BetterRed ought to be getting tired of karma fortunes by now.BetterRed ought to be getting tired of karma fortunes by now.
 
Posts: 21,749
Karma: 30237526
Join Date: Mar 2012
Location: Sydney Australia
Device: none
Quote:
Originally Posted by jackie_w View Post
@kovid,

Another few comments for your consideration (using beta 1.14 10th Dec on Windows 7) :[LIST][*]If I open an epub just to have a look at something then Quit without making any changes, the epub is updated and the file's OS date/time is changed - although the calibre last_modified date does remain unchanged. Is this deliberate?

I think I recall you saying that the metadata would be automatically updated during an edit, but if I Quit without saving I think I want the file to be totally unchanged. I don't know how others feel.

On the other hand, if I do make changes and then File-Save, the calibre last_modified date is not updated. This doesn't seem logical either.
If you invoke the program from the command line or file manager and quit without saving then the file system modified timestamp, file size and checksums don't seem to change.

However, if you invoke the program from the calibre GUI and quit without saving the file system modified timestamp, file size and checksums do seem to change. The database last_modified_date presumably changes because the file system properties changed.

It should be consistent, and I would have thought that if the file isn't saved then the file and its properties shouldn't change.

BR

Last edited by BetterRed; 12-10-2013 at 10:09 PM.
BetterRed is offline  
Old 12-10-2013, 10:14 PM   #293
kovidgoyal
creator of calibre
kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.
 
kovidgoyal's Avatar
 
Posts: 45,382
Karma: 27756918
Join Date: Oct 2006
Location: Mumbai, India
Device: Various
@jackie_w: Turn off automatic metadata update under calibre integration in the preferences and the file will not be touched unless you do a save. last_modified is not intended to track file time modification, tweak book is no different in that respect. Currently, tweak book operates completely independently of calibre, you can close calibre and TB will continue to work. Changing it to update last modified dates will mean that will change. Not a tradeoff I think is worth making.

I prefer having the current element at the top of the panel, as having it at the center means you can never be sure exactly where it is and your eyes have to scan around looking for it. Also showing the element at the center is not very robust. It works for simple layouts, but more complex ones can cause problems with the element not perfectly positioned. Showing it at the top uses the browsers' own implementation and is much more robust.

The Files Browser does not track the currently opened file. You can select multiple entries in the files browser, so having it track the current file doesn't make much sense. I suppose I could it have it show the currently opened file in bold, but the selected files are not going to change.

Re: colors: I'll have a look at increasing the contrast in wombat for selected text and nbsp highlighting. In any case, at some point I will add the ability to create your own custom themes, then you can tweak the colors to your hearts content.
kovidgoyal is offline  
Old 12-10-2013, 10:17 PM   #294
Dopedangel
Wizard
Dopedangel ought to be getting tired of karma fortunes by now.Dopedangel ought to be getting tired of karma fortunes by now.Dopedangel ought to be getting tired of karma fortunes by now.Dopedangel ought to be getting tired of karma fortunes by now.Dopedangel ought to be getting tired of karma fortunes by now.Dopedangel ought to be getting tired of karma fortunes by now.Dopedangel ought to be getting tired of karma fortunes by now.Dopedangel ought to be getting tired of karma fortunes by now.Dopedangel ought to be getting tired of karma fortunes by now.Dopedangel ought to be getting tired of karma fortunes by now.Dopedangel ought to be getting tired of karma fortunes by now.
 
Dopedangel's Avatar
 
Posts: 1,794
Karma: 30548723
Join Date: Dec 2006
Location: Singapore
Device: Boyue
Any chance of adding a way to batch rename files. So that if I select all the chapter html files and name the first one Chapter01.html the rest are named in sequence
Another thing to make filename from the toc name or heading so if the heading is Preface or Introduction. I just right click the file and choose rename using toc name.
Ability to detect auto replace chapter images with text. I hate those think they bulk up an ebook for no reason.
Dopedangel is offline  
Old 12-10-2013, 10:48 PM   #295
kovidgoyal
creator of calibre
kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.
 
kovidgoyal's Avatar
 
Posts: 45,382
Karma: 27756918
Join Date: Oct 2006
Location: Mumbai, India
Device: Various
@Dopedangel: There will be a bulk file rename wizard which will put the files into a "standard" folder structure. No reason it cannot have an option to rename all html files with a standard prefix and number. For the rest, patches are welcome.
kovidgoyal is offline  
Old 12-10-2013, 10:50 PM   #296
BetterRed
null operator (he/him)
BetterRed ought to be getting tired of karma fortunes by now.BetterRed ought to be getting tired of karma fortunes by now.BetterRed ought to be getting tired of karma fortunes by now.BetterRed ought to be getting tired of karma fortunes by now.BetterRed ought to be getting tired of karma fortunes by now.BetterRed ought to be getting tired of karma fortunes by now.BetterRed ought to be getting tired of karma fortunes by now.BetterRed ought to be getting tired of karma fortunes by now.BetterRed ought to be getting tired of karma fortunes by now.BetterRed ought to be getting tired of karma fortunes by now.BetterRed ought to be getting tired of karma fortunes by now.
 
Posts: 21,749
Karma: 30237526
Join Date: Mar 2012
Location: Sydney Australia
Device: none
Quote:
Originally Posted by kovidgoyal View Post
@jackie_w: Turn off automatic metadata update under calibre integration in the preferences...
Kovid, in Windows the change to that setting seems to require a restart of the calibre GUI before it takes effect.

BR

Last edited by BetterRed; 12-10-2013 at 10:52 PM.
BetterRed is offline  
Old 12-10-2013, 10:53 PM   #297
jackie_w
Grand Sorcerer
jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.jackie_w ought to be getting tired of karma fortunes by now.
 
Posts: 6,252
Karma: 16544692
Join Date: Sep 2009
Location: UK
Device: ClaraHD, Forma, Libra2, Clara2E, LibraCol, PBTouchHD3
Quote:
Originally Posted by kovidgoyal View Post
Turn off automatic metadata update under calibre integration in the preferences and the file will not be touched unless you do a save.
What can I say?

Quote:
Originally Posted by kovidgoyal View Post
last_modified is not intended to track file time modification, tweak book is no different in that respect. Currently, tweak book operates completely independently of calibre, you can close calibre and TB will continue to work. Changing it to update last modified dates will mean that will change. Not a tradeoff I think is worth making.
OK, however that's a change from the old Tweak (now Unpack) behaviour which does update last_modified if you press Rebuild. So the issue may be raised by others.

Quote:
Originally Posted by kovidgoyal View Post
I prefer having the current element at the top of the panel, as having it at the center means you can never be sure exactly where it is and your eyes have to scan around looking for it. Also showing the element at the center is not very robust. It works for simple layouts, but more complex ones can cause problems with the element not perfectly positioned. Showing it at the top uses the browsers' own implementation and is much more robust.
I guess robust is best. BTW I did have occasional problems today with the Preview not always tracking to the current match. If I can reliably reproduce it in a test file I'll give more details.

Quote:
Originally Posted by kovidgoyal View Post
I suppose I could it have it show the currently opened file in bold, but the selected files are not going to change.
That would be good and would kind-of match what happens in the Viewer with the TOC. If you intend to include a visible TOC at some point it may be more appropriate there than in the File Browser.

Quote:
Originally Posted by kovidgoyal View Post
In any case, at some point I will add the ability to create your own custom themes, then you can tweak the colors to your hearts content.
In that case, I'm sure I can wait till the complete custom color feature is available.
jackie_w is offline  
Old 12-10-2013, 10:57 PM   #298
kovidgoyal
creator of calibre
kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.
 
kovidgoyal's Avatar
 
Posts: 45,382
Karma: 27756918
Join Date: Oct 2006
Location: Mumbai, India
Device: Various
@arspr: A nesting error is only an error at the point where a mismatched closing tag is present, not where the opening tag is present. Therefore the behavior of Check Book is correct.

As for xmlns:xml, that declaration is redundant and should be removed. The xml namespace is *always* defined in XML documents. http://www.w3.org/XML/1998/namespace

I suppose I could have the html 5 parser remove it automatically, I will look into that.
kovidgoyal is offline  
Old 12-10-2013, 11:11 PM   #299
kovidgoyal
creator of calibre
kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.
 
kovidgoyal's Avatar
 
Posts: 45,382
Karma: 27756918
Join Date: Oct 2006
Location: Mumbai, India
Device: Various
@BR: yeah, calibre has no way to know what you do in TB. However, I will have it refresh those preferences every time TB is launched, so that should take care of it.

@jackie: It may be possible to have TB inform calibre when it does a save, which will allow calibre to update the filesize and last modified columns appropriately. However, it will only work as long as calibre is running and is on the correct library.

Last edited by kovidgoyal; 12-10-2013 at 11:29 PM.
kovidgoyal is offline  
Old 12-11-2013, 01:48 AM   #300
kovidgoyal
creator of calibre
kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.
 
kovidgoyal's Avatar
 
Posts: 45,382
Karma: 27756918
Join Date: Oct 2006
Location: Mumbai, India
Device: Various
New builds at: http://download.calibre-ebook.com/betas/

Changes:

1) Check Book now checks CSS as well, in stylesheets and inside <style> tags
2) Renamed Tweak Book to Edit Book. I think I found and changed all references, but if you spot any old references to tweaking, let me know
3) Updates last_modified and filesize automatically when launched from inside calibre
4) Various small bug fixes for issues reported in this thread
kovidgoyal is offline  
Closed Thread


Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
How to make Sigil live varlog Sigil 136 10-25-2013 02:34 PM
how many tocs does Sigil make? Gregg Bell Sigil 17 01-31-2013 09:39 AM
How do I make all .pdf's in my calibre library open in calibre instead of preview morbo3000 Library Management 9 07-30-2011 10:39 AM
using sigil to make changes befote conversion alansplace Sigil 11 06-07-2011 07:50 AM
i can't make sigil run in fedora 14 nastarovia Sigil 1 01-20-2011 05:02 AM


All times are GMT -4. The time now is 04:22 PM.


MobileRead.com is a privately owned, operated and funded community.