Saved searches: opinions wanted - Page 2

chaley · 03-29-2010, 05:24 AM

Quote:

Originally Posted by kovidgoyal

Looks good to me. When you're ready submit the patch and I'll merge it as soon as I can find the time to review.

Do you want a staged release? By that do you want to release it as it is, before I add the code to support selecting searches from the tags pane? If so, then I will clean and finish testing, then send you a patch.

kovidgoyal · 03-29-2010, 06:13 AM

No I prefer the full thing, that way I wont have to load it all into my brain twice

chaley · 03-29-2010, 10:28 AM

Quote:

Originally Posted by kovidgoyal

No I prefer the full thing, that way I wont have to load it all into my brain twice

The patch file, some descriptive text, and a list of changed/new files have been posted on the bug tracker: http://bugs.calibre-ebook.com/ticket/5094#comment:8

Let me know (using the bug tracker) if there are some things you would rather I did differently.

Starson17 · 03-29-2010, 10:38 AM

Quote:

Originally Posted by chaley

The patch file, some descriptive text, and a list of changed/new files have been posted on the bug tracker: http://bugs.calibre-ebook.com/ticket/5094#comment:8

Let me know (using the bug tracker) if there are some things you would rather I did differently.

To avoid having to hunt it up, and to make sure I get it right, can you give me the bazaar command line to merge your patch file into my testing code? I normally merge direct from the Kovid's main code into my own patched files, or just merge directly from complete copies of modified files with a compare and merge utility program. I haven't merged in a patch file. I'm sure there's a simple bzr command specifying the merge file you've uploaded.

I'd enjoy looking over your testing code and trying it out.

Thanks.

rollercoaster · 03-29-2010, 10:52 AM

This is awesome! I feel Sorry that I missed the discussion. I have been away for a few days but looks like you guys got it right

Just kidding.

@chaley Thanks a whole lot!

Looking forward to a release.

chaley · 03-29-2010, 11:20 AM

Quote:

Originally Posted by Starson17

To avoid having to hunt it up, and to make sure I get it right, can you give me the bazaar command line to merge your patch file into my testing code? I normally merge direct from the Kovid's main code into my own patched files, or just merge directly from complete copies of modified files with a compare and merge utility program.

What I do is:
1. keep a branch of calibre that I call calibre_base. This branch was created from launchpad using the command

bzr branch lp:calibre calibre_base

2. keep a branch of calibre_base that I call calibre. This branch was created using the command

bzr branch calibre_base calibre

I do all my development in this branch.
3. Before starting any development (and from time to time anyway), I merge changes from launchpad into my calibre_base baseline using the command
'bzr merge', run inside the calibre_base folder. I then cd to my calibre development branch and run 'bzr merge' again. With this pair of steps, I know that my development branch (calibre) and my comparison branch (calibre_base) are up to date.
4. During development, I frequently commit changes with the bzr commit command. That way I have a trace of what I did + when I did it, and I also have a version system useful for backing out of badly-conceived editing.

I mention all of this because the patch file was built by comparing calibre_base to calibre. If you don't have a baseline repository around, I am not sure it will work. In addition, this system can rapidly give me a diff that shows everything I have changed from the baseline. The GUI version of bzr is particularly good for this.

The above notwithstanding, you merge a patch file with the commands:

cd 'into a calibre repository that you are willing to trash'
bzr merge path-to-patch-file

I tested this by creating a new branch calibre_test from calibre_base, cd'ing into calibre_test, and running the merge. It worked fine.

Good luck!
(and comments/improvements would be welcome.

)

chaley · 03-29-2010, 11:22 AM

Quote:

Originally Posted by rollercoaster

@chaley Thanks a whole lot!

You are welcome. And thank you for your suggestions on the previous thread, and in particular your suggestions for how to use tool tips. I wouldn't have thought of that.

rollercoaster · 04-09-2010, 05:20 AM

Quote:

Originally Posted by chaley

You are welcome. And thank you for your suggestions on the previous thread, and in particular your suggestions for how to use tool tips. I wouldn't have thought of that.

just updated calibre to .47 and saved searches are there. Awesome!

a couple of minor suggestions -
1. Show search queries in tooltip of individual items in the saved searches dropdown
2. Clear selected saved search when manually clearing the search text box
3. IMO add a confirmation message (one that has a dont show again checkbox) on the delete button. I accidentally clicked in with the habit of clicking the clear search box button and then did it again after 30 secs

Thanks very much for coding this feature. feels cool

chaley · 04-09-2010, 10:39 AM

Quote:

Originally Posted by rollercoaster

just updated calibre to .47 and saved searches are there. Awesome!

You are welcome.

Quote:

a couple of minor suggestions -
1. Show search queries in tooltip of individual items in the saved searches dropdown

This is a good idea, but it may be very hard to do. I will look at it.

Quote:

2. Clear selected saved search when manually clearing the search text box

Will do.

Quote:

3. IMO add a confirmation message (one that has a dont show again checkbox) on the delete button. I accidentally clicked in with the habit of clicking the clear search box button and then did it again after 30 secs

Will add this to the list.

As I am deep into hacking together tag-based columns, I won't get to these for a while. Could you post these as enhancement requests so I don't forget them? Assign the ticket to 'charles' (me). Thanks.

GRiker · 04-09-2010, 10:50 AM

chaley: Nice job on saved searches! I've already put them to work for several of my regular searches.

G

theducks · 04-09-2010, 11:35 AM

Saved searches Works great. It provides a wor around for a minor annoyance .

Example. Search not comments:true
returns the list of items missing comments.
Editing the metadata for a item in the list (add the missing stuff) does nt trigger a refresh of the search.
Now I just re-click the saved search button (previously saved)

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
Minor issue on searches	Sydney's Mom	Calibre	6	06-14-2010 04:46 PM
Opinions wanted on details of new GUI features	chaley	Calibre	44	06-14-2010 04:26 PM
opinions wanted strange dog or bobarra	mistyd1032	Amazon Kindle	0	05-30-2009 04:42 PM
ebook searches	john.hunt100	Reading Recommendations	5	09-19-2008 12:50 PM
Would it be possible to do three-letter searches?	Andanzas	Feedback	8	07-10-2007 09:50 PM

03-29-2010, 06:13 AM	#17
kovidgoyal creator of calibre Posts: 45,299 Karma: 27111240 Join Date: Oct 2006 Location: Mumbai, India Device: Various	No I prefer the full thing, that way I wont have to load it all into my brain twice

03-29-2010, 10:52 AM	#20
rollercoaster Zealot Posts: 126 Karma: 1826 Join Date: Jan 2010 Device: Kindle 2	This is awesome! I feel Sorry that I missed the discussion. I have been away for a few days but looks like you guys got it right Just kidding. @chaley Thanks a whole lot! Looking forward to a release.

04-09-2010, 10:50 AM	#25
GRiker Comparer of the Ephemeris Posts: 1,496 Karma: 424697 Join Date: Mar 2009 Device: iPad	chaley: Nice job on saved searches! I've already put them to work for several of my regular searches. G

04-09-2010, 11:35 AM	#26
theducks Well trained by Cats Posts: 31,001 Karma: 60358908 Join Date: Aug 2009 Location: The Central Coast of California Device: Kobo Libra2,Kobo Aura2v1, K4NT(Fixed: New Bat.), Galaxy Tab A	Saved searches Works great. It provides a wor around for a minor annoyance . Example. Search not comments:true returns the list of items missing comments. Editing the metadata for a item in the list (add the missing stuff) does nt trigger a refresh of the search. Now I just re-click the saved search button (previously saved)

Advert

Advert