Error importing mobi files

[pdurrant]

Originally Posted by pdurrant

I have a message box appearing now - thank you.

Arghh... but most of the time it's hidden by the large "Adding..." dialog.

Any ideas?

[kovidgoyal]

The plugin should either raise an exception or return the original file path on failure.

Make your message box non modal, it will then not interrupt the adding process and will still be there when the adding dialog closes.

EDIT: Actually, no that wont work, since the message box is cerated ina separate process that dies after adding is done

Instead you can try calling

self.raise_()

[pdurrant]

Originally Posted by kovidgoyal

Instead you can try calling

self.raise()

self.raise() gives a syntax error, and self.raise_() presumably generated an exception (since my dialog no longer appeared at all).

Here's my code that gets run when I've had to give up on converting a file:

if is_ok_to_use_qt():
	#self.raise_()
	QMessageBox.question( None, 
				'My Plugin', 
				"Couldn't convert: %s\nImporting original version instead." % path_to_ebook, QMessageBox.Ok)
return path_to_ebook

Suggestions welcome - I'm afraid python is new enough to me. Adding in QT as well has me well out of my depth.

[kovidgoyal]

You're using a pre-built messagebox, in that case raise wont work. WHat you have to do is construct your own messagebox and call raise_ on it

d = QMessageBox(QMessageBox.Warning, 'title', 'message')
d.raise_()
d.exec_()

[pdurrant]

Originally Posted by kovidgoyal

You're using a pre-built messagebox, in that case raise wont work. WHat you have to do is construct your own messagebox and call raise_ on it

d = QMessageBox(QMessageBox.Warning, 'title', 'message')
d.raise_()
d.exec_()

This runs OK, but my message box is still hidden behind the Adding... box.

I've attached a very simple plug-in that demonstrates the problem. I have no notion of how to get any further with this.

[kovidgoyal]

Do the following:

d = QMessageBox(QMessageBox.Warning, 'title', 'message')
d.show()
d.raise_()

I was wrong earlier, the import plugins are run in the same process as the GUI, so the boxes will stick around after the adding dialog is closed. This way, the user will be informed and the adding process wont be interrupted.

[pdurrant]

Originally Posted by kovidgoyal

Do the following:

d = QMessageBox(QMessageBox.Warning, 'title', 'message')
d.show()
d.raise_()

I was wrong earlier, the import plugins are run in the same process as the GUI, so the boxes will stick around after the adding dialog is closed. This way, the user will be informed and the adding process wont be interrupted.

That doesn't seem to show the messagebox at all. but I found that

d.show()
d.raise_()
d.exec_()

did bring the MessageBox to the front of the "Adding..." dialog.

If I could find a way to leave messages up in a non-modal fashion behind the "Adding..." dialog, I can ses that that would be better for when people want to import loads of files and just leave it running.

But I'm happy for now.

[kovidgoyal]

d.setModal(False)

before the call to exec_

[pdurrant]

Originally Posted by kovidgoyal

d.setModal(False)

before the call to exec_

This does make the dialog non-modal, but it doesn't allow exec_() to return until after the OK button has been pressed - so an error still blocks the import.

It seems to be that I really need to be able to put the message box into its own thread or something. But reading up on QT in python, is seems to be the case that all GUI interactions must be in the main thread.

Thanks for all your suggestions. I think that warning of the problem is more important than not interrupting a large import, so I'll stick to the modal dialog for now.

[kovidgoyal]

If you dont want the dialog to block, dont call exec_

Just calling show will be enough to show the dialog.

[pdurrant]

Originally Posted by kovidgoyal

If you dont want the dialog to block, dont call exec_

Just calling show will be enough to show the dialog.

Ah - this might be a Mac/Unix/Windows difference. On Mac calling show doesn't show the dialog at all, not even behind other windows.

[kovidgoyal]

Strange...do me a favor and open a ticket about it, and I'll add a generic mechanism plugins can use to display messages to the user.

[pdurrant]

Originally Posted by kovidgoyal

Strange...do me a favor and open a ticket about it, and I'll add a generic mechanism plugins can use to display messages to the user.

Thanks. Ticket 4944 added.