Advanced TOC editing - details and others

[icearch]

About Undo, you are right, just close the window if you mess up.

About MoveUp and MoveDown, I'm really not sure, to my test, you can definitely move items that themselves being childern of others, which means that they are not top level right?

See this:





We have C carrying D, and E carrying F, both childern of B.

And we choose E and hit Moveup:





And it definitetly works, so I didn't quite understand what do you mean by move up and down only works on top level items. Could it be a language misunderstanding?

[KevinH]

In your last example, Chapter E when it is the only selection, it is *not* a top level item. By design, MoveUp or MoveDown buttons should have no impact on it. You must first MoveLeft to unindent it, then you can move it Up and Down. If current Sigil is allowing a direct MoveUp or MoveDown it is a bug that will be fixed. That is not how it was originally designed to work.

[icearch]

Well, it works fine enough for me, so I'd call it a feature not a bug.

Jokes aside, why shouldn't it be like this? What problem can happen when moving non top level items?

[KevinH]

No you should not be able to directly move a child of one item to be a child at an unknown level (it may not fit at its current level in the destination) of another item without first promoting it, moving it into position below its future parent then demoting it to be a child of that parent.

[icearch]

Originally Posted by KevinH

No you should not be able to directly move a child of one item to be a child at an unknown level (it may not fit at its current level in the destination) of another item without first promoting it, moving it into position below its future parent then demoting it to be a child of that parent.

I'm assuming you mean move up and down will cause one item jump to other level and/or become other's children.

But no, to my test, in Sigil, move up and down only let items switch place if:

1. Both items are same level

AND

2. Both items have same parent

It does not change level, nor does it switch with other parent's children.

So that is not a problem or bug, and does not work like you described (to my understanding).

[icearch]

And I tested Calibre, to my suprise, it does allow that chaos happen, so Calibre is the one that should fix the bug. Or to make it more restrictive.

That is one reason why I did not suggest just copy what Calibre did, because it's surly kinna chaos and buggy.

[icearch]

See this pic?

Item that can switch:

A with G

B with C with E

Other items can not move up or down, like H can't jump out or switch with B/C/E.

That's it, no chaos, no bugs, just works as it should be.

[icearch]

Originally Posted by KevinH

No you should not be able to directly move a child of one item to be a child at an unknown level (it may not fit at its current level in the destination) of another item without first promoting it, moving it into position below its future parent then demoting it to be a child of that parent.

Oh, I misunderstand you, what you are saying here is right, if you want to move an item to be other's children, you do need to promote (move left) it to a suitable level first, and then indent (move right) it.

But rest assured, what I just said proves that this is totally fine. You would not accidently or deliberately mess the TOC up because you just can't do it in Sigil.

So move up and down should not be restrict to top level, because it's inconvenient, and it's already a well made, bug free function.

[KevinH]

Alright, I spent most of the last 3 days learning about the intricacies of the Qt QStandardItemModel and intelligent selection and preventing changes from needlessly changing indexes of the items.

So this may be a bit flakey, so I have pushed the changes to my personal Sigil repo instead of normal master:

https://github.com/kevinhendricks/Sigil

So if you build your own from source, please git pull from there and rebuild and give those changes a test to see if they do pretty-much what you wanted.

Please let me know of any issues.

If it all works okay, please let me know I will then push these changes to normal Sigil master and they will appear in the next version of Sigil.

[icearch]

How nice, very good of you, sir.

But unfortunately I do not code, so I don't know how to do that.

Maybe when someone have some free time, please make it into an installation exe so I can test it out.

Thanks everyone for their contributions.

[DNSB]

For those using Windows, here is a link to the version with the extended ToC editing: Sigil-2.8.1-Windows-x64-Setup.exe.