Sigil 2.8.0 Released

[KevinH]

But I just checked the PrettyPrintProps.cpp code that generates the default prettyprinter.xml and it properly has span listed as an inline tag, not a block/structural tag.

So something strange is going on. Please shutdown Sigil, go to the Sigil Preferences folder snd delete the prettyprint.xml file then start up Sigil. Sigil should automatically recreate it as default. Then try your mend wnd prettify again. Does the bug still happen?

[DiapDealer]

I'm not experiencing that span behavior in my tests with 2.8.0. They're definitely being treated as inline tags (I'm using the default prettyprint.xml). Can we have them confirm they've not made changes to their prettyprint.xml file already?

EDIT: Never mind. I see you're on it.

[KevinH]

Originally Posted by DiapDealer

I'm not experiencing that span behavior in my tests with 2.8.0. They're definitely being treated as inline tags (I'm using the default prettyprint.xml). Can we have them confirm they've not made changes to their prettyprint.xml file already?

EDIT: Never mind. I see you're on it.

I think somehow the prettyprint.xml got changed at some point, as I can't recreate this span behaviour with Sigil-2.8.0 on my Mac either.

I will keep my fingers crossed it is not a bug, just an accident.

[KevinH]

Okay, I received the sample orig.xhtml and it has spans treated like strutural items. I then imported that file into Sigil-2.7.6 and ran Mend and Prettify. I did the same with Sigil 2.8.0 with Mend and Prettify then diffed the results. They were the same.

No so bug in Sigil.

That said, the image of the output after running Sigil-2.8.0 prettify (see post above) showed no differences in how spans were treated from the original.

This can only happen if that xhtml file was linked to a style-sheet that uses the white-space property. It is a new safety measure added in Sigil 2.8.0.

My guess is that the stylesheet does use one of the css white-space properties and so Sigil 2.8.0 Mend and Prettify did not condense whitespace as it might damage the code.

If the linked stylesheet has whitespace properties set, they should expect few if any changes to whitespace running mending and prettifying.

If you want Mend and Prettify to actually condense whitespace properly. you should remove the use of white-space property in the css and instead wrap the code that needed it in "pre" open and close tags in the right places in the xhtml then remove that use of the white-space property.

My guess is that is what is going on here.

Hope this helps.

Update: hypothesis confirmed in pm, its linked stylesheet used white-space: pre-wrap. So Sigil 2.8.0 is working properly. No bug.

[KevinH]

Originally Posted by odamizu

Hi Kevin,

Everything you wrote above the preceding four paragraphs went right over my head

If you're interested in my 2¢, I would say don't revert and violate proper spec/syntax for "open".

I'll stick with 2.7.6 until I feel the need to upgrade, at which time I will adapt

Thank you,

~oda

I will try a few things to see if I can figure out why BBEdit is not parsing its command line args when it is already opened.

Let me play around and see if I can come up with a some solution for Mac users of Sigil and BBEdit.

Update:

It seems when BBEdit.app (and any other Mac app that supports multiple main windows) is already running, it will only receive FileOpen Apple events and will no longer parse command line arguments.

This is a Mac thing, so it is not a bug in BBEdit.app.

But it is really next to impossible for Sigil to detect if you already have BBEdit open when you use Sigil's "Open With" so Sigil can not change how OpenWith is done dynamically.

That said Sigil's Open With uses the MacOS command line program called "open" and one of open's command line switches (-n) tells the Mac to always open a new version of the app so it will always process its arguments.

The Mac user will then see he/she/they have two instances of BBEdit in the Finder and both will have to be shutdown separately.

So I will play around and make a test build of Sigil with this change for you to play with and let me know if it helps or hurts.

[odamizu]

Originally Posted by KevinH

... So I will play around and make a test build of Sigil with this change for you to play with and let me know if it helps or hurts.

Once again everything you said before the above sentence went over my head. But for this last sentence: Thank you!

[KevinH]

Originally Posted by odamizu

Once again everything you said before the above sentence went over my head. But for this last sentence: Thank you!

Okay, I have tried to handle BBEdit.app without breaking "open with" with other apps.

From my personal repo:

https://github.com/kevinhendricks/Bu...nMac/releases/

grab:

Sigil.app_Mac_arm64.tar.xz

It is signed but NOT notarized.

Please test this version's "Open With" with BBEdit.app and any other "Open With" targets you have set (I tested with the latest gimp and it seemed to work there too).

If it works, please let me know and I will push these changes to master so they are there for the next release. You can keep using this special Sigil 2.8.0 version as it only has this change and one minor earlier bug fix since the official Sigil 2.8.0 for Mac.

I have my fingers crossed.

[PeterT]

I kn ow this might be a stupid thought but could you handle the app launch issues by having Sigil launch a shell script that could be adjusted as needed to hanfle different app launching requirements?

[KevinH]

You could, but I am unsure if macos "open" handles a shell script directly or if you need to run that script in Terminal.app via open. Plus I think I have just pushed a workaround to master that I hope improves things on Mac OS.

If that works, I may change PageEdit code to auto exit when the last window is closed on Mac and launch it via MacOS open with -n to force a new instance of PageEdit each time since the arguments to PageEdit shouldn't ever be ignored if you want things to actually work.

[odamizu]

Originally Posted by KevinH

Okay, I have tried to handle BBEdit.app without breaking "open with" with other apps.

... Please test this version's "Open With" with BBEdit.app and any other "Open With" targets you have set (I tested with the latest gimp and it seemed to work there too).

If it works, please let me know and I will push these changes to master so they are there for the next release. You can keep using this special Sigil 2.8.0 version as it only has this change and one minor earlier bug fix since the official Sigil 2.8.0 for Mac.

I have my fingers crossed.

SUCCESS! Thank you so much! I only use BBEdit with "Open With" and it worked like a charm. You are awesome, per usual

[KevinH]

Glad to hear it!