Trouble saving Controls for Saved Search

[KevinH]

Also, the SearchEditor model uses a Singleton pattern, which means one instance is shared across all open Sigil Windows. On macOS we can have multiple MainWindows open at the same time in the same Sigil app instance.

So please make sure you have only one Sigil Main Window open when testing just to rule out ownership issues. Please close any other Sigil Main Windows before running any tests.

[KevinH]

Wow that is very strange. I will have to think about that. There must be some uninitialized variable issues going on.

Originally Posted by phillipgessert

Sorry, yes--I meant I was able to successfully populate the Controls field by saving the search via the f/r window, and once that was done I was able to modify it via the Saved Search window. And that worked for 1.8 and the Qt6 beta version.

Glad to try out that debug--it may be tomorrow before I can come back to it, but I surely will.

[phillipgessert]

I am fairly sure that I closed one before opening the other because I was worried about something like that. I also checked which one I had open in the Dock to be sure. But I’ll also be extra sure I’m careful about that next time I try it, in case I made a mistake.

[KevinH]

Two thoughts ...

Are you sure the Controls column was even visible in your Saved Search Editor window before you added to the Controls field by using Find and Replace. Could what you entered just be hidden off screen?

Also Saved Search Group headings do not have columns that are editable. If you by accident double-clicked on the Controls field but got a Group name row, any Controls changes would be ignored as only actual find and replace entries have controls settings, not groups. Could it have been that?

[phillipgessert]

Yes, it was visible—actually, I learned of it via another thread here not too long ago where you (I think) recommended someone expand that window so they could see it. I remember being pretty excited to see for myself. After expanding it, I double-clicked into it to edit the field—so I’m sure it was visible then, it’d have to have been. And after making my changes, none of the two-character codes described in the User Guide for that field appeared there—but they do when I save it via the Find/Replace window instead. And I wasn’t clicking into a group for it, I was trying it via one specific search that’s at the top level, not in any group, or near one, so I doubt I misclicked.

[phillipgessert]

Oh, in case this helps—even though it wasn’t updating that field, I also tried loading it in and running the search anyway before making the thread. And when I did, my attempted changes weren’t reflected in the F/R window either (the mode didn’t change).

[BeckyEbook]

My guess:
The controls have their "requirements".
To save them, you need to select them in the right order and in specific "stages".
First, we fill in the bottom row (Mode, Target and Direction)*, and then checkboxes above.
* Filling these three elements is kind of obligatory.

If we do so, the controls will definitely be saved.

[phillipgessert]

Hmm, I only changed the mode and left everything else unchanged. Perhaps I should try changing everything as a test?

[KevinH]

Well if so, that is not what the code says should happen.
There should be no "order requirement" as long as all pulldowns have a selection made, it should work in any order. Check boxes can all be blank but pull downs must all have a value.

Are you seeing this bug on Windows as well. I can not recreate it on any of my builds. I will try again but remove the saved search v2 file ini file first to see if that makes the problem appear?

Originally Posted by BeckyEbook

My guess:
The controls have their "requirements".
To save them, you need to select them in the right order and in specific "stages".
First, we fill in the bottom row (Mode, Target and Direction)*, and then checkboxes above.
* Filling these three elements is kind of obligatory.

If we do so, the controls will definitely be saved.

[BeckyEbook]

Are you seeing this bug on Windows as well. I can not recreate it on any of my builds. I will try again but remove the saved search v2 file ini file first to see if that makes the problem appear?

After deleting sigil_searches_v2.ini file, I have the same "symptoms".
I have to choose a minimum of three settings at the bottom (mode, target, direction) for the controls to be saved.
In fact, I thought it was meant to be.
Sigil 1.8.0 + current master.

[KevinH]

It is. To be valid, all pulldowns must have a value. This is not a bug or a symptom. It is needed for a search to be validly specified.

There is no "order", but anything would would specify in Find and Replace must be set for it to work.

So is this all just a misunderstanding of how to use controls?

[BeckyEbook]

Originally Posted by KevinH

So is this all just a misunderstanding of how to use controls?

I really know how the controls work, but I had a assumption that @phillipgessert sets too few of them and hence the problem.

[phillipgessert]

That is indeed the problem. Sorry for the trouble, but thank you both for the help. I wrongly assumed leaving other options unset meant "do nothing" AKA if you only change the mode, then only the mode will change in the F/R window. When I set all three, it works.

[KevinH]

Glad to hear it! Please note: if you set controls on the first search entry in group of searches, all remaining searches will inherit those controls until an entry with new a new Controls value.

So for multiple searches all ina group using the same controls, all you have to do is set the controls for the starting search entry.

And Thanks to BeckyEbook for figuring out what was going on!

[phillipgessert]

Thanks for the tip about the groups--excited to use this feature now that I understand it better. And sorry you had to go to the trouble of making those builds for me when the problem turned out to be cranial!