[Plugin] cssUndefinedClasses

[odamizu]

Originally Posted by DNSB

More that I expect to have issues with new OS releases. Apple and Microsoft seem to playing games with their security models and that has caused problems for me with quite a few programs. Those issues are probably best handled by being reported on the issues section of the Sigil GitHub page.

The issue I reported relates to 2 plugins created by one developer. The issue did not appear with any other plugin I tried, so it's not an across-the-board Sigil plugin issue — which is why I didn't post this in the general Sigil forum or create a new thread in the Plugin forum, but instead posted very specifically in the thread of one of the affected plugins. I'm not sure if the plugin developer would see it if I posted in Sigil's GitHub. Is it really so terrible that I posted this on MobileRead?

Also, thanks to KevinH I have a simple workaround/solution and I'm not asking any developer to recode anything.

[DiapDealer]

This is one of the reasons I've given up on using Tk for Sigil plugin GUI interfaces. Too many platform-specific quirks (not to mention that macOS is the only one smart enough to automatically match Tk to the light/dark os theme). Pop-unders have been a problem on all platforms at different times.

I never did warm up to Tk. I was never able to get a good feel for it (programmatically speaking). It just never felt intuitive to me.

But I'm glad you found a workaround for the issue! I wouldn't dream of suggesting that plugin devs overhaul their plugins to use PySide instead. "If it ain't broke," and all that.

[wrCisco]

Hi, sorry for the delayed response, I read just today the notification for the updates in this thread.

Odamizu, did the workaround of KevinH solved the problem for good or do you need to click on the plugin's icon every time? I wrote a function that could possibly force the window to the top of the windows's stack, but I don't have a Mac so I cannot test it. If you're still experiencing the problem, can you test if one of the two betas that I attached to this post solves it?

@DiapDealer: what do you mean, it's not intuitive? To show a scrollable list of checkbuttons I just had to create a text widget, attach manually to it a vertical scrollbar and bind the movement of each one to the other, then for every checkbutton I inserted a 'window' at the end of the text widget and set the checkbutton background color (which cannot be transparent) to match the one of the text widget, then set the 'wraplength' property of the checkbuttons's style to be equal to the window minus my guess about the width of the scrollbar and the margins and update this value every time the user resizes the window. After that I just needed to specify that I want the text widget to scroll when the mousewheel is used and add all the checkbuttons to the 'bindtags' of the text widget (or the mousewheel wouldn't work when the cursor is over a checkbutton or its label). If this is not intuitive to you, what is?

[odamizu]

Originally Posted by wrCisco

... Odamizu, did the workaround of KevinH solved the problem for good or do you need to click on the plugin's icon every time? I wrote a function that could possibly force the window to the top of the windows's stack, but I don't have a Mac so I cannot test it. If you're still experiencing the problem, can you test if one of the two betas that I attached to this post solves it?

With 0.2.2, I do need to click on the plugin's icon every time. Though this is not a big deal and doesn't bother me. Also, interestingly, the plugin works lightning fast on macOS Sequoia (after clicking the icon). Same with cssRemoveUnusedSelectors — need to click plugin icon every time but it's lightning fast on Sequoia.

I tried 0.2.3beta1 and 0.2.3beta2 — same result. Still need to click on plugin icon every time. But it's not a big deal. Thanks for trying.

Interestingly, with the KindleImport plugin, I needed to click on the plugin icon the first time, after which it runs automatically. Interestingly, with KindleImport plugin, the icon bounced in the Dock, which caught my attention and prompted me to click on it. But with cssUndefinedClasses and cssRemoveUnusedSelectors the icon did not bounce (which is why I didn't click on it before KevinH suggested I do so). Not sure if that's relevant, but I offer that info to be thorough.

[DiapDealer]

Originally Posted by wrCisco

If this is not intuitive to you, what is?

Well, when you explain it THAT way.

[DiapDealer]

Originally Posted by odamizu

Interestingly, with the KindleImport plugin, I needed to click on the plugin icon the first time, after which it runs automatically. Interestingly, with KindleImport plugin, the icon bounced in the Dock, which caught my attention and prompted me to click on it. But with cssUndefinedClasses and cssRemoveUnusedSelectors the icon did not bounce (which is why I didn't click on it before KevinH suggested I do so). Not sure if that's relevant, but I offer that info to be thorough.

KindleImport uses PySide. Even given that, it's still a bit of a special case. It's an fileOpenDialog with no parent widget. That might be why it popped under the first time. I've no idea why it bounced, though. Perhaps it's something inherent to PySide. I certainly did nothing to try and make it bounce in the Dock.

[odamizu]

Originally Posted by DiapDealer

... I've no idea why it bounced, though. Perhaps it's something inherent to PySide. I certainly did nothing to try and make it bounce in the Dock.

I did not explain myself well. When an app needs attention (any app, not just KindleImport), it bounces in the Dock. Usually there's a pop-up window that requires you to make a choice or select "okay" or "cancel" or something. So when I saw KindleImport bouncing, I knew to click on it to see what it wanted. But cssUndefinedClasses didn't bounce. It just got stuck saying, "running ... running ... running" and never finishing. Now I know it's just shy and needs me to click on it even though it's not bouncing

[DNSB]

One oddity with this plugin is that when an ID is referenced by an aria-labelledby, the ID is seen as unused and removable. The next step is an error message from epubcheck.

<nav epub:type="toc" role="doc-toc" aria-labelledby="toc">
<h1 id="toc">Contents</h1>

<section aria-labelledby="cont" epub:type="toc" role="doc-toc">
    <hgroup>
    <h1 class="FMH" id="cont">Contents</h1>
    </hgroup>

OEBPS/Text/contents.xhtml	11	474	Col: 64: ERROR(RSC-005): Error while parsing file: The aria-labelledby attribute must refer to elements in the same document (target ID missing)
OEBPS/Text/nav.xhtml		10	368	Col: 59: ERROR(RSC-005): Error while parsing file: The aria-labelledby attribute must refer to elements in the same document (target ID missing)
OEBPS/Text/nav.xhtml		77	2429	Col: 54: ERROR(RSC-005): Error while parsing file: The aria-labelledby attribute must refer to elements in the same document (target ID missing)
OEBPS/Text/nav.xhtml		94	3004	Col: 78: ERROR(RSC-005): Error while parsing file: The aria-labelledby attribute must refer to elements in the same document (target ID missing))

[wrCisco]

I was really convinced that I set immediate email notifications for this thread, while weekly notifications were set, that should now be fixed.

As for the issue at hand, the plugin by default uses the attributes href, epub:textref and src to search for fragment identifiers, and the users can visualize and edit this list in the preferences of the plugin. So, DNSB, for your specific problem, you should be able to add 'aria-labelledby' to that list by clicking on the "Preferences" button after launching the plugin.

It would probably be better if the aria attributes were included in the search by default, I will look into it for a new release shortly.

[DNSB]

Thanks for the tip. Seems to be happy now.

[wrCisco]

I just uploaded in the first post of this thread the version 0.2.3 of the plugin, with an expanded set of attributes that will be used to search for id references and an embedded tk theme for the Linux UI.

Let me know if there are any problems.