E-book viewer: "Lookup words" window

[iG0R]

Sorry, my bad, it has to be

if (window.location.hostname === 'www.google.com') {
    window.addEventListener('DOMContentLoaded', fix_google_markup());
}

to work properly.

[DNSB]

Originally Posted by iG0R

Hm, it's weird. Look at my screenshots.
I don't have any possibility to choose my account although I've already signed in my account in Chrome browser.
Also I found the following thread https://support.google.com/chrome/thread/31420989?hl=en

I wonder if this might be due to having a Chromium based browser (Microsoft's replacement for Edge) installed as well as Chrome and Firefox? I agree it is a bit weird.

[kovidgoyal]

Originally Posted by iG0R

Sorry, my bad, it has to be

if (window.location.hostname === 'www.google.com') {
    window.addEventListener('DOMContentLoaded', fix_google_markup());
}

to work properly.

No, that's wrong. If you add () it means the function is called when the script is loaded instad of when the DOM is ready.

[kovidgoyal]

And it works fine for me

[iG0R]

Originally Posted by kovidgoyal

No, that's wrong. If you add () it means the function is called when the script is loaded instad of when the DOM is ready.

Then without () it doesn't work for me leaving header and big margins as was abovementioned in my screenshot I'm using 4.13 version could it work properly in your case due to you utilize version with Python 3.x support?

[kovidgoyal]

I dont see how the python version would have any effect on javascript running inside the browser and it works for me with python 2 as well. it might be a timing issue since the google page is JS based as well. Try changing it to:

window.addEventListener('DOMContentLoaded', function() { setTimeout(fix_google_markup, 100); } );

[iG0R]

Originally Posted by kovidgoyal

I dont see how the python version would have any effect on javascript running inside the browser and it works for me with python 2 as well. it might be a timing issue since the google page is JS based as well. Try changing it to:

window.addEventListener('DOMContentLoaded', function() { setTimeout(fix_google_markup, 100); } );

Still the same result even with 5000 - big margins and header.

[kovidgoyal]

right click on it open the inspect tool and see why its not working for you

[iG0R]

Originally Posted by kovidgoyal

right click on it open the inspect tool and see why its not working for you

I've already tried it but after clicking "View page source" nothing happens the same as while clicking "Save page". Only working context menu's items are - Back, Forward, Reload, Zoom in, Zoom out, Default zoom.

Also I've tried to modify lookup.js to change CSS but faced with the strange results.
lookup.js:

Spoiler:

/* vim:fileencoding=utf-8
 * 
 * Copyright (C) 2019 Kovid Goyal <kovid at kovidgoyal.net>
 *
 * Distributed under terms of the GPLv3 license
 */

(function() {
    "use strict";

    function fix_google_markup() {
        var cc = document.getElementById('center_col');
        cc.style.marginLeft = '0';
        cc = document.getElementById('cnt');
        if (cc) cc.style.paddingTop = '0';
        var params = new URLSearchParams(document.location.search.substring(1));
        var q = params.get('q');
        if (q && q.startsWith('define:')) {
            cc.style.position = 'absolute';
            cc.style.top = '0';
            cc.style.left = '0';
            var remove = ['sfcnt', 'top_nav', 'before-appbar', 'appbar', 'searchform', 'easter-egg'];
            remove.forEach(function(id) {
                var elem = document.getElementById(id);
                if (elem) elem.style.display = 'none';
            });
        }
        var promo = document.getElementById('promos');
        if (promo) promo.parentNode.removeChild(promo);
    }

        var css = [
	"* {",
	"background-color: #fef3df !important;",
	"color: black !important;",
//	"border-color: #fef3df !important;",
	"}"
	].join("\n");

/*Block#1*/
	if (typeof GM_addStyle != "undefined") {
		GM_addStyle(css);
	} else if (typeof PRO_addStyle != "undefined") {
		PRO_addStyle(css);
	} else if (typeof addStyle != "undefined") {
		addStyle(css);
	} else {
		var node = document.createElement("style");
		node.type = "text/css";
		node.appendChild(document.createTextNode(css));
		var heads = document.getElementsByTagName("head");
		if (heads.length > 0) {
			heads[0].appendChild(node);
		} else {
			// no head yet, stick it whereever
			document.documentElement.appendChild(node);
		}
	}
/*End#1*/

	if (window.location.hostname === 'www.google.com' || window.location.hostname === 'translate.google.com') {
        window.addEventListener('DOMContentLoaded', function() { setTimeout(fix_google_markup, 5000); } );
/*Block#2*/
//		if (typeof GM_addStyle != "undefined") {
//			GM_addStyle(css);
//		} else if (typeof PRO_addStyle != "undefined") {
//			PRO_addStyle(css);
//		} else if (typeof addStyle != "undefined") {
//			addStyle(css);
//		} else {
//			var node = document.createElement("style");
//			node.type = "text/css";
//			node.appendChild(document.createTextNode(css));
//			var heads = document.getElementsByTagName("head");
//			if (heads.length > 0) {
//				heads[0].appendChild(node);
//			} else {
//				// no head yet, stick it whereever
//				document.documentElement.appendChild(node);
//			}
//		}
/*End#2*/
	}

/*Block#3*/	
//	if (typeof GM_addStyle != "undefined") {
//		GM_addStyle(css);
//	} else if (typeof PRO_addStyle != "undefined") {
//		PRO_addStyle(css);
//	} else if (typeof addStyle != "undefined") {
//		addStyle(css);
//	} else {
//		var node = document.createElement("style");
//		node.type = "text/css";
//		node.appendChild(document.createTextNode(css));
//		var heads = document.getElementsByTagName("head");
//		if (heads.length > 0) {
//			heads[0].appendChild(node);
//		} else {
//			// no head yet, stick it whereever
//			document.documentElement.appendChild(node);
//		}
//	}
/*End#3*/


})();

Blocks #2 and #3 don't work for 'translate.google.com', i.e. Google Translate aren't changing at all - as it was "white" it still remains "white". But for 'www.google.com' all Blocks (#1, #2, #3) work perfect.

[iG0R]

I tried your latest commit

        if (!cc) {
            if (++num_tries > 10) return;
            setTimeout(fix_google_markup, 100);
            return;
        }

but result still the same - big margins and presence of header.

[kovidgoyal]

There is an inspect entry in the menu which you should use, at least there is one if you are actually running from source. https://manual.calibre-ebook.com/develop.html

[iG0R]

Originally Posted by kovidgoyal

There is an inspect entry in the menu which you should use, at least there is one if you are actually running from source. https://manual.calibre-ebook.com/develop.html

I get it. I didn't run Calibre from source, was hoping to get off easy.