Having difficulty moving .html files in Book Browser in 1.1.0

[KevinH]

Snooped a bit more in Qt's online docs ....

In Sigil, a ContentTab inherits from QWidget and according to the docs, if we overload this QWidget routine and ignore the event (controllable by setting a variable) it will not be able to be dragged.

if this event is ignored, it will not receive any drag move events.

void QWidget::dragEnterEvent(QDragEnterEvent * event);

So we could add a enableDrag() and disableDrag() routine to ContentTab.cpp and then overload this routine and enable individual tab drag and drop behaviour.

And then every time a new tab becomes the current tab, we enable it and disable all of the others, so that only a current tab will be draggable (at least in theory!).

So it should be doable.

KevinH

[DiapDealer]

Sounds good in theory.
So long as it's not too invasive to implement. I know there's tons of places where we're closing tabs before running procedures and then reopening them.

[KevinH]

Let's try the "force the drag to be current" approach first to see if it does the trick.

[najgori]

shortcuts rulez, imho.

[DiapDealer]

Originally Posted by KevinH

Let's try the "force the drag to be current" approach first to see if it does the trick.

I didn't see any difference in behavior with:

setAcceptDrops(true);
setChangeCurrentOnDrag(true);

Added to Tabs/TabBar.cpp.

Do you see any of the odd behavior RE inactive tabs on Mac?

[KevinH]

Sorry not at a dev machine right now and leaving for class in a few minutes. Will check tonight and get back to you.

[DiapDealer]

No problem. There's a mac build out there where I added the properties if you want see if there's any different behavior for macOS with them enabled, but I've since reverted the change.

[BetterRed]

The OPs issue isn't repositioning the horizontal tabs in the CV window. He is having difficulty moving .html files [up and down] in Book Browser in 1.1.0.

Are they the same thing internally?

BR

[DiapDealer]

We're off on a bit of a tangent right now, yes. But as I mentioned in post #6, the dragDistance setting is an app-level setting. Making the drag distance smaller for Book View will come at the expense of making tab reordering more finicky.

[Gregg Bell]

Originally Posted by KevinH

Click on them and start to drag. Wait momentarily for the drag animation to start. Move to where you want in the spine order and release. This works just fine in my machine (a mac). What platform are you using?

Windows 10 Pro. 1909 64 bit (HP computer) Thanks. That helped, but it's still a little dicey and much diceier than on older Sigil versions.

[Gregg Bell]

Originally Posted by DNSB

I've noticed that I might have to move the file a couple of positions before it looks as if it is starting to move (the divider line appears). I.e., I want to swap last two files Section0009 and Section0010, I grab Section0010, drag it up past Section0007 and then back down until the divider positions between Section0008 and Section0009.

OS is Windows 10, x64. Sigil is 1.1.0 x64

Yeah, thanks. It seems the delay is the key.

[Gregg Bell]

Originally Posted by theducks

I also noted that trying to move to the #1 slot was a pain (can't go above easily).
My work around: Move to #2 slot, then drag #1 down to #2 slot

I've done something similar on the bottom two files.

[The_book]

Originally Posted by DiapDealer

@KevinH: got a spur-of-the-moment (not-very-well-thought-out) what-if for you.

In my mind, there is no need to be able to reorder any tab other than the one that is currently active. If one had to first activate a tab and then grab it again in order to move it in relation to the others, this whole twitchy inactive tabs thing wouldn't be an issue.

Since we already subclass QTabBar and reimplement a few things, is there any way could reimplement something that could prevent moves for any tab that wasn't already active when first clicked?

I know that's vague as heck, but I don't have any of Qt's QTabBar source in front of me.

If what I understood is true, you mean you want move only the active tab. So in this case, can we move multiple files? Or we will in a situation that only allow moving single file?

[DiapDealer]

I fear the conversation has introduced some confusion. Moving multiple files in book browser has nothing to do with what Kevin and I are talking about. Nothing will change with how moving files in book browser works (except for hopefully getting a little easier). The ability to reorder multiple open tabs tabs has never been supported in Sigil.

[KevinH]

Just finished building the version before your revert and I could not perceive any differences at all.

Do you want me try coding up the disable/enable movement by a ContentTab to see if that is workable?

KevinH

Originally Posted by DiapDealer

I didn't see any difference in behavior with:

setAcceptDrops(true);
setChangeCurrentOnDrag(true);

Added to Tabs/TabBar.cpp.

Do you see any of the odd behavior RE inactive tabs on Mac?