Suggestions before releasing version 1.0

[theducks]

+1 to BR
I am down to 1 eye. I use dark theme to avoid glare when possible.

[DiapDealer]

Originally Posted by BeckyEbook

Even now, h* doesn't work perfectly (depending on what state Sigil was closed in). If it was a 16px icon – it incorrectly switches to larger icon sizes when moving the slider. If it was a 22px or 48px icon – it should be fine.

Not quite sure what you mean here. It works (and is designed) exactly as all of Sigil's other menubar icons do. Each of Sigil's icons (h* included) are represented with three distinct sizes (16px, 22px, and 48px) which are chosen by MainWindow depending on resolution and icon size-slider setting. I may not like how the icon itself looks (aesthetically speaking), but it's behaving precisely as it was intended to.

If it doesn't switch sizes in lockstep with the other icons, that's probably because it's a QToolButton rather than a QAction. There's no adjustment that can be made, and it would be the same regardless of the icon that was being used in it's place. In short: it's Qt's fault, and not the icon's.

[Turtle91]

Gah!! Another Sigil Function (ASF) that I had no idea existed... I didn't realize there was a Menus tab on the Appearance page of Preferences...I've just been squinting REALLY hard at the small icons...

ThankyouThankyouThankyouThankyouThankyouThankyouTh ankyouThankyou

[odamizu]

All this talk of revisions to better suit Dark Theme is starting to make me nervous.

Is Sigil moving away from Light Theme? Or simply creating more options for Dark Theme so that it can support both Light Theme and Dark Theme?

I actually cannot use apps or read website that use Dark Theme as it does funny things to my vision. Hard to describe but I get temporary blindspots after trying to read light text on dark backgrounds.

[BeckyEbook]

I guess nobody wants to delete the default (light) theme. It's only about the choice of light/dark.

[un_pogaz]

#3 +10
The border of the main window is a detail, but once I notice it I find it ugly.
Yes, it is the main window, but the other windows delimit it.

Also, I just noticed that the "Preview" window does not have an internal border like the others (TOC, Book navigator, Clips)

[DiapDealer]

Originally Posted by odamizu

All this talk of revisions to better suit Dark Theme is starting to make me nervous.

Is Sigil moving away from Light Theme? Or simply creating more options for Dark Theme so that it can support both Light Theme and Dark Theme?

It's only the latter. No worries. Sigil's default will likely always be a Light theme. We just don't want Sigil actively resisting a Dark Theme. Qt is supporting MacOS's Dark Mode more and more (and I expect it to eventually honor Windows's Dark Theme). Many Linux OSes also sport Dark Themed Desktops. We just don't want to be caught flat-footed in being able to more easily support what is clearly becoming more and more in demand.

[KevinH]

Okay, I have pushed changes to implement Nos. 1 (? QWhatsThis), 4 (prettifying empty xhtml files), and 6 (extended support for other. type Guide semantics).

For 6, I have extended the list of recognized guide items to include many of the other.* codes that directly map to epub3. These codes will be recognized by the ncxgenerator.py code as well, as well as epub3-itizer.

I will look into how the h* icon size is determined, as well. The case change icon is simply a text string which we could replace if someone would design a better icon for us! ;-)

[BeckyEbook]

Originally Posted by KevinH

Okay, I have pushed changes to implement Nos. 1 (? QWhatsThis), 4 (prettifying empty xhtml files), and 6 (extended support for other. type Guide semantics).

For 6, I have extended the list of recognized guide items to include many of the other.* codes that directly map to epub3. These codes will be recognized by the ncxgenerator.py code as well, as well as epub3-itizer.

I just noticed new commits.
I already have a private build.
Thank you! My possible Pull Request would not be so cool.

#1 & #4 – great.
#6 – I'm impressed. I didn't think about it myself, and that's a brilliant idea! While working on epub2 you can now use additional semantics.
I have only two comments (look at the attachment):
1. With "Rear Notes" there is a round bracket and no closing
2. "Footnotes" is missing (I checked the statistics and this is the most popular custom semantics epub2 ebooks in Polish). epub3-tizer already support other.footnotes.

--- * ---

#2 and #3 can be thought more carefully if the work on dark theme support were programmed.
Then the frame color and link color would be adjusted to all dark UI.

--- * ---

Originally Posted by KevinH

I will look into how the h* icon size is determined, as well. The case change icon is simply a text string which we could replace if someone would design a better icon for us! ;-)

I will prepare three new icons for the case format. Maybe even today.

@DiapDealer - I know that the problem with h* is icon related to Qt and in normal use is not a problem.

--- * ---

And by the way I looked at these new changes in the upcoming Calibre 4.5 and I'm also impressed. I'm just using the dark theme for Windows 10.
@kovidgoyal approached this problem very comprehensively and worked out his solution step by step.
MacOS/Linux users can use the CALIBRE_USE_DARK_PALETTE variable, and for Windows 10 users, all they need is dark theme on the system.
Of course @kovidgoyal also solved the problem #2 – the blue color of the links with the dark theme turned on is lighter.

If @KevinH and @DiapDealer will have spare capacity in the future – it's worth taking a look at the interesting solutions that are implemented in Calibre.

[KevinH]

And I have grabbed a premade icon from the open icon library to fix No. 5 (case change icon).
I am not happy with this icon, but this change should make it easier if someone an design a better icon set.

[KevinH]

Originally Posted by BeckyEbook

I have only two comments (look at the attachment):
1. With "Rear Notes" there is a round bracket and no closing

Typo, I can fix that.

2. "Footnotes" is missing (I checked the statistics and this is the most popular custom semantics epub2 ebooks in Polish). epub3-tizer already support other.footnotes.

I was going to add it but technically Footnotes appear at the bottom of the page and therefore could appear multiple times.

Since guide items must be unique, I removed things that would need or require multiple guide items. So I removed things like Volume, Chapter, SubChapter, Part, Footnotes, etc, and kept things that should always be unique such as RearNotes.

I can add in Footnotes, but then the epub2 developer must not try to set multiple items with that guide code, unlike epub3 landmarks which can be used multiple times.

I will prepare three new icons for the case format. Maybe even today.

@DiapDealer - I know that the problem with h* is icon related to Qt and in normal use is not a problem.

Great, just replace case-change_16px.png, case-change_22px.png, and case-change_48px.png in Sigil/src/Resource_Files/main/.

Please keep the file names, just replace their contents.

KevinH

[KevinH]

Added back Footnotes since often actually used. Fixed typo. And updated the base for translations hopefully the last time.

[BeckyEbook]

Originally Posted by KevinH

I can add in Footnotes, but then the epub2 developer must not try to set multiple items with that guide code, unlike epub3 landmarks which can be used multiple times.

All files had this semantics set only once, moreover in the case of epub2 files – the semantics apply to the entire file – usually it is a separate file, so footnotes = endnotes. I don't think anyone would set footnotes if they were actually in the same file as the text of the book.

Of course I can imagine this structure:
- text01.xhtml
- footnotes01.xhtml
- text02.xhtml
- footnotes02.xhtml
- text03.xhtml
- footnotes03.xhtml
and then and only then it would matter.

So I'm in favor of adding other.footnotes, but I'd love to hear a different opinion.

Edit: You are very fast.
After all, I will leave this post as an explanation for others.

[DiapDealer]

Originally Posted by BeckyEbook

And by the way I looked at these new changes in the upcoming Calibre 4.5 and I'm also impressed. I'm just using the dark theme for Windows 10.
@kovidgoyal approached this problem very comprehensively and worked out his solution step by step.
MacOS/Linux users can use the CALIBRE_USE_DARK_PALETTE variable, and for Windows 10 users, all they need is dark theme on the system.

I'll be very interested in taking a look at his approach. To be honest, upgrading to Windows 10 1909 is the only reason I know that Windows even HAS a dark theme. I'm sure it was there earlier, but I never saw it.

EDIT: I see he's basically using the approach that everybody is using: using QPalette to get most of the way there, and then QStyles and icons to get the rest of the way (plus checking the Windows registry key for LightMode/DarkMode). Nothing fancy, just a ton of icon work I don't relish the thought of undertaking. Not to mention tackling the basic hurdle of being able to easily override Sigil's icons (which is been a part of calibre for a long, long time). In other words ... work. Ugh. I was hoping for a magic button.

[KevinH]

So you are looking for any easy way to specify epub version for new other than just using the already provided preference setting?

Instead of using submenus ... perhaps an icon that toggles epub version settings between epub2 and epub3 might be better.

KevinH

Originally Posted by RbnJrg

Maybe you can implement something like this: