Sigil 0.8.5 Random Crashes

[DiapDealer]

Originally Posted by KevinH

Does gdb now handle scripts that use exec directly on the command line and do the right thing?

Not that I'm aware of.

[KevinH]

Originally Posted by DiapDealer

Not that I'm aware of.

Then I am hoping that bugs on linux are so rare we never have to add a --debug option to the script!!! ;-)

[DiapDealer]

Originally Posted by KevinH

Then I am hoping that bugs on linux are so rare we never have to add a --debug option to the script!!! ;-)

Nah... we'd just make a separate super-secret debug launch script.

Actually ... it might not be a bad idea to include (or make a available) a special launch script with sigil attached to gdb with all the environment stuff set, IF ... bugs on linux started showing up in droves. Of course, I've usually found that those who know their way around gdb won't have trouble getting things launched anyway (and for those that don't know their way around gdb ... well they're going to struggle regardless).

[aJuanJo]

Hello, I had the same issue. I just "SAVE AS.." every time I do a change.... it's something strange.
Anybody's help!!!!, please
JuanJo

Originally Posted by SuicycoMania

Yesterday, I downloaded, and installed the new 0.8.5 (64-bit Windows) version of Sigil (upgrading from v0.8.4). Ever since I upgraded, I am getting random crashes when deleting items from the "Text" section.

Does not happen all the time. It is a completely random thing. I can even go back in to Sigil after a crash, and try and delete the same item, and be successful. So I know it is not a specific item.

Does not seem to be an overall file size issue. I have tried on an EPUB file over 5 MB and also on one than was less than 400 KB. It eventually will crash.

Does not matter if it is one item or many items that I try and delete. It has crashed when trying to delete one item, and it has crashed when trying to delete several items at once.

The main actions I use are (if that helps any):
"Delete Unused Media Files"
"Delete Unused Stylesheet Classes"
"Validate EPUB with FlightCrew"
But the crashes only occur when I try and delete an item from the "Text" section.

So, right now... I either go back to 0.8.4 or continue to do a Save after each action I do so as not to lose what I have done.

Anyone else experiencing this issue?

[aJuanJo]

Originally Posted by DiapDealer

I also have an alternate Windows version of 0.8.5. It's not entirely the same as the official Windows Sigil package, so I would prefer that issues involving it be posted in its own thread (same with the Linux binary packages). My binaries are completely unofficial. Any weird behavior with them could very well be something I did wrong when creating them.

So please... if you're experiencing issues using one of my unofficial binary packages, report those issues in the thread for that package. If I (or anyone) can reproduce the issues in an officially supported build of Sigil, then the appropriate action can be taken. Until then, remember that they're unofficial for a reason.

Yes DiapDealer, I have installed yours, because official wouldn't finish to start, it was running in background and not to open. So my crashes are with your unnoficial 0.8.5, which works at least.
Thanks anyway to you too.
hahaha
JuanJo

[KevinH]

Hi aJuanJo,

Actually providing some information in your crash report would help.

1. What OS? What AV software are you using?
2. Have you tried temporarily disabling your anti-virus programs?
3. Have your tried deleting the older version's setting files?
4. Have you checked to see if you have bad or broken openssl dlls in your path? Look for copies of libeay32.dll and ssleay32.dll that have been installed in the path. If these exist, you should probably replace them with known good versions by downloading OpenSSL 1.0.1l version and putting the 2 files libeay32.dll and ssleay32.dll into the same folder as sigil.exe.
5. Have you tried updating your graphics driver to the latest version from Microsoft? Bad graphics drivers cause many many crashing problems on Windows. There have been numerous Qt5 issues with outdated ati graphics drivers.

KevinH

[Camelot]

Good news, i can reproduce

Double-click on second last site, the site must see on Book View.
Then right-click on last site and merge or Ctrl+M (1-3×).
When click on the outsite last site = crash.

Here the gdb output:

Program received signal SIGSEGV, Segmentation fault.
0x00007ffff3bb1880 in QArrayData::shared_null ()
   from /usr/local/share/sigil/libQt5Core.so.5
(gdb) 
(gdb) bt
#0  0x00007ffff3bb1880 in QArrayData::shared_null ()
   from /usr/local/share/sigil/libQt5Core.so.5
#1  0x000000000061400e in TabManager::CreateTabForResource(Resource&, int, int, QString const&, MainWindow::ViewState, QUrl const&, bool) ()
#2  0x000000000061471a in TabManager::OpenResource(Resource&, int, int, QString const&, MainWindow::ViewState, QUrl const&, bool) ()
#3  0x00000000008659ed in MainWindow::OpenResource(Resource&, int, int, QString const&, MainWindow::ViewState, QUrl const&, bool) ()
#4  0x00000000008df600 in ?? ()
#5  0x00007ffff379ae7a in QMetaObject::activate(QObject*, int, int, void**) ()
   from /usr/local/share/sigil/libQt5Core.so.5
#6  0x00000000008cd575 in BookBrowser::ResourceActivated(Resource&) ()
#7  0x00000000008a7c74 in BookBrowser::EmitResourceActivated(QModelIndex const&) ()
#8  0x00000000008dadfe in ?? ()
#9  0x00007ffff379ae7a in QMetaObject::activate(QObject*, int, int, void**) ()
   from /usr/local/share/sigil/libQt5Core.so.5
#10 0x00007ffff79108a5 in QAbstractItemView::activated(QModelIndex const&) ()
   from /usr/local/share/sigil/libQt5Widgets.so.5
#11 0x00007ffff795e455 in QTreeView::mouseDoubleClickEvent(QMouseEvent*) ()
   from /usr/local/share/sigil/libQt5Widgets.so.5
#12 0x00007ffff76ee256 in QWidget::event(QEvent*) ()
   from /usr/local/share/sigil/libQt5Widgets.so.5

i attached my example epub
I hope this help.

[KevinH]

Hi Camelot,

Excellent work! I can reproduce it even on Sigil master with Mac OS X but to do it I must quickly hit Command-M multiple times in a row and be in BookView. If I use the menus, I never seem to hit it.

None of this code has been touched in quite a while so this bug has probably existed in all previous versions of Sigil as far as I can tell. I will try and figure out what is causing the problem and get it fixed.

Thanks!

Kevin

[KevinH]

Hi Camelot,

Well I found the problem. By doing the merges so fast, you can end up with stale data in the BookBrowser (the widget you posted a graphic of) and stale data in the FolderKeeper m_Resources hash (the universal list of all resources available).

Randomly a Qt garbage collection thread deletes the resource but the signal that tells the FolderKeeper to update itself (remove the resource from its m_Resources hash) has not reached it yet. The second merge then hits this stale info (or some other action that wants the list of all available html resources).

The following patch fixes this on my Sigil master and should work exactly the same (but with a large offset in line) in Sigil 0.8.5 source as well when applied at the end of the MergeResources routine in Book.cpp.

The recent fix for closing Tabs when deletes are done may have exacerbated this by disconnecting the signal from the underlying resource when closing the tab but given the resource was deleted it should not have mattered.

For BookManipulation/Book.cpp

@@ -903,6 +903,9 @@ Resource *Book::MergeResources(QList<Resource *> resources)
         sink_html_resource.SetText(new_source);
         // Now safe to do the delete
         foreach(Resource * source_resource, resources) {
+            // Need to alert FolderKeeper that these are going away to properly update its
+            // m_Resources hash to prevent stale values from deleted resources hanging around
+            m_Mainfolder.RemoveResource(*source_resource);
             source_resource->Delete();
         }
     }

[KevinH]

I have applied the patch to the Sigil 0.8.5 source code and rebuilt. This seems to completely fix the problem. We will probably wait a week or two in case any of these other crashes can be replicated and fixed and then release a Sigil 0.8.6 with this bug (and any others we can track down) fixed.

Thanks for reporting the bug so completely with steps to reproduce, a test epub, and even a backtrace!

Nicely done.

KevinH

[aJuanJo]

Just unninstalled non-official sigil 0.8.5 and installed official one, and now it runs OK but I reproduced the crash, here to images...
.....
sorry cannot place images here... hmmm
well, you just said you've found the solution... thanks
JuanJo

[KevinH]

Hi aJuanJo,

No that crash only happens on merges of html files. If you are loading or deleting images or html files and it crashes you probably have an outdated graphics driver. Please see the full list of questions I asked you earlier in this post if you want any support.

KevinH

[BetterRed]

Originally Posted by aJuanJo

sorry cannot place images here... hmmm JuanJo

@aJuanJo - see ==>> Attachments and Images

There are links to FAQ and Guidelines sections at bottom of all MR pages - lots of useful stuff in them.

BR

[aJuanJo]

Originally Posted by BetterRed

@aJuanJo - see ==>> Attachments and Images

There are links to FAQ and Guidelines sections at bottom of all MR pages - lots of useful stuff in them.

BR

Thanks. You know? It's always the same hahaha, first act and later read the instruction manual hahaha. I'll do
JuanJo

[aJuanJo]

Originally Posted by KevinH

Hi aJuanJo,

No that crash only happens on merges of html files. If you are loading or deleting images or html files and it crashes you probably have an outdated graphics driver. Please see the full list of questions I asked you earlier in this post if you want any support.

KevinH

As you may know by now, I'm using W7 Ultimate, in a PC and in a notebook. in the PC sigil 0.8.5 wouldn't show after starting, it kept working in the background, that's why I tried the unnofficial version which worked but crashed after modifying, specially when deleting a ../text/section0001.html, which then seemed different in the list of html pages. I hadn't noticed if it was selected or in book view or html view. I have an image that I'll post down, because it is the ssame error that in the official version... Then sometimes just crashes and close with an error wich image I'll also post, or when I tried to save or close orderly.. the crash happened.

So now I use the official version in the notebook.. and it acts the same..
Now the images..

You can see in image01 that section0007 has been deleted but it still shows in the left but no appropiatelly.
The second image shows the windows error message

There's one thing I'm not sure, in my windows uninstaller I have more than six or seven Microsoft Visual C++ versions, I suppose installed by previous versions of Sigil, but only one "vcredist86.exe" file which has the time stamp from later Sigil installation. I wonder if that could be a reason for crashes....

greatings JuanJo