[V2.10] Keyboard Shortcut stopped working

[kovidgoyal]

See my previous post

[JimmXinu]

For those following along at home, a bit more testing showed that what I posted before didn't work with calibre 2.9 and earlier. This, however, does appear to work in 2.9 and 1.48:

from calibre.constants import numeric_version as calibre_version
...
            for action in self.menu_actions:
                self.gui.keyboard.unregister_shortcut(action.calibre_shortcut_unique_name)
                # starting in calibre 2.10.0, actions are registers at
                # the top gui level for OSX' benefit.
                if calibre_version >= (2,10,0):
                    self.gui.removeAction(action)
            self.menu_actions = []

            # rebuild menus...

            self.gui.keyboard.finalize()

[BetterRed]

Originally Posted by JimmXinu

For those following along at home, a bit more testing showed that what I posted before didn't work with calibre 2.9 and earlier. This, however, does appear to work in 2.9 and 1.48:

from calibre.constants import numeric_version as calibre_version
...
            for action in self.menu_actions:
                self.gui.keyboard.unregister_shortcut(action.calibre_shortcut_unique_name)
                # starting in calibre 2.10.0, actions are registers at
                # the top gui level for OSX' benefit.
                if calibre_version >= (2,10,0):
                    self.gui.removeAction(action)
            self.menu_actions = []

            # rebuild menus...

            self.gui.keyboard.finalize()

@JimmXinu - where is that code, in the PI or the core. If in the PI, which one and what source file ? And does it work for 2.10 ?

BR

[JimmXinu]

Originally Posted by BetterRed

@JimmXinu - where is that code, in the PI or the core. If in the PI, which one and what source file ? And does it work for 2.10 ?

In the plugin. In kiwidude's plugins it would be in action.py, function rebuild_menu(), assuming similar layout to Reading List(RL). It works for me in 2.10, 2.9 and 1.48. Look inside the RL zip I posted in the RL thread to see it in place.

[BetterRed]

Originally Posted by JimmXinu

In the plugin. In kiwidude's plugins it would be in action.py, function rebuild_menu(), assuming similar layout to Reading List(RL). It works for me in 2.10, 2.9 and 1.48. Look inside the RL zip I posted in the RL thread to see it in place.

@JimmXinu - thanks, I'll download your new RL

I think Terisa de morgan has reported the RL change doesn't work after a library switch

I'll have a go at View Manager, and I'll definitely be testing library switches

We should get this thread 'merged' with the one you've created in the PI subforum, and make it a sticky - I'll PM theducks.

BR

[theducks]

See
https://www.mobileread.com/forums/sho...d.php?t=251177
for discussion on how to fix PI's to be compatible with the update.