Public Service Announcement: Saved Searches are here - Page 2

kovidgoyal · 03-21-2014, 10:47 PM

Quote:

Originally Posted by arspr

Wow.

Why Saved Searches are just restricted to regex ones? I mean, obviously regex ones are much more suited for this feature but would it be difficult to add support for normal ones? (Maybe, they could be useful in certain situations, or for entry basic users).

I dont think this is an important enough use case to waste UI space/add an extra option for. EDIT: I changed my mind, I have added the ability to specify the mode of saved searches.

Quote:

[*]The location, direction and wrap options are logically not saved. But I think it's pretty strange that they are not synchronized with the "normal" search toolbar. Why? I mean, of course there can be situations in which this double setting could be useful, but I really think that in most cases it's going to be extremely confusing.

Because there is no connection between the two. I think it is much more confusing to have two unrelated UI controls change their values due to a mysterious correlation. I for one would be very confused if after using a saved search which might logically operate on a very different location, the location for normal searches was changed.

Quote:

Alt+R is used in Replace and Remove search. And it doesn't do anything but toggle the focus between both buttons.

That's what happens when two controls share the same accelerator key. You have to press enter, in addition. But, I will change it so that Remove search uses Alt+M

Quote:

[*]Count All is Alt+C while in normal editing is Ctrl+N. Wouldn't Alt+N be more logical?

Maybe, maybe not. It depends on the individual user. Alt+C is a mnemonic accelerator, unlike Ctrl+N. Mnemonic accelerators are typically assigned to the first letter or the "strongest" letter whenever possible. I for one would instinctively use Alt+C not Alt+N

Quote:

[*]Wouldn't a "Copy to Search toolbar" button/link/whatever method be useful in the Saved Searched dialogue? (I mean the opposite method from the "Save current search" option).

Why? Again, no connection between the two.

Quote:

[*]In the lower part of the dialogue you have the Find and Replace info of your selected Saved Search. But no info is shown about Case or Dot all options, and it could be really important.

While it *could* be important, IMO it wont be very often and I dont want to waste UI space on it. You should really be assigning descriptive names to your searches so you dont have to parse the find expression to figure out what it does. You can always double click on a search to check the status of those flags. EDIT: I though of a way of showing that info without using too much space.

kovidgoyal · 03-22-2014, 12:39 AM

FYI: I added import/export functionality.

roger64 · 03-22-2014, 02:56 AM

Quote:

Originally Posted by kovidgoyal

FYI: I added import/export functionality.

Thank you

Divingduck · 03-22-2014, 04:09 AM

Quote:

... simply copy the tweak_book_gui.json config file in the calibre config folder...
and
FYI: I added import/export functionality.

Thank you for implementing this.

mrmikel · 03-22-2014, 06:43 AM

I don't think I will use the import/export functionality, but those with more than one machine or those collaborating will be helped, I think. Everything else is so slick, this just goes along with it.

arspr · 03-22-2014, 10:48 AM

Quote:

Originally Posted by kovidgoyal

While it *could* be important, IMO it wont be very often and I dont want to waste UI space on it. You should really be assigning descriptive names to your searches so you dont have to parse the find expression to figure out what it does. You can always double click on a search to check the status of those flags. EDIT: I though of a way of showing that info without using too much space.

You're gonna hate me!!!

You "forgot" showing the search mode along the other info.

GREAT JOB

theducks · 03-22-2014, 12:42 PM

I will probably use Import one time to import 2+ years of Sigil creations.

Who knows what other uses will come up. It will not be the first time of :

'Why would they want that?'

'Oh!

Won't be the last.

Kovid

kovidgoyal · 03-22-2014, 12:43 PM

Import is not going to work with saved searches from Sigil. The regex engines are incompatible, not to mention the export file format.

theducks · 03-22-2014, 12:47 PM

Quote:

Originally Posted by kovidgoyal

Import is not going to work with saved searches from Sigil. The regex engines are incompatible, not to mention the export file format.

I guess I have been doing simple REGEX stuff, I have yet to run into the search differences

I can understand the file format difference issue. Oh well. tedium teaches patience .

roger64 · 03-22-2014, 07:54 PM

Quote:

Originally Posted by kovidgoyal

Import is not going to work with saved searches from Sigil. The regex engines are incompatible, not to mention the export file format.

We have been warned.

I have about 20 or so regexes to import from Sigil, plain ones. I will have to test them one by one but I think it will still be quicker than recreating them from scratch.

Yesterday I tried one (a plain one) that worked. So it's a homework to do and worth it.

But if somebody learns some pitfall to avoid or some trick to use when converting regexes from Sigil, please keep us informed.

eschwartz · 03-26-2014, 02:13 AM

Quote:

Originally Posted by arspr

You're gonna hate me!!!

You "forgot" showing the search mode along the other info.

GREAT JOB

https://github.com/kovidgoyal/calibr...65cd3adf01e8e6

And thanks arspr for the patch.

(Since this is my thread, I feel responsible to mention this.

)

arspr · 03-26-2014, 03:20 PM

Well, Kovid has really tweaked my patch. Now it's more elegant as Regex mode vs normal is just "suggested" and dot all info is hidden for normal searches where it has no meaning. So I wouldn't say that it is "my" patch in any way...

Divingduck · 03-28-2014, 03:42 AM

Kovid, thanks for implementing S&R import/export.

roger64 · 03-28-2014, 06:22 AM

About saved searches: two small wishes.

1. - Would it be possible if the search window "Saved searches" could remember the last field choice of the user? Now it seems to default and reset automatically to "Current file" while I use most of the time "All text files".

2. - Sometimes we like to try a search but we have this big window which hides the text. I miss the "Load Search" feature of Sigil because I could check what happened immediately, before launching a full scale search/replace.

kovidgoyal · 03-28-2014, 06:25 AM

2. Just resize the windows to make it whatever size you like and move it away from the text.

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
Where are searches saved?	travger	Calibre	2	08-26-2012 01:37 PM
remove saved searches ?	cybmole	Calibre	4	04-29-2011 03:12 PM
Saved searches question	danwdoo	Library Management	9	01-26-2011 01:23 AM
Public Service Announcement: Cherrypal is a SCAM	Nate the great	News	0	01-15-2010 01:06 PM

03-22-2014, 12:39 AM	#17
kovidgoyal creator of calibre Posts: 45,255 Karma: 27110894 Join Date: Oct 2006 Location: Mumbai, India Device: Various	FYI: I added import/export functionality.

03-22-2014, 06:43 AM	#20
mrmikel Color me gone Posts: 2,089 Karma: 1445295 Join Date: Apr 2008 Location: Central Oregon Coast Device: PRS-300	I don't think I will use the import/export functionality, but those with more than one machine or those collaborating will be helped, I think. Everything else is so slick, this just goes along with it.

03-22-2014, 12:42 PM	#22
theducks Well trained by Cats Posts: 30,950 Karma: 60358908 Join Date: Aug 2009 Location: The Central Coast of California Device: Kobo Libra2,Kobo Aura2v1, K4NT(Fixed: New Bat.), Galaxy Tab A	I will probably use Import one time to import 2+ years of Sigil creations. Who knows what other uses will come up. It will not be the first time of : 'Why would they want that?' 'Oh! Won't be the last. Kovid

03-22-2014, 12:43 PM	#23
kovidgoyal creator of calibre Posts: 45,255 Karma: 27110894 Join Date: Oct 2006 Location: Mumbai, India Device: Various	Import is not going to work with saved searches from Sigil. The regex engines are incompatible, not to mention the export file format.

03-26-2014, 03:20 PM	#27
arspr Dead account. Bye Posts: 587 Karma: 668244 Join Date: Mar 2011 Device: none	Well, Kovid has really tweaked my patch. Now it's more elegant as Regex mode vs normal is just "suggested" and dot all info is hidden for normal searches where it has no meaning. So I wouldn't say that it is "my" patch in any way...

03-28-2014, 03:42 AM	#28
Divingduck Wizard Posts: 1,166 Karma: 1410083 Join Date: Nov 2010 Location: Germany Device: Sony PRS-650	Kovid, thanks for implementing S&R import/export.

03-28-2014, 06:22 AM	#29
roger64 Wizard Posts: 2,624 Karma: 3120635 Join Date: Jan 2009 Device: Kindle PW3 (wifi)	About saved searches: two small wishes. 1. - Would it be possible if the search window "Saved searches" could remember the last field choice of the user? Now it seems to default and reset automatically to "Current file" while I use most of the time "All text files". 2. - Sometimes we like to try a search but we have this big window which hides the text. I miss the "Load Search" feature of Sigil because I could check what happened immediately, before launching a full scale search/replace.

03-28-2014, 06:25 AM	#30
kovidgoyal creator of calibre Posts: 45,255 Karma: 27110894 Join Date: Oct 2006 Location: Mumbai, India Device: Various	2. Just resize the windows to make it whatever size you like and move it away from the text.

Advert

Advert