new regex question ( trailing 0 or 1 instance permultations

[cybmole]

Originally Posted by Jellby

Hmm... I can't see why, but I have no Sigil to test.
Ah, well, I sort of see why... Isn't there an option for "greedy" matching?



Yes, that's fine, and that should be catched by my previous suggestion (with multiline enabled), but this is not:

line-height:1.3
line-height:1.2em;

I understood that you were testing with that.

i am testing with what is in post #3
that is a bit false in that you only get one line-height per class definition but I figured it would do for testing regex syntax candidates
a genuine real book does not usually mix 1.2em; with 1.2; - it uses one or the other e.g.
.PHeading {
display: block;
font-size: 1.2em;
font-weight: bold;
line-height: 1.2;
text-align: center;
text-indent: 0;
margin: 1em
}
.PHeading1 {
display: block;
font-size: 1.5em;
font-weight: bold;
line-height: 1.2;
text-align: center;
text-indent: 0;
margin: 1em
}

i do not know exactly what dialect of regex is used in sigil, sorry

[theducks]

Originally Posted by cybmole

i am testing with what is in post #3
that is a bit false in that you only get one line-height per class definition but I figured it would do for testing regex syntax candidates
a genuine real book does not usually mix 1.2em; with 1.2; - it uses one

While 2 occurrences is sloppy coding, it is not disallowed. The last one prevails.

also
there is a difference between unit less an with units.
from W3C

Property Values
Value 	Description 	
normal 	A normal line height. This is default 	
number 	A number that will be multiplied with the current font size to set the line height 
length 	A fixed line height in px, pt, cm, etc. 	
% 	A line height in percent of the current font size 	
initial 	Sets this property to its default value. 
inherit 	Inherits this property from its parent element.

[Jellby]

The problem with:

line-height:1.3
line-height:1.2em;

is not that there are two rules, or that one uses em and the other doesn't. The problem is that there is no semicolon between the two lines, and that's a syntax error.

[cybmole]

Originally Posted by Jellby

The problem with:

line-height:1.3
line-height:1.2em;

is not that there are two rules, or that one uses em and the other doesn't. The problem is that there is no semicolon between the two lines, and that's a syntax error.

ok fair cop - as I said, this was an artificial test file & I could not be bothered to do this

.class 1
{
line-height:1.3
}
.class2 {
line-height:1.2em;

etc

after seeing that last post, I wonde if putting line-height:initilal at END of CSS would negate all these fixed values anyway - this is for Kobo aura HD where the on-device line spacing options do not work if countermanded by fixed values in book CSS

[Jellby]

"initial" is not listed in the required values of the ePub 2.0.1 spec, try "normal" instead. But I wouldn't be surprised if it does't work

[Perkin]

Give this a try

line-height:[^;}\r\n]*;?

it will match all the entries in post 3
would also catch a few where the units are spaced from the amount : 1.2 em

[cybmole]

Originally Posted by Perkin

Give this a try

line-height:[^;}\r\n]*;?

it will match all the entries in post 3
would also catch a few where the units are spaced from the amount : 1.2 em

thanks - can you explain the construction/how it works please, it's a bit hard to puzzle out.

[cybmole]

Originally Posted by Perkin

Give this a try

line-height:[^;}\r\n]*;?

it will match all the entries in post 3
would also catch a few where the units are spaced from the amount : 1.2 em

sorry - a late disqualification for that one

I tested it & yes it matches every test line, but only captures up to the 1st colon in each case.

line-height:1.2em
so if used as a find/replace all pair it would leave lots of stuff behind

[DiapDealer]

Originally Posted by cybmole

sorry - a late disqualification for that one

I tested it & yes it matches every test line, but only captures up to the 1st colon in each case.

line-height:1.2em
so if used as a find/replace all pair it would leave lots of stuff behind

Uncheck the "Minimal Match" box.

[cybmole]

Originally Posted by DiapDealer

Uncheck the "Minimal Match" box.

disqualification reversed on appeal

i wonder if any of the other entires work better with that minimal box unticked ?

[Perkin]

line-height:[^;}\r\n]*;?

Originally Posted by cybmole

thanks - can you explain the construction/how it works please, it's a bit hard to puzzle out.

Searches for
line-height:

[^;}\r\n] is then any char except ; } or any linebreak char
* gives multiple times - should probably really have been + instead

the final ;? adds a semi-colon if exists to the match


Hope that helps.

[Jellby]

Originally Posted by Perkin

Give this a try

line-height:[^;}\r\n]*;?

it will match all the entries in post 3

But it will also match any other "line-height", won't it? I thought that was not the idea.

Originally Posted by cybmole

i wonder if any of the other entires work better with that minimal box unticked ?

I already hinted that:

Originally Posted by Jellby

Isn't there an option for "greedy" matching?

greedy matching = minimal match unchecked

[cybmole]

[QUOTE=Jellby;2771983]But it will also match any other "line-height", won't it? I thought that was not the idea.


so long as the ones for narrative text are stripped, then the Kobo HD device options for changing paragraph line spacing should work ok. no real need to also strip large headers etc values for line height - which is why I put a 1.0- 1.99em range idea into the target spec.

[Perkin]

Originally Posted by Jellby

But it will also match any other "line-height", won't it? I thought that was not the idea.

On re-reading the OP I think you're right, the desired effect is any line-height that is between 1 and 2 em's

So a further regex fully expanded which matches each line (and a few further cases) would be

line-height\s*:\s*1(\.\d+)?\s*(em)?\s*;?\s*

or just the entry (not line-break as well)

line-height\s*:\s*1(\.\d+)?\s*(em)?\s*;?(?=\n|\r)