Data Loss with 0.5

[user_none]

Originally Posted by WS64

I had a few crashes with Sigil 0.5, and ALL were while replacing in Current File, there is something very faulty with that one...

QPlainTextEdit cannot handle a large number of QTextCursor replace operations. Doing a replace all on a large document with a large number of replaces will cause it to crash.

Also, replacing within the xml declaration will cause data loss.

[WS64]

Originally Posted by user_none

QPlainTextEdit cannot handle a large number of QTextCursor replace operations. Doing a replace all on a large document with a large number of replaces will cause it to crash.

Also, replacing within the xml declaration will cause data loss.

QPlainTextEdit , does that mean BV?
I do not use BV at all for F&R, my crashes were at F&R in CV for the current file. All files always works.

[John2011]

Further to my previous post about replacing <p> with <p class="small">

When ever I paste a text file into the BV, then go to the CV Sigil puts
<div> xxxxxxxxx</div>
on all the paragraphs.

OK, no big deal, I go to the trusty Find and Replace and

find <div>
Replace <p>

Click all and away it goes and does it, the whole chapter no problems.

When Tiny teddy adds the </p> for me, I go back into CV and ask Find and Replace to
Find <p>&nbsp;</p>
Replace with nothing

This is because there is a blank line between <p>s

I click all and away it goes again quite happily.

But ask it to do <p class="small"> and it all falls over. Strange.

It is 0.5.0 I am using.

I like where the F&R is now, BTW no more hiding text with that pesky floating window.

Peace,
John P.

[Toxaris]

Originally Posted by user_none

QPlainTextEdit cannot handle a large number of QTextCursor replace operations. Doing a replace all on a large document with a large number of replaces will cause it to crash.

This sounds exactly as the behavior I am seeing. I must say that repeating the action after a restart sometimes does work, but not always. Also, on older versions this was not the case.
It affects my way of working, because I usually do all kind or S&R on the whole book before splitting.

Is this a problem with the current version of QT? Any ideas about a solution for it?

[meme]

Just to expand on what user_none said:

If you replace in the Current File (BV or CV), and your file is large, and your find and replace text will cause a lot of replacements, Sigil will crash due to a bug in the Qt editor that is used to display/edit your text. Replace in All Files does not crash since it does not do the replacement interactively. Replace All in Current File uses the same logic now as Find Next so that you can undo replacements - but this means QTextCursor is called to update your position in the document, and the QTextCursor routine from Qt just can't handle large replacements.

If you replace in All Files, and you replace something within the xml declaration (like a ") then, since Sigil will try to auto-correct the code in your files, you will have data loss. If you mess up the html badly, then you've got problems.

Replacing in Book View is also unpredictable due to the way the code converts from html to plain text and should be avoided, which will soon be taken care of for you.

These issues cannot/won't be fixed in the current code. They require a rewrite with a new approach to editing. I believe user_none will be working on this for a later version, but in the meantime just be aware of the issues.

[DiapDealer]

Originally Posted by meme

Replacing in Book View is also unpredictable due to the way the code converts from html to plain text and should be avoided,

It's not unpredictable anymore. It just flat-out eats large random chunks of your text—each and every time you attempt it (F&R in BV). It very predictably... just plain doesn't work at all anymore.

which will soon be taken care of for you.

Glad to hear it.

So who's got the best regex for capturing all of the text (including unicode) between two normal (straight) double-quotes into a backreference(s)—all the while ignoring the quoted content (attributes) inside of html tags?

It doesn't have to be perfect (I'm used to manually massaging the results), but bulk replacing straight quotes with curly-quotes was one of the only situations where I attempted to use F&R in BV (where the current document was always small in size).

[theducks]

Originally Posted by meme

If you replace in All Files, and you replace something within the xml declaration (like a ") then, since Sigil will try to auto-correct the code in your files, you will have data loss. If you mess up the html badly, then you've got problems.

Replacing in Book View is also unpredictable due to the way the code converts from html to plain text and should be avoided, which will soon be taken care of for you.

This exact issue (1) is why I always test my finds by stepping through a whole bunch of times (sometimes a bunch of different sections) before I hit All.
Sometimes I determine, I am unable to craft a bullet proof Find and step through the whole book, doing Next or Replace.

Crash is not good as a quick and dirty, can we get a toggle (button) to disable the Undo logging?
BTW I always start/obtain my Find in CV. BV is for visually locating errors and adding/removing Paragraph breaks
(My work flow is probably biased by the fact my first word processor was Wordstar 2, with Dot Code format commands )

[meme]

The replace in BV will be taken care of by not doing it

As for a toggle, the effort/impact for doing this is troublesome when its planned to replace the cause. I know user_none's said this before, but now I can see why he says it A bit more patience and hopefully a more solid version will be forthcoming after the 5.1 release.

As for the find/replace in BV, I was wondering how to address the very common issues that users have of wanting to only replace certain sections of text. Instead of cluttering up this thread, I'll start a new one requesting Regex suggestions.

[meme]

@theducks. Now that 0.5.1 is out, you can use Replace in Selected Files to avoid the crash issue when replacing in current file - just select 1 file (or more) in the Book Browser and set Look: Selected HTML Files and it will run like Replace All.

[theducks]

Originally Posted by meme

@theducks. Now that 0.5.1 is out, you can use Replace in Selected Files to avoid the crash issue when replacing in current file - just select 1 file (or more) in the Book Browser and set Look: Selected HTML Files and it will run like Replace All.

Thanks for thet

BTW
I just tried the Bulk file rename feature.