kobopatch - An improved patching system

[dmapr]

Not sure how easy it is to implement and how useful it'll be since all it avoids is a one-time setup, but as I was extracting a couple of other KoboRoot.tgz files to add the hyphen dictionaries to the files section I thought “would be nice if there was a merge section where I could just list these and they would get unpacked and processed by the tool…”

Thanks again for simplifying the patch carryover from version to version!

[NiLuJe]

@dmapr: I raised the same question a while ago, and the conclusion (on both ends ) was that it was a job best left to a wrapper script.

And, indeed, I did just that, and learned in the process that GNU tar has a concatenate option that does just what we need .

[boriar]

Originally Posted by NiLuJe

@dmapr: I raised the same question a while ago, and the conclusion (on both ends ) was that it was a job best left to a wrapper script.

And, indeed, I did just that, and learned in the process that GNU tar has a concatenate option that does just what we need .

Thanks a lot!
A really useful wrapper. I don't knew about the concatenate option.

[dmapr]

Originally Posted by NiLuJe

@dmapr: I raised the same question a while ago, and the conclusion (on both ends ) was that it was a job best left to a wrapper script.

And, indeed, I did just that, and learned in the process that GNU tar has a concatenate option that does just what we need .

Awesome, thanks!

[Dirk-71]

Originally Posted by NiLuJe

@dmapr: I raised the same question a while ago, and the conclusion (on both ends ) was that it was a job best left to a wrapper script.

And, indeed, I did just that, and learned in the process that GNU tar has a concatenate option that does just what we need .

I guess this is stuff for developers? I don't understand anything. If this could be useful information for novice's as well, I am interested to learn more about it in a practical way.

Gesendet von meinem SM-G930F mit Tapatalk

[jcn363]

The purpose of the last part of script is to create a last updated install file with Kfmon.
Good luck.

[NiLuJe]

Which basically boils down to GNU tar's concatenate feature (ie., -A), with the caveat that it only works on uncompressed tarballs, hence the manual g(un)zipping.

[geek1011]

I have released kobopatch v0.10.1 (which will be included in the next release of the patches).

This release is a refactor of the kobopatch command, along with other improvements:
- More readable logs
- Nicer output during patching
- Faster
- Patch testing is now integrated (with the -t flag)
- Can now use testdata (a tarball with nickel, libnickel, etc) from kobopatch-patches as the input firmware
- Legacy transitional stuff has been removed

[jcn363]

Acknowledgment and marginal/collateral questions

$ ./kobopatch.sh 
kobopatch v0.10.1
https://github.com/geek1011/kobopatch

Loading configuration from kobopatch.yaml
Error: could not load config file: error reading kobopatch.yaml: yaml: unmarshal errors:
  line 186: key "src/fonts/IBMPlexMono-Regular.ttf" already set in map

obviously I've two lines that try to copy the same file to two different folder.

  src/fonts/IBMPlexMono-Regular.ttf: mnt/onboard/fonts/IBMPlexMono-Regular.ttf
  src/fonts/IBMPlexMono-Regular.ttf: mnt/onboard/adds./koreader/fonts/ibm/IBMPlexMono-Regular.ttf

I don't think this could be consider an error, but...
What is the reason because a file can't copy twice?
What is the reason because cssextract only apply to zlib?
Good luck.

[geek1011]

Originally Posted by jcn363

What is the reason because a file can't copy twice?
What is the reason because cssextract only apply to zlib?

For the file copying, that was an oversight. I wanted to keep the same format as for the patches (source on left, dest on right), and I couldn't imagine a situation where someone may need to copy a file to two different places.

There are a few ways I could solve this. The first (backwards-compatible) way is to support using a list of files as the target as well as a single file. The second (non backwards-compatible) way is to switch the sides around. The third (hacky) way I could do it is to allow adding an ignored character to the end of the file name to make it unique. Which way do you think would be best?

As for cssextract, I just haven't implemented non-zlib extraction yet, as I haven't needed it. If you want, I could implement it sometime in the next 2 weeks.

[NiLuJe]

The first approach seems both more elegant, more practical, and is backwards-compatible to boot .

[geek1011]

I have now implemented multiple destinations for additional files and released it in kobopatch v0.10.2 (and kobopatch-patches v22).

You can now do things like:

files:
    src/whatever.txt: usr/local/whatever.txt
    src/fonts/IBMPlexMono-Regular.ttf:
      - mnt/onboard/fonts/IBMPlexMono-Regular.ttf
      - mnt/onboard/.adds/koreader/fonts/ibm/IBMPlexMono-Regular.ttf

P.S. An example of the nicer log format introduced in v0.10.1 is here: https://linx.geek1011.net/lxhlcvbl.txt

[Terisa de morgan]

Thank you, I'm sure I'll find some case I can use it

[jcn363]

Originally Posted by geek1011

For the file copying, that was an oversight. I wanted to keep the same format as for the patches (source on left, dest on right), and I couldn't imagine a situation where someone may need to copy a file to two different places.

There are a few ways I could solve this. The first (backwards-compatible) way is to support using a list of files as the target as well as a single file. The second (non backwards-compatible) way is to switch the sides around. The third (hacky) way I could do it is to allow adding an ignored character to the end of the file name to make it unique. Which way do you think would be best?

As for cssextract, I just haven't implemented non-zlib extraction yet, as I haven't needed it. If you want, I could implement it sometime in the next 2 weeks.

Originally Posted by NiLuJe

The first approach seems both more elegant, more practical, and is backwards-compatible to boot .

I'm agree with NiLuJe.
As for cssextract, it was just curiosity, not a really need.
Good luck.

[geek1011]

No problem! Tell me if there are any other features you would like.