[GUI Plugin] Reading Goal

[Wiggo]

I select all books with #dateread:2019 --> add to reading goal --> automatically 2019 in date's field --> all books have 04.01.2019

I deleted all from 2019 again and after adding the first 2 books from 2019 one by one, the date is ok

Edit:
I added again all 35 books one by one and now the date is ok. But selecting more than one then the date of them is 04.01.2019

Edit 2:
If selecting more than one book the date for the selected books is the oldest #dateread

[thiago.eec]

Originally Posted by Wiggo

I select all books with #dateread:2019 --> add to reading goal --> automatically 2019 in date's field --> all books have 04.01.2019

I deleted all from 2019 again and after adding the first 2 books from 2019 one by one, the date is ok

Edit:
I added again all 35 books one by one and now the date is ok. But selecting more than one then the date of them is 04.01.2019

Edit 2:
If selecting more than one book the date for the selected books is the oldest #dateread

Got it! I can replicate. I was trying to add using a date. The remaining problem now is when adding using just the year. I'll fix it.

[thiago.eec]

Version 1.1.6 - 16 Sep 2023

- Fix a regression in 1.1.4 that broke adding books for past years using just the year

[Wiggo]

Thank You!

[Comfy.n]

I think it still needs fixing.

[ownedbycats]

1.16 minor timezone issue with two books. They were read at 9:27 pm and 11:05 pm Atlantic Time. The main date shows the 16th, but the record shows the 17th.



json seems to be using GMT for both:

Spoiler:

    "7706": {
      "authors": [
        "Sue Barrow"
      ],
      "challenges": [
        "Annual"
      ],
      "date": {
        "__class__": "datetime.datetime",
        "__value__": "2023-09-17T02:05:25+00:00"
      },
      "genre": "Slavery & Human Trafficking, Suspense & Thriller, Young Adult Fiction",
      "last_year_pages": 0,
      "page_count": 390,
      "read_pages": 390,
      "records": {
        "0": {
          "date": null,
          "read_pages": 0,
          "status": 0
        },
        "1": {
          "date": {
            "__class__": "datetime.datetime",
            "__value__": "2023-09-17T02:05:25+00:00"
          },
          "read_pages": 390,
          "status": 100
        }
      },
      "reread_count": 0,
      "shelf": "Read",
      "status": 100,
      "title": "Sold",
      "title_sort": "Sold"
    },

    },
    "7894": {
      "authors": [
        "Peter J. Aldin"
      ],
      "challenges": [
        "Annual"
      ],
      "date": {
        "__class__": "datetime.datetime",
        "__value__": "2023-09-17T00:27:24+00:00"
      },
      "genre": "Science Fiction",
      "last_year_pages": 0,
      "page_count": 100,
      "read_pages": 100,
      "records": {
        "0": {
          "date": null,
          "read_pages": 0,
          "status": 0
        },
        "1": {
          "date": {
            "__class__": "datetime.datetime",
            "__value__": "2023-09-17T00:27:24+00:00"
          },
          "read_pages": 100,
          "status": 100
        }
      },
      "reread_count": 0,
      "shelf": "Read",
      "status": 100,
      "title": "Shore Leave",
      "title_sort": "Shore Leave"
    },

These were updated from my device using Kobo Utilities.

[thiago.eec]

Originally Posted by ownedbycats

1.16 minor timezone issue with two books. They were read at 9:27 pm and 11:05 pm Atlantic Time. The main date shows the 16th, but the record shows the 17th.

Attachment 203801

json seems to be using GMT for both:

Spoiler:

    "7706": {
      "authors": [
        "Sue Barrow"
      ],
      "challenges": [
        "Annual"
      ],
      "date": {
        "__class__": "datetime.datetime",
        "__value__": "2023-09-17T02:05:25+00:00"
      },
      "genre": "Slavery & Human Trafficking, Suspense & Thriller, Young Adult Fiction",
      "last_year_pages": 0,
      "page_count": 390,
      "read_pages": 390,
      "records": {
        "0": {
          "date": null,
          "read_pages": 0,
          "status": 0
        },
        "1": {
          "date": {
            "__class__": "datetime.datetime",
            "__value__": "2023-09-17T02:05:25+00:00"
          },
          "read_pages": 390,
          "status": 100
        }
      },
      "reread_count": 0,
      "shelf": "Read",
      "status": 100,
      "title": "Sold",
      "title_sort": "Sold"
    },

    },
    "7894": {
      "authors": [
        "Peter J. Aldin"
      ],
      "challenges": [
        "Annual"
      ],
      "date": {
        "__class__": "datetime.datetime",
        "__value__": "2023-09-17T00:27:24+00:00"
      },
      "genre": "Science Fiction",
      "last_year_pages": 0,
      "page_count": 100,
      "read_pages": 100,
      "records": {
        "0": {
          "date": null,
          "read_pages": 0,
          "status": 0
        },
        "1": {
          "date": {
            "__class__": "datetime.datetime",
            "__value__": "2023-09-17T00:27:24+00:00"
          },
          "read_pages": 100,
          "status": 100
        }
      },
      "reread_count": 0,
      "shelf": "Read",
      "status": 100,
      "title": "Shore Leave",
      "title_sort": "Shore Leave"
    },

These were updated from my device using Kobo Utilities.

Thanks for reporting. When I fixed the timezone issue, I missed this one. It's fixed now. I'll release a new version in a few moments.

EDIT:
Dates are always saved to JSON as GMT, but they are saved in the correct month and year according to your local time. Also, the GUI always show dates in your local time.

[thiago.eec]

Originally Posted by Comfy.n

I think it still needs fixing.

Hi!

You said you can't add books to past years. I can't reproduce it here with last version. Test the new version I'm about to release.

Also, you said can't remove books from past years. This functionality was not touched in recent updates. It works fine here (via 'Edit reading goal' dialog > Select the year > Select the books > Press the 'Remove' button or press 'Del' on the keyboard > Apply).

About the 1.1.6 not showing in the updater, it's my mistake. Although I changed the zip file name, internally it still is 1.1.5.

[thiago.eec]

Version 1.1.7 - 17 Sep 2023

- Fix a remaining timezone issue for book records

[ownedbycats]

Question: Is there any speed difference between checking for specific tags and checking an entire column? I just setup a #rggenres tag (regular taglike, but populated with a template). Actually it won't work due to the older books.


Also, I noticed the previous years' genres didn't update - they're still using #subjects. How do I fix this?

[thiago.eec]

Originally Posted by ownedbycats

Question: Is there any speed difference between checking for specific tags and checking an entire column? I just setup a #rggenres tag (regular taglike, but populated with a template).

In my testings, I did not noticed any speed difference using the standard 'tags' column or using a composite column, filtering my genres.

Originally Posted by ownedbycats

Also, I noticed the previous years' genres didn't update - they're still using #subjects. How do I fix this?

Like I said before, past year's records are not updated after they are added. Otherwise, you could never have a book added to more than one year, because they would all have the latest date / reading progress.

The only way to fix this would be by re-adding them. Use the 'Mark selected books', then add them again. That's for books that still have the past date set. If the date column has been updated (added to another year), then you need to use the new 'Date' option to add them.

[ownedbycats]

Bad news: While testing changing to rggenres, I made a small error in the autoadd settings and added 4000 books to my goal.

Good news: I didn't have any bugs during the mass-removal this time. (I did take a backup of the db just in case.)

[ownedbycats]

Originally Posted by thiago.eec

The only way to fix this would be by re-adding them. Use the 'Mark selected books', then add them again. That's for books that still have the past date set. If the date column has been updated (added to another year), then you need to use the new 'Date' option to add them.

I feel like I'm missing some step here. I marked the books, tried to add to reading goal with 'other years' enabled. No books added. So I tried removing the books to re-add them. No books removed.

EDIT: I forgot I can remove them from in the Edit Goal window. Your comment seems to indicate I can just re-add them directly though, if that's intended it's not working.

[thiago.eec]

Originally Posted by ownedbycats

Bad news: While testing changing to rggenres, I made a small error in the autoadd settings and added 4000 books to my goal.

Good news: I didn't have any bugs during the mass-removal this time. (I did take a backup of the db just in case.)

I have a daily and a weekly backup of my calibre config dir, and also do a manual backup (using the plugin option) when doing tests here.

The good thing is that the plugin only updates the current year, so past years tend to be safe (unless manually editing the JSON). And the current year can regenerate itself, in case of errors like the last one (all books with the same date).

Originally Posted by ownedbycats

I feel like I'm missing some step here. I marked the books, tried to add to reading goal with 'other years' enabled. No books added. So I tried removing the books to re-add them. No books removed.

The message only tell you how many NEW books were added. If you try to add books already present in the DB, it will tell you no book was added. But they will be updated.

Just tested here. My 2022's books were using my 'tags' column. Changed my config to use '#genre'. Then I selected all my 2022's and added them again. Got a message that no book was added. But they were all updated and use the '#genre' tag now.

P.S.: Removing didn't work? How did you remove them? Using the main menu action only work for the current year. For past years, you need to use the 'Edit reading goal' dialog remove option.

[ownedbycats]

Originally Posted by thiago.eec

Just tested here. My 2022's books were using my 'tags' column. Changed my config to use '#genre'. Then I selected all my 2022's and added them again. Got a message that no book was added. But they were all updated and use the '#genre' tag now.

P.S.: Removing didn't work? How did you remove them? Using the main menu action only work for the current year. For past years, you need to use the 'Edit reading goal' dialog remove option.

I see that now. Maybe change the dialog to indicate books are updated?

I was using the main menu action. Removing them in reading goal worked.