Sigil-2.0.0 Released

[KevinH]

@Vanguard3000,

Thanks for your bug report. I am not sure what exactly you mean be Properties here (versus Elements in the Metadata Editor).

I tried removing all elements (and of course all of their Propterties) and saw no problems. It all worked.

I tried removing all Elements then adding in the Author Element (dc:creator with role set to author). Then tried removing just the Author Name field and no problems.

Finally, I removed all Elements and then added back Author and removed both the role property so all I had was a blank dc:creator element with no properties, and saved that with no problems.

So would you please give a specific example and tell me exactly what to delete or remove to cause the crash, as having no properties on an element, and having no elements, both worked just fine for me.

So I must not be following exactly how to create the crash.

Thanks!

Originally Posted by Vanguard3000

Found a new bug for you, which is pretty minor but hopefully also a quick fix.

Basically, if you go to the Metadata Editor and remove all Properties and hit OK you'll get a hard crash. It doesn't seem to be an issue with removing any specific Property; it's only if you try and commit with no Properties. This is pretty easily reproduceable and happens every time you follow the steps provided.

At the moment, I'm using the "2.0.1" test build KevinH provided to address the dual monitor issues I had been having with 2.0.0.

I would imagine the fix would involve a null check and/or ensuring there's some basic info in the metadata (i.e. last modified date), or at the very least the OK button should be disabled (or trigger an error) if the metadata is empty.

[KevinH]

Perhaps it is a platform specific bug? Would someone on Windows or Linux please try recreating Vanguard3000's MetaData Editor crash on their platform just in case.

[DNSB]

Originally Posted by KevinH

Perhaps it is a platform specific bug? Would someone on Windows or Linux please try recreating Vanguard3000's MetaData Editor crash on their platform just in case.

I tried removing all elements visible in the Metadata Editor and under Windows 11 using Sigil 2.0.1 build time 2023.09.04 21:17:31 UTC, and got a crash as soon as I clicked on OK.

I've attached the Windows Event Viewer crash report and WinDbg output as a text file.

Looking at @BetterRed's message, I tried with an empty ePub 3 and when I removed all three elements (Language, Title and Date Modified), crash time. As long as one element is left, no crash. OTOH, removing all elements is a bit odd since AFAIR, title, language and identifier are mandatory elements and removing them gives an invalid ePub.

[BetterRed]

Windows 10, Sigil 2.0.1 with an empty EPUB



If I remove the Language and Title elements and click OK Sigil terminates abruptly (no error msg, no offer to save).

Ditto with an EPUB 3.0

Pretty sure this has always been the case.

BR

[theducks]

No metadata is not proper (valid?) EPUB.
IMHO it should be trapped until the minimum is present.

[KevinH]

Interestingly, your debuuger log shows the crash deep in QtCore and not actually in Sigil.

2e40.49e4): Access violation - code c0000005 (first chance)
First chance exceptions are reported before any exception handling.
This exception may be expected and handled.
Qt6Core!QBitArray::QBitArray+0x1e:
00007ffc`095d67de f041ff00 lock inc dword ptr [r8] ds:baadf00d`baadf00d=????????
0:000> g
(2e40.49e4): Access violation - code c0000005 (!!! second chance !!!)
Qt6Core!QBitArray::QBitArray+0x1e:
00007ffc`095d67de f041ff00 lock inc dword ptr [r8] ds:baadf00d`baadf00d=????????
0:000> g
(2e40.49e4): Access violation - code c0000005 (first chance)
First chance exceptions are reported before any exception handling.
This exception may be expected and handled.
Qt6Core!QBitArray::QBitArray+0x1e:
00007ffc`095d67de f041ff00 lock inc dword ptr [r8] ds:baadf00d`baadf00d=????????

That is probably why is works just fine on MacOS but crashes on Windows.

I will try this is my Linux box when I get it setup tomorrow to see if it crashes too. Running a debugger there is much easier. Hopefully it will give us some idea of what is actually causing the crash so I can try and prevent it.

Thanks!

Kevin

Originally Posted by DNSB

I tried removing all elements visible in the Metadata Editor and under Windows 11 using Sigil 2.0.1 build time 2023.09.04 21:17:31 UTC, and got a crash as soon as I clicked on OK.

I've attached the Windows Event Viewer crash report and WinDbg output as a text file.

Looking at @BetterRed's message, I tried with an empty ePub 3 and when I removed all three elements (Language, Title and Date Modified), crash time. As long as one element is left, no crash. OTOH, removing all elements is a bit odd since AFAIR, title, language and identifier are mandatory elements and removing them gives an invalid ePub.

[KevinH]

Originally Posted by BetterRed

Windows 10, Sigil 2.0.1 with an empty EPUB

Attachment 203997

If I remove the Language and Title elements and click OK Sigil terminates abruptly (no error msg, no offer to save).

Ditto with an EPUB 3.0

Pretty sure this has always been the case.

BR

Thanks. I tried that on macOS and no problems at all.

If doing that always crashed Sigil on Windows why didn't anyone ever report it before? Any crash is unacceptable.

Hopefully, we can track down the real cause in Qt and get it fixed.

At worst case, before the next release, I will look for completely empty metadata and force back in a title tag with placeholder text to prevent the issue on Windows.

If anyone else knows of a any other repeatable ways to crash Sigil, I would really love to know about it so all crashes can be prevented.

[DNSB]

Originally Posted by KevinH

If doing that always crashed Sigil on Windows why didn't anyone ever report it before? Any crash is unacceptable.

Hopefully, we can track down the real cause in Qt and get it fixed.

I suspect that no one before thought removing all the metadata elements visible in the Metadata Editor was a good idea considering that there are mandatory elements that must be present in a valid ePub.

[BetterRed]

Originally Posted by KevinH

. . .
If doing that always crashed Sigil on Windows why didn't anyone ever report it before?

I discovered it when trying determine which MD elements were mandatory in an EPUB 2.0 in 2011/12.

Why no report? As well as being a lifelong minimalist, I'm also fault tolerant

BR

[Doitsu]

Originally Posted by KevinH

Thanks. I tried that on macOS and no problems at all.

If doing that always crashed Sigil on Windows why didn't anyone ever report it before? Any crash is unacceptable.

FYI: I've just tested this with the Windows version of Sigil 0.9.8 and Sigil didn't crash.

[KevinH]

Pre use of a tree. Older editor used a table only.

[Vanguard3000]

Originally Posted by KevinH

Thanks for your bug report. I am not sure what exactly you mean be Properties here (versus Elements in the Metadata Editor).

...

I guess you might call them Elements from a coding standpoint but Property is used throughout the MetaData Editor itself (e.g. the "Remove Property" button, "Add Metadata Property" dialog title, etc) so that's what I used.

DNSB has probably already isolated things for you, but for clarity's sake:

• Open MetaData Editor
• Remove each Property using the "Remove" button one-by-one until the list is blank (no Names or Values).
• Hit OK.

I guess you might call them Elements from a coding standpoint but Property is used throughout the MetaData Editor itself (e.g. the "Remove Property" button, "Add Metadata Property" dialog title, etc) so that's what I used. The point is that the list should be entirely blank.

Expected behaviour: If allowed, the Metadata Editor should close and apply your changes to the file. OR if the file cannot have no metadata, it should be handled with an error message or some other failsafe method.

Observed bahaviour: Sigil crashes to desktop.

I'm on Windows 10, and as I mentioned, I'm using the monitor-debugging build you had sent me a while back.

[KevinH]

Luckily Linux showed the crash as well. Tracked it down with gdb, and pushed a fix to master.

Thank you for your bug report.

[DiapDealer]

Apologies for not being available to help with debugging. I'm out of town with access to nothing but mobile devices.

[KevinH]

Originally Posted by DiapDealer

Apologies for not being available to help with debugging. I'm out of town with access to nothing but mobile devices.

No problems. The bug was easy to recreate on Linux. But for the life of me I can not figure out why it did not show on macOS.