Modify ePub plugin dev thread

[capnm]

Well, I'm not sure if I got this right, because I had to quit before I was sure I had figured out what was going on, but does this make sense:

In a body {...} statement

1) margin: property ( as opposed to margin-top: etc)

body {margin: 1em; }

Is not found by Quality Check
Is properly found and stripped by Modify Epub


2) a declaration without a trailing semi-colon (last or only declaration in rule)

body {margin-top: 1em }

Is found by Quality Check
Is not found by Modify Epub

[ldolse]

Quality Check should flag scenario 1 ('margin' in a body class) based on a code review, there is also logic where Quality Check will multiply the value of the margin style and multiply it by 4 - if the multiplied value is less than the total of the configured Calibre margins then it won't be flagged - I suppose I could make the logic here a bit more precise if Calibre's four configured margins aren't equal.... If you can confirm it doesn't work on an ePub PM me an example.

I'll need to look into scenario two - Modify ePub should absolutely work if there are more than one style settings with a semi-colon between them - two style settings without a semi-colon wouldn't be valid css. Quality Check and Modify ePub use the same logic to break the styles into pieces, so it would be odd if one worked and the other didn't...

I haven't tested the example with just a single style with no semi-colon though, it's possible Python isn't handling that string the way I intended, I'll check that case.

[capnm]

I can't check right now ....
But I'm pretty sure this

body { ...blah...; margin-left:1em; margin-right:1em }

was modified to

body { ...blah...; margin-right:1em }


I'm not as sure about what QC didn't pick up --

But I was getting rushed about then ....

Otherwise it's great!

[ldolse]

Found a problem which matches your initial description, as it's a bit of an edge case I'm thinking to hold off on an updated release until I wrap up the inline rewriting functionality.

Regarding this second description - I don't think modify ePub could leave an em margin hanging out, the way the rewrite works all the original margin properties are discarded.

[capnm]

Okay, I can't seem to consistently reproduce what's going on

But then it seemed like it might have to do with spaces .... ???

I had time for one last test:
Took a cleaned epub, and before the
@page {margin-right:5.0pt;margin-top:5.0pt;margin-left:5.0pt;margin-bottom:5.0pt; }
you add at the end, I added

body {text-align: justify; margin-top:1em; margin-left:1em}
body {text-align: justify; margin-top: 1em; margin-left: 1em}
body {text-align: justify;   margin-top:1em;   margin-left:1em}
body {text-align: justify;margin-top:1em;margin-left:1em}
body {text-align: justify;  margin-top:  1em;  margin-left:  1em}
body {text-align: justify;   margin-top:  1em;   margin-left:  1em}

and got

body {text-align: justify;  margin-top:1em;  margin-left:1em }

body {text-align: justify;  margin-top: 1em;  margin-left: 1em }

body {text-align: justify;    margin-top:1em;    margin-left:1em }

body {text-align: justify }

body {text-align: justify;   margin-top:  1em;   margin-left:  1em }

body {text-align: justify;    margin-top:  1em;    margin-left:  1em }

-officially confused

[ldolse]

Whitespace would do it now that I double-check the code - I thought I was stripping it, but looks like I did't strip the whitespace where it counts in that instance.

[capnm]

Glad to hear that.
I was beginning to think I was losing it
I wouldn't have noticed the presence or absence of whitespace when I first encountered the problem

[GreenMonkey]

Kiwi, your plugin is very useful for tweaking covers without a full run through the Calibre conversion engine, thanks!

I've got a Penguin Classics epub that had no cover (or, I should say, I lost it after...umm...plugin processing).

The only way I could add a cover was to run conversion..and then I ended up with a broken image page called oeb_cover_r1.xhtml with a false cover (bad image path) I had to clean up.

I hope you eventually work out a "replace cover" function as you talked about a few weeks back. Sometimes it would be easier if I could just "insert cover" to a good epub that is missing one

Thanks kiwidude (and thanks for the suggestion of your plugin in one of the other cover threads).

[DoctorOhh]

The person in this post is asking for the option to flatten the TOC. Her reader can only read the first level of a TOC. I think this idea would fit this plugin perfectly.

[kiwidude]

@dwanthny - I agree, it would be a relatively simple addition to this plugin. Though I have currently handed the development baton for this plugin to Idolse. He was working any kinks out of his margin removal stuff, as well as potentially implementing the "add a new cover" logic plus some other ideas he had for this plugin.

I don't have the time right now to take it back on myself for a little while yet anyways so haven't asked about progress, but hopefully when Idolse is eventually done we can look at a new feature like this.

[ldolse]

I've been a bit sidetracked on some other projects but hoping to wrap up the margin manipulation portion soon and then tackle the cover removal. I haven't looked into how an NCX defines multi-level TOCs, so not sure what will be required to mod that.

[Dopedangel]

Any updates on this plugin

[ldolse]

Status hasn't changed since the last update, life and other projects have gotten in the way as of late. The plugin won't be marked 1.0 until cover handling is implemented. There is a small bug in the css manipulation code which will trigger with some ePubs (read the previous posts for details), I have a potential fix for this, but I've been more inclined to look into re-writing all the css manipulation code to leverage cssutils so I don't have to reinvent the wheel and deal with my own buggy implementation.

The other functions are all reported to be bug free. Was there a specific function you were looking for in the plugin?

[Dopedangel]

Originally Posted by ldolse

Status hasn't changed since the last update, life and other projects have gotten in the way as of late. The plugin won't be marked 1.0 until cover handling is implemented. There is a small bug in the css manipulation code which will trigger with some ePubs (read the previous posts for details), I have a potential fix for this, but I've been more inclined to look into re-writing all the css manipulation code to leverage cssutils so I don't have to reinvent the wheel and deal with my own buggy implementation.

The other functions are all reported to be bug free. Was there a specific function you were looking for in the plugin?

No was just wondering why it never became part of the plugin downloader I was recommending it to someone but forgot where I got it from in the first place. Had to search a bit to find it. Maybe plugin updater should get a beta plugin tag as to me this is a very useful plugin but no one knows about it.

[carmenchu]

Steps:

1. Downloaded + installed plugin --> Reset
2. Quality check for duplicated jackets
3. Copy to disk found item for comparison
4. Run plugin (report in attached zip file)
5. Sent book in library (thanks, OpenWith!) to WinMerge for comparison and added copy from (3)
6. Files identical (report in attached zip file)
7. Replaced in WinMerge book in library with new copy to disk (in case file updated only on copy to disk): again no changes.
8. New Quality check for duplicated jackets again picked the same book

Query: bug/feature/my error?