calibre friday preview releases

[ownedbycats]

Are there any changes to dark-mode scrollbar other than the contrast? It looks a little rounder at the ends, but it's possible I just couldn't easily tell before.

[Comfy.n]

Originally Posted by kovidgoyal

Released another preview: Major features: Viewer can now play m4a audio files and in dark mode the scrollbar has improved contrast. Lots of minor bug fixes as well.

Originally Posted by ownedbycats

Are there any changes to dark-mode scrollbar other than the contrast? It looks a little rounder at the ends, but it's possible I just couldn't easily tell before.

While this was a great and long-awaited addition, I've tried modifying my preferred custom palette, aiming to have the scrollbar edges more visible, but didn't succeed.

Problem is my screen panel is a generic TN one, with limited viewing angles, and I also use custom gamma settings with the application in the screencap below, so I believe I have a quite non standard color profile.



In my custom calibre scheme, I tend to prefer plain black background on white foreground, like this:



So I have #000 as general background and #fff for text foreground. While trying different combinations to address the scrollbar visibility, I always end up going back to those values, because changing the general background and the background color for buttons will either do no good to the scrollbar or to the rest of the interface.

In general, scrollbar styling can have border colors, this would be ideal for my use case!

[ownedbycats]

I also just noticed the horizontal scrollbar sort of has a slightly wonky-looking shadow on the lower edge, esp. when cursoring it.

[kovidgoyal]

Originally Posted by thiago.eec

1) Some of the negative durations were corrected, but not all. I'm still getting this error for some short sentences.

2) The 'time:duration' property is now set for every smil file and for the total duration (although EPUBCheck still complains that the total duration doesn't add up for the sum of all clips' durations; if I remember correctly, the tolerance is 1 sec.)

I cannot reproduce either so attach a sample file that shows the problems. (2) is most likely just an issue with limited floating point digits on the durations I can probably increase that, though it is ugly and not really needed for anything.

[kovidgoyal]

@ownedbycats: Yes it is rounded now, to make it stand out even more. Not seeing what shadow you are refering to there is a slight subtle border at the edges, is that what you mean?

@comfy.n yes customising scrollbar colors is not going to work Qt doesnt have any infrastructure for it beyond stylesheets.

[Comfy.n]

I may have exaggerated a bit, but I tried to illustrate the gamma setting I mentioned

[Comfy.n]

Originally Posted by kovidgoyal

@comfy.n yes customising scrollbar colors is not going to work Qt doesnt have any infrastructure for it beyond stylesheets.

would it be possible to add just a slight outline to the scrollbar handle edges, maybe with some coding sorcery Qt might permit?

[kovidgoyal]

An outline looks pretty bad to my eyes. I will make the rendering antialiased though that should make the rounded corners look a bit better on low res screens.

[Comfy.n]

Thank you! I take it that any changes to .cpp files in source code can be seen only after the executable release, as happened with the previous scrollbar slider update? Wanted to confirm this.

[kovidgoyal]

Yes changes to non-python code require an actual build so using the CALIBRE_DEVELOP_FROM trick wont work.

[thiago.eec]

Originally Posted by kovidgoyal

I cannot reproduce either so attach a sample file that shows the problems. (2) is most likely just an issue with limited floating point digits on the durations I can probably increase that, though it is ugly and not really needed for anything.

I tried running it again with latest commits and both errors seems to be fixed. But it introduced another error: removing the floating point digits led python to use scientific notation, which is invalid.
Example:

clipBegin="00:00:15.070294784407906e-05"

P.S.: This commit broke the window stretch. The help info is not resizable anymore.

[kovidgoyal]

This should fix both issues:
https://github.com/kovidgoyal/calibr...cc152045633201

[thiago.eec]

Originally Posted by kovidgoyal

This should fix both issues:
https://github.com/kovidgoyal/calibr...cc152045633201

Thank you. All good now.

[Comfy.n]

I'm getting this on single MDE opening:

AttributeError: 'MultipleWidget' object has no attribute 'currentIndexChanged'

Spoiler:

Traceback (most recent call last):
File "calibre\gui2\actions\edit_metadata.py", line 430, in edit_metadata
File "calibre\gui2\actions\edit_metadata.py", line 453, in edit_metadata_for
File "calibre\gui2\actions\edit_metadata.py", line 483, in do_edit_metadata
File "calibre\gui2\metadata\single.py", line 1349, in edit_metadata
File "calibre\gui2\metadata\single.py", line 107, in __init__
File "calibre\gui2\metadata\single.py", line 167, in setupUi
File "calibre\gui2\metadata\single.py", line 375, in create_custom_metadata_widgets
File "calibre\gui2\custom_column_widgets.py", line 833, in connect_data_changed
AttributeError: 'MultipleWidget' object has no attribute 'currentIndexChanged'

Bulk MDE runs fine

[kovidgoyal]

this should take care of it:
https://github.com/kovidgoyal/calibr...9463095a49f7c9