Sony PRS-T1 in Calibre

[log]

wow robert you totally lost me on your test scenario

I would think you should do one thing at time and stop when there's an issue, and be very clear on the condition to replicate the problem. If Kolenka can't replicate, it makes it much more difficult to identify where the issue is.

Will defer to Kolenka and the rest of developers though, maybe I just can't understand it. I'll try it out later this evening and report my results.

[kovidgoyal]

Yeah, that's it. I've uploaded a build that should detect the SD card on windows as well.

[gena0411]

Hello,

I have installed the latest beta yesterday (before collections update) and everything worked fine.

Today, I have installed again to get collections support and there is a communication error.

I deleted everything to try from scratch but error remains.

==================
calibre, version 0.8.21
ERROR: Error: Error communicating with device

'NoneType' object is not subscriptable

Traceback (most recent call last):
File "site-packages\calibre\gui2\device.py", line 81, in run
File "site-packages\calibre\gui2\device.py", line 332, in _books
File "site-packages\calibre\devices\prst1\driver.py", line 142, in books
File "site-packages\calibre\devices\usbms\driver.py", line 242, in books
File "site-packages\calibre\devices\prst1\driver.py", line 200, in sync_booklists
File "site-packages\calibre\devices\prst1\driver.py", line 228, in update_device_database
File "site-packages\calibre\devices\prst1\driver.py", line 279, in update_device_books
File "site-packages\calibre\devices\prst1\driver.py", line 446, in upload_book_cover
TypeError: 'NoneType' object is not subscriptable
===========================

Could somebody help with this?

Thanks in advance
Genady

[Kolenka]

So it sounds like a lot of the problems are on Windows. Not terribly surprising as I don't currently have a Windows test environment. Development was done on OS X.

Originally Posted by anesthezea

As I said above, my first attempt with the new beta brooked mixed results - duplicated books, but all collections showing properly.

<snip>
File "site-packages\calibre\devices\prst1\driver.py", line 256, in update_device_books
IndexError: list index out of range

Anesthesia (or really anyone with the duplicated books issue), would you be willing to share out your Sony_Reader/database/books.db file that has the duplication? The matching of books to their DB entry is done by the path, so I suspect some mismatch is at work. I'd need to see the duplicate entries to see why the mismatch happened.

EDIT: Even better would be to catch a books.db right before you eject it from the machine. At the point where the books are in the collections, before the T1 removes them.

I wouldn't be surprised if the duplication in the DB was related to the collections troubles in some way. Collections must reference the books, and so if the references were awkward, the T1 might try to clean them up when it can't make sense of them.

The error in that trace looks like it got fixed by Kovid already when I pulled down his changes.

Originally Posted by gena0411

Hello,

File "site-packages\calibre\devices\prst1\driver.py", line 446, in upload_book_cover
TypeError: 'NoneType' object is not subscriptable

Looks like I can blame Kovid's cleanup for this one (D'oh!). There is an if that got re-written incorrectly during that cleanup. I've got a fix for that in the calibre bug tracker now.

[Kolenka]

Originally Posted by dwanthny

With all of the older Sony models the Automatic setting was great. If the T-1 ever gets integrated to that level I'll consider buying one.

Minus the bugs folks are having with duplication, it's already at that point. The difference between manual/automatic management is outside of the driver, and doesn't require any specific support for it. Calibre tells the driver what the data on the device should be, and the driver makes it so.

EDIT: Forgot to mention I actually use Automatic myself.

[gena0411]

Originally Posted by Kolenka

So it sounds like a lot of the problems are on Windows. Not terribly surprising as I don't currently have a Windows test environment. Development was done on OS X.



Anesthesia (or really anyone with the duplicated books issue), would you be willing to share out your Sony_Reader/database/books.db file that has the duplication? The matching of books to their DB entry is done by the path, so I suspect some mismatch is at work. I'd need to see the duplicate entries to see why the mismatch happened.

I wouldn't be surprised if the duplication in the DB was related to the collections troubles in some way. Collections must reference the books, and so if the references were awkward, the T1 might try to clean them up when it can't make sense of them.

The error in that trace looks like it got fixed by Kovid already when I pulled down his changes.



Looks like I can blame Kovid's cleanup for this one (D'oh!). There is an if that got re-written incorrectly during that cleanup. I've got a fix for that in the calibre bug tracker now.

Thanks Kolenka.
So you have found the source of the error?
Hopefully next update will include the fix then.

Thanks
Genady

[Kolenka]

You mean the one you found? Yeah. It's a silly typo mistake made in a hurry.

The trigger for the bug is a book without a thumbnail cover.

[gena0411]

Originally Posted by Kolenka

You mean the one you found? Yeah. It's a silly typo mistake made in a hurry.

The trigger for the bug is a book without a thumbnail cover.

OK. Thanks.

[Robert22]

Originally Posted by kovidgoyal

Yeah, that's it. I've uploaded a build that should detect the SD card on windows as well.

Thanks kovidgoyal,

The SD card is now consistently detected.

[Kolenka]

Robert, can you recreate the situation in Step 4 of your steps from earlier, and PM me the books.db?

Ideally, I'd like to get two copies:
1) Before you unplug the device, after say, quitting Calibre to make sure it has written everything out to the file.
2) After letting the T1 remove books from the collections, connecting the T1, and not using Calibre again.

#1 will give me the state that Calibre set.
#2 will give me the state that the T1 corrected it to.

I should be able to figure out what is likely going wrong at that point.

[Robert22]

OK I discovered what was causing the discrepancies between what was checked and showing in the Library view and checked and showing in the Device view. Turns out it was a plugboards issue.

I had a plugboard with 2 items:

{title} ({pubdate}) Mapped to: title
{author_sort} Mapped to: authors

The authors item did not affect the checked list but the title item does. So I have remove the plugboard for further testing.

[Robert22]

Originally Posted by Kolenka

Robert, can you recreate the situation in Step 4 of your steps from earlier, and PM me the books.db?

Ideally, I'd like to get two copies:
1) Before you unplug the device, after say, quitting Calibre to make sure it has written everything out to the file.
2) After letting the T1 remove books from the collections, connecting the T1, and not using Calibre again.

#1 will give me the state that Calibre set.
#2 will give me the state that the T1 corrected it to.

I should be able to figure out what is likely going wrong at that point.

Hi Kolenka,

OK I created the files for you but I do not have Private Messaging set up on my machine. Can I get the files to you in another way?

[Kolenka]

Originally Posted by Robert22

Hi Kolenka,

OK I created the files for you but I do not have Private Messaging set up on my machine. Can I get the files to you in another way?

You can't PM through the forum?

[Robert22]

Originally Posted by Kolenka

You can't PM through the forum?

How do I attach a file that way?

[Robert22]

OK done...