[Device Plugin] Kobo Touch Extended Driver

[Terisa de morgan]

I've tested the new plugin and I've found a problem: I have a paragraph in my stylesheet with margin-bottom: 10% and margin-top: 15%. With the new plugin that format is not honored, and the margin disappears.

[Terisa de morgan]

Could the reason be this?

	margin-top: 0 !important;
	margin-bottom: 0 !important;

[GeoffR]

I haven't tested it, but looking at the code I think this rule in style-hacks.css:

div#book-inner * {
	margin-top: 0 !important;
	margin-bottom: 0 !important;
}

should not have the * selector:

div#book-inner {
	margin-top: 0 !important;
	margin-bottom: 0 !important;
}

(if the rule is needed at all? In fact, I don't see why style-hacks.css is needed at all?)

[Terisa de morgan]

Something like that, it's overwriting all margin-top and margin-bottom in the user stylesheet, I'm afraid.

[GeoffR]

I'm fairly sure style-hacks.css should not be present in the driver, if anyone wants those styles then they can always add them using kobo_extra.css.

[Terisa de morgan]

I totally agree with that.

[GeoffR]

But then again, maybe some rules are needed to prevent more general div styles in the book from being applied to the divs added by the driver, something like this?

div#book-columns, div#book-inner {
  margin: 0 0 0 0;
  padding: 0 0 0 0;
}

[Terisa de morgan]

Originally Posted by GeoffR

But then again, maybe some rules are needed to prevent more general div styles in the book from being applied to the divs added by the driver, something like this?

div#book-columns, div#book-inner {
  margin: 0 0 0 0;
  padding: 0 0 0 0;
}

Defining only those styles? Why div#book-columns and not div.book-columns? But I think that, perhaps, only that. It shouldn't modify anything else, neither paragraphs nor links.

[jgoguen]

'#' instead of '.' because of how CSS selectors work. I'll tweak the CSS file and post a new version sometime in the next few hours.

It's needed to match what the Kobo files have in their inline styles. But yea, '!important' seems excessive.

[NiLuJe]

FWIW, I used Kobo's inline CSS verbatim. I'm far from being a CSS wizard, so I'll leave you all to decide what the best course of action is .

[Terisa de morgan]

The problem with !important is that override any other definition, so your styles go through the windows The other things I don't know...

[Terisa de morgan]

I've modified my kepub editing sylehack.css so the llast lines are:

div#book-inner {
	margin-top: 0 ;
	margin-bottom: 0 ;
}

(I've removed '*' and !important only).

With this, margins are again the ones defined in the stylesheet..

[jgoguen]

There are some string changes, for anyone interested in updating translations: https://translations.launchpad.net/c...o-driver/trunk

New version (minus translations, obviously) with the CSS file tweaked attached here.

[GeoffR]

I think using Kobo's style-hacks.css is a bad idea, as as it will change the book's existing styles for no reason, and if someone wants the styles changed in that way then they can always add it to their own kobo_extra.css. The div#book-inner * {margin-top: 0; margin-bottom:0;} rule sets the margin for everything below div#book-inner, but doesn't affect the margin of div#book-inner itself. I think this is the exact opposite of what is desired.

The only rules that might be useful to include in all books might be those which ensure that the extra divs added by the driver don't themselves cause changes to the.book.

An example of how the presence of those divs could change the book is if the book's stylesheet contained a div {margin-left: 1em;} rule. In the original book that would add a 1em left margin to anything enclosed by a div, but in the converted kepub everything is enclosed by two extra divs and so the converted book would have an extra 2em left margin throughout.

To avoid this I would add a rule similar to the following:

div#book-columns, div#book-inner {
  margin: 0 0 0 0 !important;
  padding: 0 0 0 0 !important;
}

(Some other properties might need to be added to this, such as font-size: 1.0em?) Note there is no * selector following the div selectors, so this rule should only affect the extra divs themselves, and not anything below, and just ensure that margin and padding styles from the original book do not get attached to the extra divs added by the driver.

Then to fix the full-screen cut off bug, the following could be added to the user's kobo_extra.css or to the built-in stylesheet via a firmware patch:

div#book-columns {padding: 0.2em 0.2em 0.2em 0.2em !important;}

Edit: I might be looking at this issue from a different perspective that the others here, as I don't read sideloaded kepubs (I prefer the epub reader), but I see the reason for the driver adding the book-columns and book-inner divs is because there doesn't seem to be any other way to add them automatically with existing methods, while any css in the stylesheet can be added using the existing kobo_extra.css method.

Edit2: Also it would not be a good idea to break anything that is currently working, as at some point Kobo are likely to fix the full-screen cut off bug and make full-screen mode an official feature, and then the bug fix that depends on the book-columns/book-inner divs will no longer be needed.

[NiLuJe]

@GeoffR: Just to point out that it's margin-top/margin-bottom and not left/right that's used in Kobo's stylehacks CSS .

(Apart form that, nothing more to add, not my area of expertise, I'm doing my best impression of a sponge and soaking up knowledge in the background, carry on ).

That does explain why I thought the formatting looked wonky in terms of top/bottom margins in what I'm currently reading (unpadded scene breaks, for instance) ;p.