12-15-2014, 02:48 PM | #61 | ||
Zealot
Posts: 105
Karma: 37418
Join Date: Jan 2013
Device: Kobo Glo, Aura, H2OE2, Libra 2
|
Yes it looks like the issue is the same with or without the footer patch enabled.
The following shows the font size v line height where the issue just starts to show on my reader (6" Aura) with side loaded kepub. Quote:
Quote:
My memory says that firmware was better but I may be mistaken. @Anak It was the installed kobo font Georgia. Last edited by npr; 12-15-2014 at 02:53 PM. |
||
12-15-2014, 07:29 PM | #63 | |
Connoisseur
Posts: 56
Karma: 100000
Join Date: Oct 2014
Location: Ann Arbor, MI USA
Device: Kobo Aura One, Libra 2, Paperwhite
|
Quote:
A thank you to GeoffR for the new patch. |
|
12-16-2014, 06:30 AM | #64 | |
Zealot
Posts: 105
Karma: 37418
Join Date: Jan 2013
Device: Kobo Glo, Aura, H2OE2, Libra 2
|
Quote:
Calibre generated kepubs side-loaded, kobo Georgia font: The very tip of "f's" are cut off, ie about half the circle at the top right of the "f" is cut off. To my eyes it's not really noticeable unless your told it's there. Interestingly on my device the tips of "f's" are cut off both in full screen and standard screen. I also tried a Kobo loaded kepub, again using Georgia font: Without the patch the "f's" were cut off pretty much the same as above in both full screen and standard screen. With the patch however the "f's" were ok in both screen mode. |
|
12-16-2014, 09:13 AM | #65 |
Wizard
Posts: 3,821
Karma: 19162882
Join Date: Nov 2012
Location: Te Riu-a-Māui
Device: Kobo Glo
|
Kepub built-in stylesheet typo?
I found what looks like a typo, a missing period, in the built-in kepub stylesheet (highlighted in red, I've added some line breaks):
.KBHighlighting { background-color: #C6C6C6 !important; } .KBStackKeyword, .KBSearchResult, .KBAnnotation, .KBHighlighting , KBAuthorAnnotation{ font-size: 100% !important; -webkit-text-combine: inherit !important; } .KBSearchResult { background-color: #C6C6C6 !important; } .KBStackKeyword a { color: black !important; } .KBAuthorAnnotation, .KBAuthorAnnotationContinued { background-color: transparent !important; text-decoration: none !important; } .KBStackKeyword[writingMode="horizontal-tb"] a { border-bottom: 1px solid black !important; } .KBAuthorAnnotation[writingMode="horizontal-tb"], .KBAuthorAnnotationContinued[writingMode="horizontal-tb"] { border-bottom: 2px dotted black !important; } I don't know what effect it has, if any. (I don't use annotations much.) The `Fix kepub full-screen mode side bearing cut-off bug` patch fixes the typo, since that patch has to re-arrange that part of the stylesheet, but I'll include a seperate fix here for use without that patch, if anyone wants to test it. Code:
<Patch> patch_name = `Fix kepub annotations stylesheet typo` patch_enable = `yes` replace_bytes = DB456A, 20, 2E </Patch> Last edited by GeoffR; 12-16-2014 at 09:16 AM. Reason: added title |
12-16-2014, 04:02 PM | #66 |
Wizard
Posts: 3,821
Karma: 19162882
Join Date: Nov 2012
Location: Te Riu-a-Māui
Device: Kobo Glo
|
I've updated the `Fix kepub full-screen mode side bearing cut-off bug` patch in post #57.
It now adds padding in units of 0.1em (with an alternative for units of 1%) to div#book-inner, and is a bit more compact. It only works with synced kepubs, but another patch that works with sideloaded kepubs too might be possible. I am using the patch myself, but I mainly just use the Georgia font. If you use different fonts and find that characters are still cut off, try increasing the amount of padding from 0.1em to 0.2em or more. Last edited by GeoffR; 12-16-2014 at 04:06 PM. |
12-16-2014, 05:48 PM | #67 |
Wizard
Posts: 3,821
Karma: 19162882
Join Date: Nov 2012
Location: Te Riu-a-Māui
Device: Kobo Glo
|
Yet another update for the `Fix kepub side bearing font cut off bug` patch in post #57.
I've added another patch that should work for sideloaded kepubs too, although it may work a bit differently on sideloaded than synced kepubs, and there might be some unwanted side-effects on sideloaded kepubs, so testing welcome. Edit: Actually, I can think of a number of problems that will occur with sideloaded kepubs, and for some books they might be worse than the original problem. I think the only real solution (other than Kobo fixing the bug in the kepub reader) is to change Calibre to add the parts to the kepubs that it creates which are currently missing. (The book-columns and book-inner divs.) Edit2: Updated patch again, this one should have fewer side effects on the layout of sideloaded kepubs. Last edited by GeoffR; 12-16-2014 at 08:18 PM. Reason: Updated patch again ... |
12-16-2014, 10:44 PM | #68 | |
Connoisseur
Posts: 62
Karma: 13112
Join Date: Feb 2013
Device: Kindle Paperwhite; KOBO AURA HD
|
Quote:
|
|
12-16-2014, 11:15 PM | #69 |
Wizard
Posts: 3,821
Karma: 19162882
Join Date: Nov 2012
Location: Te Riu-a-Māui
Device: Kobo Glo
|
I didn't think of that. I will have to add padding to all four sides, as there won't be enough room in the stylesheet to add it to just two sides conditionally based on the current writing direction. That will be no problem for synced kepubs, but it is likely to cause problems with some sideloaded kepubs.
|
12-17-2014, 02:54 AM | #70 | |
Connoisseur
Posts: 62
Karma: 13112
Join Date: Feb 2013
Device: Kindle Paperwhite; KOBO AURA HD
|
Quote:
Code:
body p,body div{padding:0.1em!important} |
|
12-17-2014, 03:02 AM | #71 | |
Wizard
Posts: 3,821
Karma: 19162882
Join Date: Nov 2012
Location: Te Riu-a-Māui
Device: Kobo Glo
|
Update for the `Fix kepub side bearing font cut off bug` patchs in post #57. I've added options to the patches to allow for vertical language books:
For the "synced kepubs only" patch there are three options: left/right padding, top/bottom padding, or all four sides (default). The default option should work okay with both horizontal and vertical language kepubs. For the "all kepubs (synced and sideloaded)" patch there are only two options: left/right padding, or top/bottom padding. This means you need to choose whether to fix the bug for horizontal language kepubs or vertical language kepubs, there is no option that works with both. The problem with the sideloaded kepubs is that adding padding on all four sides will cause major side effects such as increased space between paragraphs. It would be possible to add padding to left/right or top/bottom depending on the text writing direction of the current book if there was enough space in the stylesheet, but there is just not enough room. Quote:
Code:
body[writingMode="horizontal-tb"] p, body[writingMode="horizontal-tb"] div {padding-left:0.1em!important;padding-right:0.1em!important} Spoiler:
Last edited by GeoffR; 12-17-2014 at 03:24 AM. Reason: added patch |
|
12-17-2014, 04:55 AM | #72 | |
Connoisseur
Posts: 62
Karma: 13112
Join Date: Feb 2013
Device: Kindle Paperwhite; KOBO AURA HD
|
Quote:
|
|
12-17-2014, 11:59 AM | #73 |
frumious Bandersnatch
Posts: 7,516
Karma: 19000001
Join Date: Jan 2008
Location: Spaniard in Sweden
Device: Cybook Orizon, Kobo Aura
|
I'd use "body>p,body>div" rather than "body p,body div", or nested elements will get increased padding...
|
12-17-2014, 12:40 PM | #74 |
Zealot
Posts: 105
Karma: 37418
Join Date: Jan 2013
Device: Kobo Glo, Aura, H2OE2, Libra 2
|
Tried the third patch and it does stop the tips of "f's" being cut off on both my side loaded and kobo loaded kepubs.
I also tried it with the top padding set to 2 and bottom padding set to 0 in the hope it would correct my pet complaint of marks at the bottom of the page with corresponding bit missing from the top of the text on the next page. On most pages there was no improvement, but on pages which started with a new paragraph then that page did not have bit's missing from the top of the text. Also the previous page did not show corresponding marks along the bottom. I suspect this method can fix my pet issue of marks on the bottom of the page if only the patch can be made to add padding to a page in place of just to a paragraph. Any chance GeoffR ? You've done a great job so far. |
12-17-2014, 12:43 PM | #75 | |
Wizard
Posts: 3,821
Karma: 19162882
Join Date: Nov 2012
Location: Te Riu-a-Māui
Device: Kobo Glo
|
Quote:
BTW, I have been distinguishing between synced and sideloaded kepubs, but really the difference is between Kobo-created kepubs and other kepubs. If you were to sideload a Kobo-created kepub (say by syncing it to the desktop, removing DRM, and sideloading it to the ereader), then it would work just the same as a synced kepub. |
|
|
Similar Threads | ||||
Thread | Thread Starter | Forum | Replies | Last Post |
Instructions for patching firmware 3.11.0 | GeoffR | Kobo Developer's Corner | 226 | 06-01-2015 05:32 AM |
Instructions for patching firmware 3.2.0 | DNSB | Kobo Developer's Corner | 66 | 12-05-2014 07:28 AM |
Instructions for patching firmware 3.8.0 | GeoffR | Kobo Developer's Corner | 92 | 10-22-2014 07:22 AM |
Instructions for patching firmware 3.3.x, 3.4.x, 3.5.x | GeoffR | Kobo Developer's Corner | 285 | 08-27-2014 10:06 AM |
Instructions for patching firmware 3.1.1 | GeoffR | Kobo Developer's Corner | 64 | 04-18-2014 01:23 PM |