[GUI Plugin] User interface action' - Embed Metadata Shortcut

[p0lrb3ar]

Pretty simple plugin, adds a keyboard shortcut for:

• Embed Metadata >> Embed metadata into book files

There wasn't one available before, now there is.


Edit:

I am NOT referring to the other Embed option which there WAS a keyboard shortcut for:

• Embed Metadata >> Embed metadata into FILES OF A SPECIFIC FORMAT from selected books

[p0lrb3ar]

Just realized I misnamed the thread. Hoping a moderator can prepend the [Keyboard Shortcut] in front of the thread name. Thanks

[theducks]

done

[p0lrb3ar]

Originally Posted by theducks

done

[BetterRed]

Originally Posted by p0lrb3ar

. . .

There wasn't one available before, now there is.

But there is, and always has been:



@theducks - it's a 'User interface action' (GUI) plugin, no such thing as a 'Keyboard Shortcut' plugin.



BR

[p0lrb3ar]

That shortcut forces you to pick a book format, which is annoying! Mine does this one, which there was NOT a shortcut for.

[BetterRed]

If there's more than one format which ones does it update?

Did you intend that it be added to the existing Embed Metadata toolbar/menu action, or be a separate action?

IMO it should be one or the other, but not both

BR

[theducks]

Originally Posted by BetterRed

But there is, and always has been:

Attachment 224148

@theducks - it's a 'User interface action' (GUI) plugin, no such thing as a 'Keyboard Shortcut' plugin.

Attachment 224147

BR

changed
(I did as requested without checking)

[kovidgoyal]

https://github.com/kovidgoyal/calibr...3f870dfd1f943e

[p0lrb3ar]

Originally Posted by BetterRed

If there's more than one format which ones does it update?

Did you intend that it be added to the existing Embed Metadata toolbar/menu action, or be a separate action?

IMO it should be one or the other, but not both

BR

No, it is allowing me run the existing Embed command that I prefer to run with a keyboard shortcut. Embedding metadata regardless of type.

If you don't like or understand what I did here, then just don't use it. But, If you have a list of ebpub, mobi, and pdf try both commands so you understand the difference.

[p0lrb3ar]

Originally Posted by kovidgoyal

https://github.com/kovidgoyal/calibr...3f870dfd1f943e

I agree, I should have submitted a branch commit, but I just needed to address it quickly for my project, and hadn't looked at the codebase thoroughly enough to realize it was such a simple change.

What Kovid did is enable the shortcut for the Embed option that I am using. Guessing it will be available in the next release.

In src/calibre/gui2/actions/embed.py Kovid changed line 20:

From:

 action_spec = (_('Embed metadata'), 'modified.png', _('Embed metadata into book files'), None)

To:

 action_spec = (_('Embed metadata'), 'modified.png', _('Embed metadata into book files'), ())

The issue is, I failed to fully understand Calibre's InterfaceAction method where the fourth action_spec value controls shortcut registration.

Here's a breakdown of those values.

- Value-----Behavior
- None-----No entry in shortcut editor, not user assignable, what was assigned
- () --------Registered, but no default key assigned, user assignable, what Kovid changed
- 'Ctrl-E'---Registered with a default key combo, user changeable

Thank you for making that change Kovid!