Suggestions for Sigil Improvements or New Features

[BeckyEbook]

That's not entirely true either. "Regular" SVG is obedient and the color changes immediately. Only that one (from @RbnJrg) is special and requires a "Refresh."

[KevinH]

I can't find his testcase on my laptop which I have with me. Would you please attach RbnJrg test epub to a post in this thread or provide a link to it?

Thanks!

Kevin

[BeckyEbook]

Attached file from this post:
https://www.mobileread.com/forums/sh...63&postcount=1

[KevinH]

Thank you!. I think I have a change that may help even with RbnJrg's test case.

I am going to push it with deploy and post a new Windows test case.
I have my fingers crossed!

Update:

And fwiw, this change made my Mac work with RbnJrg's testcase too!
There seems to be some linkage between the actively loaded url in the QWebEnginePage and its cache. This linkage seems to prevent the cache from being fully cleared (or if cleared it seems to get rebuilt on the fly!).

So I simply changed the order to set the url to "" BEFORE clearing the cache and this seems to help (at least it did the job on my Mac).

I am hoping it will work the same for you.

[KevinH]

Okay, on my personal repo I have uploaded:
Sigil-2.7.5-New_Test2-Windows-x64-Setup.exe

So when you get a free moment would you test that with RbnJrg's test case. It works for me on MacOS so I hope it will work for you as well.

[BeckyEbook]

Yes, it works (Alice + change css, Sample by @RbnJrg + change color, regular SVG + change color), but... the custom_preview_style.css and custom_preview_style_alt.css files stopped working.

[KevinH]

Originally Posted by BeckyEbook

Yes, it works (Alice + change css, Sample by @RbnJrg + change color, regular SVG + change color), but... the custom_preview_style.css and custom_preview_style_alt.css files stopped working.

Wow, that was unexpected. I will see if I can recreate this on my Mac to track down.

[KevinH]

Okay, I can at least recreate this missing custom css bug on MacOS.

It seems we now actually do clear the entire cache. But QtWebEngine somehow treats a "reload" as different from a first load of an xhtml file and actually expects to find things in its local cache and if it can not it looks out on the net for the file and barfs on any "file:" urls in those injected stylesheets (and Mathjax).

Even though we tell Preview and QtWebEngine we are allowed to use local file: urls in the WebProfileMgr when they are not found in the cache on reload it generates an internal error that you can only see in the javascript console of the Inspector:

net::ERR_UNKNOWN_URL_SCHEME

as QtWebEngine has now disallowed the "file:" scheme we use for injected things like the custom css and the mathjax urls.

So this is a real bug in QtWebEngine but not one most people we ever hit so the likelihood of them fixing it will be very low.

The only "workaround" I can find for this limitation is to use our "sigil:" url scheme handler to elude their internal scheme handling bug.

I want to play around with this a whole bunch more before committing it.

A very strange bug to hit.

[KevinH]

Well, after some more testing I think I have worked around the issue with the injected custom css files that was caused by a scheme bug in QtWebEngine Chromium which was disallowing "file:" urls on reload on an empty cache, even though we explicitly enable them and they in fact worked briefly on initial load.

I have pushed this change to master. If anyone builds their own from source and is willing to test, please let me know if all is finally okay.

[DNSB]

Building from master on https://github.com/Sigil-Ebook/Sigil, as soon as I open a stylesheet for editing, the preview pops back to the top of the file. When I flip back to the HTML file, the cursor has moved around a bit but still quite close to the line that I clicked in the preview.

[KevinH]

But Preview is not syncing at all to where you clicked in it, right?

[DNSB]

Preview will resync if I click on the line in CodeView and vice versa. Up to this point, I did not see Preview moving around when I opened never mind edited the stylesheet.

[KevinH]

@DNSB,

Thanks for testing! But are you absolutely sure you are testing with the latest version of source from normal Sigil master (not my site)? I thought we had nailed down at least two fixes earlier, but it looks like we are right back to where we started.

I had hoped that opening Chapter 7 and scrolling down to Preview to about the middle and then clicking in Preview would sync to CodeView. And when you use BookBrowser to open styles.css, then Preview will show its cache of Chapter 7 (you may see a reload flash) but Preview should scroll to the same (or nearly the same) location you clicked in Preview before.

But you are saying it does not work like that (though as I remember it did once for you).

Once you open the styles.css (when following the test instructions) and Preview does NOT do what it should, would you please hit the Inspector and try and see if there are any errors shown in the Javascript Console?

Perhaps that will give me a hint about what is going on.

[DNSB]

I added the debug code for WindowsPreview cache and no errors showed.

[DNSB]

And yes, this was from the latest from the Sigil master. I later added the debug code for the debug windows Preview cache location setting from your personal Sigil repository.

I'm going to give it one more try to make sure everything is where it should be.