Custom identifier: User error?

[ownedbycats]

Created this identifier:

Key: googleplay
Name: Google Play
Template: https://play.google.com/store/books/details?id={id}

Pasting in https://play.google.com/store/books/details?id=AAAAAAA results in a URL identifier.

Entering googleplay:AAAAAAA works and leads to the correct link (though in this example, that's an error page).

Did I make a mistake, or is this a similar error to the resolved one with slashes?

[kovidgoyal]

This should fix it, though I havent tested it: https://github.com/kovidgoyal/calibr...5a01a5609ba2e9

[ownedbycats]

It works. Thank you.

[Comfy.n]

I can't see what the problem was, but I'm glad it's fixed, lol.

[ownedbycats]

I think the ?id= was tripping it up due to the question mark:

vals = {'id' : '(?P<new_id>.+)'}

[kovidgoyal]

Originally Posted by Comfy.n

I can't see what the problem was, but I'm glad it's fixed, lol.

It used a regular expression based on the template. In OP's case the template contains a ? which is a special character in a regexp. So the fix is to escape all special characters in the template before converting it into a regex.

[Comfy.n]

Originally Posted by kovidgoyal

It used a regular expression based on the template. In OP's case the template contains a ? which is a special character in a regexp. So the fix is to escape all special characters in the template before converting it into a regex.

oh, I see. Thanks.

I wasn't thinking templates. Since the clickable link on book details pane just works, this had me thinking what other use of the URL needed to be fixed

[ownedbycats]

I think it was just the 'paste URL' button using that bit of regex. Davidfor wrote that bit of code and he also forgot to account for slashes.